Module: External Phorummail

your unzip program is broken.
the archive contains a folder ext_phorummail ,not with any version number behind that.

---

Thomas Seifert

Thomas,

I have a couple of suggested changes for this module.
One is a bug fix, the other a recommended change. Would you prefer I attach patch files or the entire modified files?

Also, just wanted to say that I appreciate your work.

Please add them as patches.
Easier to incorporate in the already changed local version :).

---

Thomas Seifert

Ok, patches attached.

ext_phorummail.php.patch.gz
- Fix to enable IMAP SSL based on chosen IMAP SSL setting in module settings.

settings.php.patch.gz
- Change mail password text_box to type password, to obscure it from prying eyes.

Hope they're helpful. :)

personally, i prefer:

[code="php"]
- $options->ssl = false;
+ $options->ssl = $forum_mailserver['ssl'] == 1;
[/code]

Quote
arod
personally, i prefer:

[code="php"]
- $options->ssl = false;
+ $options->ssl = $forum_mailserver['ssl'] == 1;
[/code]

So do I!
Looks like a much more efficient rendering, and I would have anticipated someone of Thomas' experience level to implement such a solution in any case. ;-)

I have a few more patches to submit for other modules that I have implemented and I will try to code more efficiently in future. Thank you for taking the time to comment.

I'm getting the following errors with scrip.php --scheduled

PHP Warning: fwrite(): supplied argument is not a valid stream resource in /var/www/vhosts/eswindev.com/subdomains/foro/httpdocs/mods/ext_phorummail/ezc/Mail/src/parser/parts/file_parser.php on line 240
PHP Warning: fwrite(): supplied argument is not a valid stream resource in /var/www/vhosts/eswindev.com/subdomains/foro/httpdocs/mods/ext_phorummail/ezc/Mail/src/parser/parts/file_parser.php on line 240
PHP Warning: fwrite(): supplied argument is not a valid stream resource in /var/www/vhosts/eswindev.com/subdomains/foro/httpdocs/mods/ext_phorummail/ezc/Mail/src/parser/parts/file_parser.php on line 240
PHP Warning: fclose(): supplied argument is not a valid stream resource in /var/www/vhosts/eswindev.com/subdomains/foro/httpdocs/mods/ext_phorummail/ezc/Mail/src/parser/parts/file_parser.php on line 253
PHP Fatal error: Uncaught exception 'ezcBaseFileNotFoundException' with message 'The file '/tmp/32572-1/PAGE_Page2.wwh' could not be found.' in /var/www/vhosts/eswindev.com/subdomains/foro/httpdocs/mods/ext_phorummail/ezc/Mail/src/parts/fileparts/disk_file.php:86
Stack trace:
#0 /var/www/vhosts/eswindev.com/subdomains/foro/httpdocs/mods/ext_phorummail/ezc/Mail/src/parts/file.php(86): ezcMailFile->__set('fileName', '/tmp/32572-1/PA...')
#1 /var/www/vhosts/eswindev.com/subdomains/foro/httpdocs/mods/ext_phorummail/ezc/Mail/src/parts/fileparts/disk_file.php(32): ezcMailFilePart->__construct('/tmp/32572-1/PA...')
#2 /var/www/vhosts/eswindev.com/subdomains/foro/httpdocs/mods/ext_phorummail/ezc/Mail/src/parser/parts/file_parser.php(269): ezcMailFile->__construct('/tmp/32572-1/PA...')
#3 /var/www/vhosts/eswindev.com/subdomains/foro/httpdocs/mods/ext_phorummail/ezc/Mail/src/parser/parts/multipart_parser.php(146): ezcMailFileParser->finish()
#4 /var/www/vhosts/eswindev.com/subdomains/foro/httpdocs/mods/ext_phorummail/ezc/Mail/src/parse in /var/www/vhosts/eswindev.com/subdomains/foro/httpdocs/mods/ext_phorummail/ezc/Mail/src/parts/fileparts/disk_file.php on line 86

Some idea?

Seems like a permissions problem with /tmp folder

Can I change something, to use another folder? I'm in a VPS, and I don't know exactly how this things works.

Try the following changed (untested):
find all occurences (there should be 2 of them) of
[code="php"]
$parser = new ezcMailParser();
[/code]
and add the following line afterwards
[code="php"]
$parser->setTmpDir($PHORUM["cache"]);
[/code]

It should store all temporary stuff in the phorum defined cache directory afterwards.

---

Thomas Seifert

When I manually run the cron job I receive the following:

syntax error, unexpected T_STRING in /home/XXXX/XXXX/XXX/mods/ext_phorummail/ext_phorummail.php on line 237

Any help would be appreciated.