Module: Recent Messages

You are right that this is not a security issue. "Not visible" does not mean that users cannot access the forum. Only that it is not visible for them. I'm not sure what to do with them. If we fix this, then it would have to be done in the core code, because the module relies heavily on the phorum_db_get_recent_messages() function from the database layer.

I'll create a ticket for us devs to reflect on the subject.
Thanks for your comment!

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce

I think an svn export just sets the timestamps to the current time therefore all files get a new timestamp on packaging a release. but maybe I'm mistaken.

---

Thomas Seifert

I do not use an export in my build scripts, but a direct copy from my svn tree, which I tailor into a package. This copying process alone will already set new timestamps on the files. Next to that, I have multiple systems where I can build the packages. That, combined with the fact that checking out data to update the svn tree will set the date/time of new/updated files to the current date and time means that there is no guarantee that unchanged files will keep the same timestamps in my svn trees.

BTW hcgtv: What's your uplink bandwidth anyway? =)

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce



Edited 1 time(s). Last edit at 01/25/2008 02:47AM by mmakaay.

Quote
mmakaay
BTW hcgtv: What's your uplink bandwidth anyway? =)

Upload Speed: 490 kbps (61.3 KB/sec transfer rate)

The particular forum that I'm setting up now is hosted on Textdrive, for some reason, it's very slow to update files. It took about 3 minutes to update the Geshi plugin you updated just a bit ago. Maybe Solaris has issues with permissions or something?

One of the reasons I asked about timestamps was that I noticed that the Phorum release's file's timestamps don't change unless there has been a change to the code, hence my question. Were the release all different timestamps all the time, like what Andi does at DokuWiki, then I wouldn't have asked.

--
Bert Garcia - When all you have is a keyboard

Solaris probably is not the issue. My company provides web hosting as well and we've never seen uploading speed issues. I won't be guessing what is going on here, since there's too many unknown factors. The bbcode_geshi module is pretty big, because of all the languages that it supports. Almost a whopping 1.5 MB in total. So if you find that updating that one is a bit slow, then I can understand it. The recent messages module should update rather quickly though, since it's just above 100KB in total (so if Textdrive's system cooperates, this should only take a few seconds).

I can check if I can keep the dates for unchanged files the same. An svn export seems to preserve the file datestamps from the repository, so I could build my packaging software on top of that instead of copying the data.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce

While studying this code, I came across a typo:

    // Handle paging setup.
    $preg_page = NULL;
    $next_page = NULL;
    if (count($messages) > $show_amount) {
        array_pop($messages);
        $next_page = $page + 1;
    }
    if ($page > 0) {
        $prev_page = $page - 1;
    }

Line 114
$preg_page should be $prev_page

...
Steve H, currently on: (version 5.2.23)
contributions:
Birthdays mod, Top Users mod, Icon legend.tpl, (plus a handful of bugfixes and old 5.0 creations)

Thanks. I fixed it in the package. It's not a functional problem, but it could trigger some warnings for some installations I think. It clearly is a matter of muscle memory, leading my fingers to one of the preg_.... functions =)

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce

I upload a repackaged version 2.0.12 of the module. This one includes a change to set the HTML title to "Recent Messages" when the user is browsing the recent messages. I did not increase the package version, because it is only a minor feature change.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce

This module is given only with the EMERALD template, so when I run it with the general CLASSIC template, the page of recent -messages is altered.
It's doen't seem good, because it's use an another css.tpl.
What I have to do ? build a classic template in this mod or make changes (which?) to some files of Emerauld.
Thanks .

You have to copy "mods/templates/emerald" to "mods/templates/classic" and then apply changes to the classic template to make it look good inside the main classic template.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce