Module Tidy Output is corrupting avatar images

Posted by Oliver Riesen-Mallmann 
Forum List Message List New Topic
Oliver Riesen-Mallmann
Module Tidy Output is corrupting avatar images
June 03, 2013 03:53PM
Hi,

we just switch our server to Debian Wheezy with php 5.4.4. We had to disable the Tidy Output Module since it is now corrupting avatar images (perhaps also other files stored in database). Before we used Debian Lenny with php 5.2.6 and without any problem.

Regards
Oliver

Using Phorum since 7/2000: forum.langzeittest.de (actual version 5.2.23)
Modules "Made in Germany" for version 5.2: Author_as_Sender, CarCost, Close_Topic, Conceal_Message_Timestamp,
Format_Email, Index_Structure, Mailing_List, Pervasive_Forum, Spritmonitor, Terms_of_Service and German_Language_Files_Package.
Reply Quote
Oliver Riesen-Mallmann
Re: Module Tidy Output is corrupting avatar images
June 07, 2013 02:32AM
Hi,

some more information.

When I test with my avatar the output from file.php looks like this:

Module Tidy OFF



Module Tidy ON (image corrupted)



Regards
Oliver

Using Phorum since 7/2000: forum.langzeittest.de (actual version 5.2.23)
Modules "Made in Germany" for version 5.2: Author_as_Sender, CarCost, Close_Topic, Conceal_Message_Timestamp,
Format_Email, Index_Structure, Mailing_List, Pervasive_Forum, Spritmonitor, Terms_of_Service and German_Language_Files_Package.
Reply Quote
Oliver Riesen-Mallmann
Re: Module Tidy Output is corrupting avatar images
June 07, 2013 03:46AM
Hi,

it seems that function phorum_ob_clean in common.php cause the problem.

Since php 5.4 ob_get_status doesn't return an array when buffer is empty. In my testcase ob_get_status() returns 1. Because of this phorum_ob_clean doesn't call ob_end_clean().

Regards
Oliver

Using Phorum since 7/2000: forum.langzeittest.de (actual version 5.2.23)
Modules "Made in Germany" for version 5.2: Author_as_Sender, CarCost, Close_Topic, Conceal_Message_Timestamp,
Format_Email, Index_Structure, Mailing_List, Pervasive_Forum, Spritmonitor, Terms_of_Service and German_Language_Files_Package.
Reply Quote
Oliver Riesen-Mallmann
Re: Module Tidy Output is corrupting avatar images
August 06, 2015 09:05AM
I opened a bug report in Github and provided a patch for common.php:
[github.com]

Using Phorum since 7/2000: forum.langzeittest.de (actual version 5.2.23)
Modules "Made in Germany" for version 5.2: Author_as_Sender, CarCost, Close_Topic, Conceal_Message_Timestamp,
Format_Email, Index_Structure, Mailing_List, Pervasive_Forum, Spritmonitor, Terms_of_Service and German_Language_Files_Package.
Reply Quote
Newer Topic Older Topic
Sorry, only registered users may post in this forum.

Click here to login