New Count module

Hi,

nice module. But i have a problem.

Latest cvs: phorum5-cvs-2004090212.tar.gz
latest mod: new_count-1-3.zip

I've wrote as an admin 3 new messages in the 'Bla Forum'. Topic 'bla bla'.

I've logged out and logged in as a registered user only.

I see the index page with two folders:
Bla Forum
Test Forum
Under the Posts column i see (3 new) posts for the 'Bla Forum'. That's correct.
I click and entered the 'Bla Forum'
I see the 'List page' with one created topic.
The topic is 'bla bla' with 1 new posts.
That is not correct. 1 new post? You remember? I've wrote 3 new posts as admin.

I click and entered the 'bla bla' topic.
I see three new posts marked as red.
Whats goin on? Whats wrong with me?


Again, first i see 3 new posts, then only 1 new post, next i found 3 new messages.


Regards,

Stoebi



Edited 3 time(s). Last edit at 09/02/2004 08:39PM by Stoebi.

Hi,

check this with 'Read Threads Expanded = Yes', please
and you hopefully understand me.


Regards, Stoebi


Edit:
In 'Flat mode' works great'
but in
'Threaded mode' the counts are wrong.



Edited 1 time(s). Last edit at 09/04/2004 02:13AM by Stoebi.

Thanks for your report, I'll look into it when I get back home next monday.

I think I have to make a test phorum for myself so I can test it better.

---
-=[ Panu ]=-

I hope this fixes every known and unknown bug :)

Unfortunately I disabled counting of new messages for threaded mode, but I quess there is not much use for new flags in that mode anyway.

Let me know if that functionality is desired and I'll see what can be done.

---
-=[ Panu ]=-

latest changes in phorum /move thread with notification/ is cause warning texts:

Warning: array_diff(): Argument #1 is not an array in ...\new_count\new_count.php on line 39

Warning: Invalid argument supplied for foreach() in ...\new_count\new_count.php on line 42

--
Tomasz Regdos :: www.regdos.com

don't use the HEAD-code, just use the stable-snapshots.

---

Thomas Seifert

Actually I would not change the $messages['new'] String, but create a new one called $messages['new_messages'] analog to the variable created for the index page. And of course the count does not make sense for a threaded list.

Before going the module way, I hacked the list.php to serve the count. Since this is Very, VERY easy, maybe the Phorum Hackers could just add 2 lines like:

   
   $rows[$key]["new_messages"] = 0;

and

   
  $rows[$key]["new_messages"]++;

in the list.php flat view ;)

Everybody could decide, how to use it in their templates, and no expensive extra module is needed.

Hi all. Did anybody try this mod? Because I would like to see what it looks like before I put it on my phorum.
Thanx

Well it looks like this:

"5 new"

instead of this

"new"

(in red by default of course, and 5 can be anything between 1 and n)

---
-=[ Panu ]=-

Hi....
How does $langs[$langkey]['single'] (/ multiple) works? Where should i add something (possibly to lang file) to use this feature?

regards
Borys