New editor tools module for Phorum 5.1+

Alright, I just did that and that seems to work. I just tried to register a new user and that worked, thanks, just wonder what more problems I can face.

Thanks for the help.

I've just had a look at this module. Easy to install and so far seems to do what it says on the box. I've had some trouble getting the mark up produced by it to validate.

In particular, at the start of phorum_mod_editor_tools_tpl_editor_before_textarea() a <noscript> block is echoed containing an unordered list. The list items are not closed (there is no </li> within the foreach loop). Also, using XHTML 1.0 Transitional I got complaints about the ul element not being allowed here. I think because it is contained in a <font> element.

The following seemed to do the trick:

function phorum_mod_editor_tools_tpl_editor_before_textarea()
{
    $help = $GLOBALS["PHORUM"]["MOD_EDITOR_TOOLS"]["HELP_CHAPTERS"];
    $lang = $GLOBALS["PHORUM"]["DATA"]["LANG"]["mod_editor_tools"];

    if (!count($help)) return;

    print '<noscript><br/><br/><div style="font-size: -1">';
    print $lang['help'] . "<br/><ul>";
    foreach ($help as $helpinfo) {
      print "<li><a href=\"" . htmlspecialchars($helpinfo[1]) . "\" " .
            "target=\"editor_tools_help\">" .
            htmlspecialchars($helpinfo[0]) . "</a><br/></li>";
    }
    print '</ul><br/></div></noscript>';
}

Not sure I like the hard coded <br /> s or, hardcoding a smaller font. This is style / presentation and belongs in the theme, not here.

This is already fixed in the editor-tools included in 5.2.

---

Thomas Seifert

I installed the topic poll module and for some reason it stopped the Editor Tools controls from appearing. To fix it I had to disable the Poll mod and then reenable it again. Any idea why this should be?

/\dam

--
My notable Phorum sites:
Movie Deaths Database - "review comments" system mostly powered by Phorum
Learn Chinese! - integrated forum quiz

I have no idea really. I am running both these modules on my own server without problems. I would have to test this on a clean install later today (I'm not at home currently).

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce

Very nice module! Is there any way to add editor tools to the signature part in cc_usersettings.tpl? I want to have an alternative to html. I'm using the namedposting module and have the two signature fields (sig1 and sig2), but I'm about to disable html for both custom fields, as unclosed tags end up leaking into the layout of the page.

-------------------------------------------

"Everything we see or seem, is but a dream within a dream." -Edgar Allan Poe

Hi together,

i'm trying to get this mod running, but it doesn't appaer in the phorum itself. I disabeld the original version, deletet it, logged out, uploaded the new one and loggind in an enabled that version. It correctly appears in the adminarea, but doesn't appear in the forum.

firebug shows the messages:

editor_tools_lang is not defined
</div>
read.php (line 832)

editor_tools_construct is not defined
editor_tools_smileys_a[19] = 'cool smiley';
read.php (line 1021)

thank you for your help
Sun

Are you using a modified template that does not have {HEAD_TAGS} in the <head>...</head> section of your page? That template variable must be in there, so modules can add javascript code to the page header.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce

Yes, the template -was- modified.

But now, i had a long night and updatet to 5.2 ... and love it :D

Great! Welcome to the 5.2 club!
More testers are always good news.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce