Module: Forum Subscriptions

Re: Module: Forum Subscriptions

John Espirian — Tue, 21 Jul 2015 09:34:39 -0500

The Forum Subscriptions module is working better now that I've moved my Phorum to another server, but I've realised that notifications don't get through to Gmail users.The same is true for virginmedia and ntlworld addresses, which run on the Google Apps mail platform. I've done the usual checking of Google's Spam/Promotions/All Mail folders – the messages really aren't arriving.

I've experimented by changing my own Phorum account to use a few non-Google addresses and, sure enough, the notifications come through almost instantly. The Event Logging module also seems to confirm that the messages are at least being sent in each case, so it's the recipient end that doesn't like the content. What a pain.

Just sharing here in case anyone else runs into the same problem.

Re: Module: Forum Subscriptions

John Espirian — Wed, 22 Apr 2015 10:39:06 -0500

I've been having problems with this module for a little while now and can't work out what's going on.

My forum is seeing the same 'illegal string offset' errors mentioned by yupri in this post. I changed line 483 of db_functions.php to return DB_RETURN_ASSOCS instead of DB_RETURN_ASSOC. This got rid of the errors but the module still wouldn't send out emails (this was my basic problem to start with).

I've turned on debugging and looked at the output through the Event Logging module. The only users ever to receive emails seem to be those who have subscribed to all forums. Anyone who's subscribed to individual forums doesn't seem to receive messages. Individual subscriptions do work for my own account, but I wonder whether that might be because I'm an admin.

I'm at a bit of a loss to explain what's happening, so if anyone could point me in the right direction, I'd very much appreciate it.

If it's relevant, I'm using a once-per-minute cron job that works perfectly for other forum-related tasks (e.g. importing via External Phorummail).

Re: Attachments and store_files_on_disk module...

Rob Granger — Thu, 19 Sep 2013 21:58:10 -0500

I updated my save file on disk to the 1.1.1 version and it seems that the phorum_db_file_get is not pulling the data from the file system. I will try and do more digging.

Joe, would it be possible to add a link to the file instead of attaching the attachment? I have allow links and it seems like this would be the easy solution to avoid having to deal iwth the store_files_on_disk module. Now that I have really downsized, I should disable that but I don't want to lose the attachments.

Attachments and store_files_on_disk module...

Rob Granger — Thu, 19 Sep 2013 20:48:48 -0500

I guess I just was always too busy to look, but it seems that with that module the attachments are not being attached.
I just now saw this, i will attempt to debug and see if maybe replacing the attachment string with the full path to were images are stored will enable the mailer to attache the file.
will follow up when I have more info.
Thanks again for the module, joe!

I was digging around and maybe I need to find the store_files_on_disk.1.1.1, I have 1.1.0, off to search to see if I can find the changes or the module.

Re: Module: Forum Subscriptions

yupri — Wed, 17 Apr 2013 06:46:18 -0500

I've just looked up and read your message.
I noticed the same functioning.

The reason was incorrect check of user read permissions for forums.

In mods/forum_subscriptions/forum_subscriptions_after_post.php

phorum_api_user_check_access(PHORUM_USER_ALLOW_READ, PHORUM_ACCESS_LIST, $user_id)

and

phorum_api_user_check_access(PHORUM_USER_ALLOW_READ, PHORUM_ACCESS_LIST, $user_id)

didn't return the correct results.

I've rewritten those parts.

If anyone is interested I can submit my bug fixes of this module.

Re: Module: Forum Subscriptions

yupri — Wed, 17 Apr 2013 06:11:33 -0500

Joe,

I think forum access functions like
[code="php"]
phorum_api_user_check_access(PHORUM_USER_ALLOW_READ, PHORUM_ACCESS_LIST, $user_id)
[/code]
or
[code="php"]
phorum_api_user_check_access(PHORUM_USER_ALLOW_READ, $mail_data["forum_id"], $user_id)
[/code]
in forum_subscriptions_after_post.php don't yield the correct results, which can be retrieved from
[code="php"]
phorum_db_user_get($user_id, true)
[/code]
in 'forum_permissions' and 'group_permissions'.

I found that phorum_api_user_check_access with 3 parameters is called only in your module. It can be the cause of problem.

Would you please examine this issue and comment?

Re: Module: Forum Subscriptions

yupri — Thu, 21 Feb 2013 06:47:03 -0600

I think there is a bug in the forum_subscriptions/db_functions.php:483

$return_val shouldn't be DB_RETURN_ASSOC but rather DB_RETURN_ASSOCS. In this case the whole assignment should be pulled out of if-then-else branching and assigned DB_RETURN_ASSOCS.

Otherwise, it issues a warning like that:

Warning: Illegal string offset 'forum_id' in [%phorum_folder%]/mods/forum_subscriptions/db_functions.php on line 497
Warning: Illegal string offset 'forum_id' in [%phorum_folder%]/mods/forum_subscriptions/db_functions.php on line 497
Warning: Illegal string offset 'forum_id' in [%phorum_folder%]/mods/forum_subscriptions/db_functions.php on line 498
Warning: Illegal string offset 'forum_id' in [%phorum_folder%]/mods/forum_subscriptions/db_functions.php on line 497
Warning: Illegal string offset 'forum_id' in [%phorum_folder%]/mods/forum_subscriptions/db_functions.php on line 497
Warning: Illegal string offset 'forum_id' in [%phorum_folder%]/mods/forum_subscriptions/db_functions.php on line 498

I noticed the warning is issued in case a user tries to subscribe to

an already subscribed forum;
a forum when already subscribed to all of them;
all forums when already subscribed to all of them.

Would you confirm this bug should be corrected?

Looking forward to your answer.

Thank you.

Re: Module: Forum Subscriptions

lui2010 — Wed, 25 Jul 2012 11:42:11 -0500

I was wonderring if there is a way to have the default state of a new user to be subscribed to all forums? Then they will have the option to opt out if they want. This is a rally helpful mod. Thanks.

-Luis

Re: Module: Forum Subscriptions

korsakov — Fri, 27 Jan 2012 10:58:43 -0600

You could also add to the module error logs Joe integrated within the code in order to check on specific data. I regret that he does not seem to be part of the team anymore.

Re: Module: Forum Subscriptions

Thomas Seifert — Thu, 26 Jan 2012 15:33:53 -0600

I'd say, check the mailserver logs - but I also didn't write this module.

Re: Module: Forum Subscriptions

bartek.s — Thu, 26 Jan 2012 01:14:19 -0600

Hi Thomas,

checked twice on two accounts - no mail in inbox&spam folders. What do you suggest to check (logs/files) in engine?

Thanks for info :)
Bartek

Re: Module: Forum Subscriptions

Thomas Seifert — Wed, 25 Jan 2012 15:00:25 -0600

the log entries report it has sent the email. Are you sure that they are not going out and not only landing in the spam folder?

Re: Module: Forum Subscriptions

bartek.s — Wed, 25 Jan 2012 02:32:20 -0600

Hello, this module functionality looks great for us, thanks Joe!

One thing is that it do not send emails. NO cronjob. No errors in Event Log (img below). Module settings below.

.

What could be the cause of problem? Thanks for advice!

Kind regards
Bartek

Re: Module: Forum Subscriptions

Maurice Makaay — Wed, 05 Oct 2011 05:16:16 -0500

The number of members is totally irrelevant for the mail functionality. Apparently your hosting partner does not have their PHP / system setup working for solid mail delivery via PHP directly.

Re: Module: Forum Subscriptions

roymurray — Tue, 04 Oct 2011 22:25:13 -0500

With 500 members plus I had to change to smtp because only about 2% of the emails were going out.

Re: Module: Forum Subscriptions

Kris — Thu, 29 Sep 2011 15:42:16 -0500

Having an issue when using the global set options to receive email or digests for "All Forums", which should set the option the same for all forums. When using the global setting, users will never get email or digests. When users select the forums individually for their preferences, emails and digests are sent normally. Has anyone run into this?

Re: Wanted: Forum Subscriptions Expert

korsakov — Fri, 01 Jul 2011 12:37:36 -0500

Here is the error message I received within my error logs:

PHP Fatal error: Cannot unset string offsets in .../mods/forum_subscriptions/forum_subscriptions_scheduled.php on line 86

[code="php"]
:
unset($PHORUM["phorum_mod_forum_subscriptions"]["pre_run_forums_by_digest"][PHORUM_MOD_FORUM_SUB_FREQUENCY_DAILY]);
:[/code]

After commenting out this line it seems to work again. Thanks for your quick reply, Thomas.

Re: Wanted: Forum Subscriptions Expert

Thomas Seifert — Fri, 01 Jul 2011 10:41:28 -0500

"somehow ... stops" doesn't really give a hint and removing the db functions isn't helpful either. Get your php error logs to show you the error occuring.

Wanted: Forum Subscriptions Expert

korsakov — Fri, 01 Jul 2011 09:28:35 -0500

I removed [code="php"]
require_once ("./mods/forum_subscriptions/db_functions.php");
[/code] and the settings page works now.

Is there anybody out there who might be able to assist me with a modification of this module? I have already added the code.

Re: Module: Forum Subscriptions

korsakov — Tue, 28 Jun 2011 18:24:43 -0500

I just freshly installed this module to an up-to-date Phorum installation but don't get the settings page up.

Somehow, the module stops after require_once ("./mods/forum_subscriptions/db_functions.php");

START of "settings.php
[code="php"]

// Make sure that this script is loaded from the admin interface.
if(!defined("PHORUM_ADMIN")) return;

global $PHORUM;

// pull in the mail queue database functions
require_once ("./mods/forum_subscriptions/db_functions.php");

[/code]

Could anybody please give me a hint what might be wrong?

Re: Module: Forum Subscriptions

Giam Teck Choon — Tue, 12 Apr 2011 13:48:52 -0500

Quote
choon
I believe I need to add in phorum_api_user_check_group_access() somewhere in order to support private group forums subscription?

Nevermind for now. I found a way and hacked this module to support private group now ;)

Thanks.

Kindest regards,
Giam Teck Choon

Re: Module: Forum Subscriptions

Giam Teck Choon — Mon, 11 Apr 2011 06:56:45 -0500

Hi,

This module currently does not support private group forums subscription. i.e. If I create a group and all forums under this group with no public and registered users (private forum) and only add certain users into this group, those users will not get email notification about new threads and/or replies under those private group forums.

I check the related code in forum_subscriptions_after_post.php:
[code="php" number="24"]
// if there are no subscribers then we are done
if (empty($subscribers)) return $data;

$user_ids = array();
foreach ($subscribers as $subscriber) {
// if the user does not have read access to this forum
// or the user only wants new threads and this is a reply
// then we are done
if(!phorum_api_user_check_access(PHORUM_USER_ALLOW_READ, $data["forum_id"], $subscriber["user_id"])
|| (!empty($data["parent_id"]) && $subscriber["sub_type"] == PHORUM_MOD_FORUM_SUB_SUBSCRIBE_NEW_THREAD)) continue;

$user_ids[$subscriber["user_id"]] = $subscriber["user_id"];
}

// if there are no valid subscribers then we are done
if (empty($user_ids)) return $data;
[/code]

I believe I need to add in phorum_api_user_check_group_access() somewhere in order to support private group forums subscription?

I hope I can explain it better... ... :(

Thanks.

Kindest regards,
Giam Teck Choon

Re: Module: Forum Subscriptions

korsakov — Fri, 11 Mar 2011 09:36:13 -0600

I understand that you currently focus more on your recent family addition than on Phorum. In case you have a free minute for contemplation I wanted to suggest the improvement of the daily digest mode by listing and numbering the topics on the top of the digest. It becomes a challenge to find anything within large digests. Thanks for your consideration!

Re: Module: Forum Subscriptions : Collecting digests in one email?

korsakov — Fri, 25 Feb 2011 09:33:24 -0600

Joe, please let me know if you want to include my hack that allows to restrict users to only get notified from forums which belong to their groups (when they choose the "All" option). Thanks.

Re: Module: Forum Subscriptions : Collecting digests in one email?

korsakov — Thu, 24 Feb 2011 08:16:55 -0600

I am wondering whether anybody has tried to collect digests in one single mail in case the user has signed up for several forums. It would help to unclutter mailboxes.

Re: Module: Forum Subscriptions

korsakov — Mon, 21 Feb 2011 23:28:31 -0600

Thanks! This modification apparently fixed the issue.

Re: Module: Forum Subscriptions

Maurice Makaay — Sun, 20 Feb 2011 03:12:01 -0600

I cannot replicate the behavior. That module only mangles the http_path setting when SCRIPT_URI or HTTP_HOST is set in the $_SERVER data. In a CLI / cron environment, these should not be set.

You can try version 1.0.6. I changed the isset() check to an empty() check, so a set but empty $_SERVER['http_host'] variable will not mangle the URL.

If you keep having troubles, then you're out of luck. I really don't see where your issue is originating from.

Re: Module: Forum Subscriptions

korsakov — Sat, 19 Feb 2011 14:34:11 -0600

Thanks, Maurice. I found out that "Automatic HTTP Path (version 1.0.5)" is clearly messing with the links from this module. I had to turn it off. Anyway, I am very glad that it works now!

Re: Module: Forum Subscriptions

korsakov — Tue, 15 Feb 2011 13:39:01 -0600

Thanks Maurice! In fact, I do run the module for automatic HTTP paths. Do you suggest to modify this module (although it does not get tripped)?

Re: Module: Forum Subscriptions

Maurice Makaay — Tue, 15 Feb 2011 10:57:29 -0600

Just a hunch: maybe you are running the module for having dynamic HTTP Path settings. From a cron job, there is no server environment, which might trip that module. The module could make use of the default HTTP Path setting when no URL can be derived automatically or the module could have a configuration option to configure the URL to use from there for such cases.