Module: Favorite Forums

Re: Module: Favorite Forums

nvrtis — Thu, 28 Jul 2011 13:25:42 -0500

I think some of the problems with conflicts between this module and other modules is that at around line 181, you have
[code="php"]
} else if (count($PHORUM["DATA"]["BREADCRUMBS"]) < 2 || isset($PHORUM["DATA"]["BREADCRUMBS"]["favorites"])) {
$forum_source = $PHORUM["DATA"]["FORUMS"];
[/code]

And use $forum_source to rebuild the list you return to the hook exit. So if another mod is running before favorites, any changes that mod makes are lost when favorites runs.

One way to fix this would be to give favorites a priority so it runs 'first' at the index hook. Which sort of makes sense because favorites adds entries to the list of forums....

Re: Module: Favorite Forums v5.2.1.04 - bugfix

nevasport — Mon, 01 Nov 2010 14:37:19 -0500

Quote
Joe Curia
I have released v5.2.1.4 of this module with the following changes:

- Bugfix: Users can now deselect all favorited forums from the Control Center. Thanks go to Phorum user masei1202 for reporting this bug.

- Bugfix: Removed various PHP notices.

- Bugfix: Updated Phorum version requirement to be compatible with the Phorum version checker.

Thanks Joe, we will give it a try.

My problem was related with some issues when using this module with "last post" mod. I guess you did not solve that problem, did you?

Thanks.

pepe

Module: Favorite Forums v5.2.1.04 - bugfix

Joe Curia — Mon, 01 Nov 2010 13:07:22 -0500

I have released v5.2.1.4 of this module with the following changes:

- Bugfix: Users can now deselect all favorited forums from the Control Center. Thanks go to Phorum user masei1202 for reporting this bug.

- Bugfix: Removed various PHP notices.

- Bugfix: Updated Phorum version requirement to be compatible with the Phorum version checker.

Re: Module: Favorite Forums

nevasport — Wed, 08 Sep 2010 07:39:46 -0500

Hello folks,

I´ve added this module to my forum list, looks great, nevertheless, when you select any forum as favourite, the rest of the list does not show the "last post module", author and subject appear empty, does anyone knows how to solve this?

Example

Thank you in advance.

pepe

Re: Module: Favorite Forums

salvax — Fri, 27 Aug 2010 10:25:13 -0500

There is a bug in this module.

When a user is logged in and trying to open an attachement it redirects user to the main page. The problem is in here;

[code="php"]
if (!empty($PHORUM["args"])) {
if (in_array("addfavorite",$PHORUM["args"])) {
//Add a forum to the favorite forum list from a link
if (!empty($PHORUM["user"]["FavoriteForums"])) {
$PHORUM["user"]["FavoriteForums"] = $PHORUM["user"]["FavoriteForums"].",".$PHORUM["args"][0];
} else {
$PHORUM["user"]["FavoriteForums"] = $PHORUM["args"][0];
}
$user_to_update = Array(
"user_id" => $PHORUM["user"]["user_id"],
"username" => $PHORUM["user"]["username"],
"FavoriteForums" => $PHORUM["user"]["FavoriteForums"]
);

phorum_api_user_save($user_to_update);
if (in_array("index",$PHORUM["args"])) {
$dest_url = phorum_get_url(PHORUM_INDEX_URL);
phorum_redirect_by_url($dest_url);
exit();
}
[/code]

I have changed this line;
[code="php"]
if (!empty($PHORUM["args"])) {
[/code]

with this as a quick&dirty solution, but it needs a better one.
[code="php"]
if (!empty($PHORUM["args"]) && !preg_match("/^\/file\.php/", $_SERVER['PHP_SELF'])) {
[/code]

best,

Re: Module: Favorite Forums

korsakov — Fri, 19 Mar 2010 15:55:23 -0500

Thanks for the hint, Thomas! I managed to integrate the folder list into register.tpl. Now I am trying to set the custom variable $folder_sel with the selected $forum_id (line 3). It only catches the value 1 though. What is the mistake I make? Thank you!

[code="php" number]
global $PHORUM;
$forums = phorum_mod_favorite_forums_get_forums();
$content = "".$HTML_wrappers["data_end"];
print $content;
[/code]

Re: Module: Favorite Forums

Thomas Seifert — Fri, 19 Mar 2010 13:07:12 -0500

you mean in the form? add it in the template then.

Re: Module: Favorite Forums

korsakov — Fri, 19 Mar 2010 13:03:42 -0500

Yes, I did. I assumed that "before_register" is the hook after the user submitted his registration data. I need to add an option during the registration process. Thanks.

Re: Module: Favorite Forums

Thomas Seifert — Fri, 19 Mar 2010 12:49:57 -0500

did you check the developer manual? there is a section called "user data handling" for hooks where there are quite some registration hooks.

Re: Module: Favorite Forums

korsakov — Fri, 19 Mar 2010 12:40:44 -0500

No, I am sorry that I didn't catch it! Thanks, problem solved!
Could you give me a hint how to use this module to integrate an option for users to select their preferred (home-)folder during registration while setting a custom field with the according folder id? I think that there is no hook "during_registration"!? I need this option in order to set forum permissions. Thanks for your thought!

Re: Module: Favorite Forums

Joe Curia — Fri, 19 Mar 2010 11:37:31 -0500

Please redownload the module and reupload the info.txt file. The required version was set at 5.2 and should have been 5.2.01. Thanks for catching that bug.

Re: Module: Favorite Forums

korsakov — Thu, 18 Mar 2010 00:18:17 -0500

Is this module dependent to another module? I am not able to activate it, the according field on the admin panel is grey although I uploaded a fresh version. Mh..

Module: Favorite Forums v5.2.1.03 - Url's now crafted using the proper Phorum functions

Joe Curia — Sun, 03 May 2009 22:01:19 -0500

I have release v5.2.1.03 of this module with the following change:

- Bugfix: Url's are now crafted using the proper Phorum functions for better compatibility with other modules. Thanks go to Phorum user equus-webdesign for reporting this bug.

This should take care of your SEF Url's module compatibility issues.

Re: Module: Favorite Forums

equus-webdesign — Sat, 02 May 2009 22:20:24 -0500

Thanks for looking into it. Without SEF, the module does what I need it to do and I would like to tweak it to do two sets of favorites. However, when I was reading through the SEF code, it was a bit over my head and I couldn't figure out how to fix the favorites to get it to work.

Re: Favorite Forums and Sef URLs

Joe Curia — Fri, 01 May 2009 16:55:22 -0500

This module is definitely not compatible with the SEF module as it is written. When I get a chance (possibly this weekend, no promises) I will take a look at what needs to be done to make it compatible. Thanks for reporting this problem.

Favorite Forums and Sef URLs

equus-webdesign — Fri, 01 May 2009 16:43:20 -0500

I had sef urls added on and then added in the favorite forums module. The sef urls do not seem to be converting the favorite forum links correctly. Any ideas on how to fix this?

Module: Favorite Forums v5.2.1.02 - bugfixes, Simple Rounded template support

Joe Curia — Fri, 06 Feb 2009 11:13:24 -0600

I have completed v5.2.1.02 of this module with the following changes:

- Enhancement: Support added for the Simple Rounded template.

- Bugfix: Forum selection now includes multiple layers of folders and forums, showing only those to which the user is allowed read access. Thanks go to Phorum user korsakov for reporting this issue.

- Bugfix: The Control Center settings will now only show on the Forum Settings panel. Thanks go to Phorum user korsakov for reporting this issue.

- Bugfix: Forums not shown on Forum Settings page due to array_merge overwriting forum ids with sequential index numbers.

Korsakov, this release should address all of the issues you reported.

Re: Module: Favorite Forums

Joe Curia — Fri, 16 Jan 2009 09:06:15 -0600

Just to assure you, I haven't ignored this post and am looking into fixes for the problems you mentioned. My schedule is permitting less time for this however, so it may be next week before I have it ready.

Re: Module: Favorite Forums

korsakov — Thu, 15 Jan 2009 11:13:14 -0600

Hello Joe, you appear to only include the first two directory layers for selection. Am I right?
I noticed that the Forum selector also appears on several other Control Center links, not only under Forum settings as stated.
As soon as I activate this module, unfortunately any selectors of your Enhanced Profile module won't be displayed anymore in "Edit My Profile".
Thanks for your help!

PS: Could you maybe direct me to the file in which I can check on the date format of "Registered:" and "Last Activity:"?

Quote
View My Profile
Registered:
1226718627
Last Activity:
1232037314

Re: Module: Favorite Forums

korsakov — Mon, 12 Jan 2009 20:35:59 -0600

Hi Joe!
I installed "Favorite Forums" but only a small portion appears in the menu to select from.
What might be the reason? Thank you!

Re: Module: Favorite Forums

Bertrand Le Guern — Mon, 27 Oct 2008 14:10:17 -0500

Also forgotten! my hack in index_new.tpl



{FORUMS->name}{IF FORUMS->new_message_check}  ({LANG->NewMessages}){/IF}

Re: Module: Favorite Forums

Bertrand Le Guern — Mon, 27 Oct 2008 13:59:39 -0500

I have forgotten, I have approved your registration.

Re: Module: Favorite Forums

Bertrand Le Guern — Mon, 27 Oct 2008 13:52:47 -0500

I did not change anything, the
[code="php"]
$forums[$tempid]['description'] .=
"$str";
[/code]

of onlineusers.php make it to appear in the

{IF FORUMS->description}{FORUMS->description}{/IF}

of index_new.tpl

the hack I have done in your code, I have changed your:

[code="php"]
if (!in_array("favorites",$PHORUM["args"])) {
foreach ($forum_source as $forum_id => $forum_data) {
$forum_data["URL"]["ADD_FAVORITE"] = str_replace("/list.php?","/index.php?",$forum_data["URL"]["LIST"].",addfavorite,index");
$forums[$i] = $forum_data;
$i++;
}
[/code]
into

[code="php"]
$j = 0;
if (!in_array("favorites",$PHORUM["args"])) {
foreach ($forum_source as $forum_id => $forum_data) {
$forum_data = $data[$j];
$forum_data["URL"]["LIST"] = phorum_get_url( PHORUM_LIST_URL, $forum_data["forum_id"] ).",favorites";
$forums[$i] = $forum_data;
$i++;
$j++;
}
[/code]

Joined two print screen of an non admin user you may notice "LPV admin" appears in the options but not on the screen

Re: Module: Favorite Forums

Joe Curia — Mon, 27 Oct 2008 13:27:52 -0500

1. What code did you add to your index page to show the online user info inline with the forum titles/links? I need to see that to debug.

2. With your moderator-only forum, did you create a non-admin/non-moderator user to confirm that the forum does not show up as a possible favorite? Please note that your admin account will always have access to that forum, even if you do not make your account an explicit member of the moderator group. I have registered a testuser account for your forum, could you please activate that account so I can see the problem first-hand?

Thanks

Re: Module: Favorite Forums

Bertrand Le Guern — Mon, 27 Oct 2008 12:45:54 -0500

I join a print screen with two windows, the one on the left run your last release of favorite_phorum, the other, on the right runs my hacked version.

You may see two errors with your version:
1) onlineusers not working
2) an error with add/remove forums, not taken on account properly

Your last version still don't work with my moderators only forums (may be I did not set it properly as the documentation about users groups is very scarce on Phorum!) I made an user group "LPV admin" and a forum "LPV admin with" no right for any users.

It displays that forums in the forum options combo box.

Joined also my settings for onlineusers.

Re: Module: Favorite Forums

Joe Curia — Mon, 27 Oct 2008 11:28:11 -0500

Please redownload the module. I did see an issue with displaying forums in the Forum Settings page, but it does not seem to be related to either of your issues.

What version of Phorum are you running?

I have tested this mod on 5.2.9 with the online users and a forum with group access only. The online user info showed on all pages as expected. The list of forums for selection from the Forum Settings page showed only the forums my test users had access to.

Could you create a test user and make sure that user cannot access the moderator-only forum?

Could you be more specific as to which online user information is not showing on the list pages of forums not set as favorites? Is the entire online user area not shown? Is a particular user not shown?

Finally, what are your settings for the online user module?

Re: Module: Favorite Forums

Bertrand Le Guern — Mon, 27 Oct 2008 02:47:01 -0500

Two notices:

1) this module conflicts with module onlineusers: the onelineusers information is stripped out for the list of forums who are not favorites.

2) it does not take on account the users groups. For instance I have installed a forum only seen by the moderators of our forum, but it appears in the list of availlable forums.

Re: Module: Favorite Forums

SecretNinjaMan Maker — Wed, 06 Aug 2008 19:14:12 -0500

Yeah, I was wondering about that too. I downloaded many many modules over the past few days and then I found Tabbed Emerald and this, jumpmenu, and several other ones all do not seem to be working.

Re: Module: Favorite Forums

Joe Curia — Wed, 06 Aug 2008 18:34:24 -0500

Hmm, it must be a div/page size issue. Try adding the new link somewhere else in the template. However, this mod is not yet compatible with my Tabbed Emerald template. That template will not show a favorites folder. It is on my to do list, but August is a very busy month for me, sorry.

Re: Module: Favorite Forums

SecretNinjaMan Maker — Wed, 06 Aug 2008 16:58:49 -0500

Somehow when there is more than 1 page the Add to Favorites messes up the format: