Module: Author as Sender

Re: Module: Author as Sender

Oliver Riesen-Mallmann — Tue, 08 Sep 2015 03:23:48 -0500

2015/09/08 version 1.4.4 Oliver Riesen (oliver@riesen.org)
- Performance improvement.

Re: Module: Author as Sender

Oliver Riesen-Mallmann — Mon, 08 Jul 2013 02:26:37 -0500

Hi Pat,

Quote
pat
... but how does it now the default email-adress of the forum, it seems to me that this is an phorum internal fallback.

My module uses the email address of the author OR the forum default address. There is no fallback.

Regards
Oliver

Re: Module: Author as Sender

pat — Sat, 06 Jul 2013 12:42:46 -0500

... but how does it now the default email-adress of the forum, it seems to me that this is an phorum internal fallback.

Re: Module: Author as Sender

Oliver Riesen-Mallmann — Mon, 01 Jul 2013 07:41:12 -0500

Hi Pat,

Quote
pat
Is it some security (eg anti Spam) thing of the webhost, maybe - that does'nt allow to send email from a domain, with a different domain as sender?

Yes, thats possible but out of influence of my module...

Regards
Oliver

Re: Module: Author as Sender

pat — Sun, 30 Jun 2013 16:48:48 -0500

Hi Oliver,

yes option is marked and email is public. Is it some security (eg anti Spam) thing of the webhost, maybe - that does'nt allow to send email from a domain, with a different domain as sender? But if that would be the case how would this supposed security thing now the default emailadress of the forum?

Re: Module: Author as Sender

Oliver Riesen-Mallmann — Thu, 27 Jun 2013 01:51:52 -0500

Hi Pat,

Quote
pat
This is not working for me. I use Phorum 5.2.18 but this module only changes the Name of the sender to the authors display name but email address stays default EMail. What can I do?

I use 5.2.19 and it works for me. Please note:

Quote

Use authors email-address
If this option is marked and if the users email address is public the module will use the users email address. In other cases the primal email address is used which is by default "System Emails From Address" from "Global Settings". Other modules like the Mailing List Module can specify a differing email address.

Regards
Oliver

Re: Module: Author as Sender

pat — Wed, 26 Jun 2013 15:32:42 -0500

This is not working for me. I use Phorum 5.2.18 but this module only changes the Name of the sender to the authors display name but email address stays default EMail. What can I do?

Re: Module: Author as Sender

Oliver Riesen-Mallmann — Wed, 24 Nov 2010 06:48:25 -0600

New version 1.4.3:

2010/11/24 version 1.4.3 Oliver Riesen (oliver@riesen.org)
- Using now the display name of the reporting user in case of reporting a post
instead of the original author; thanks to Robert Angle.

Re: Module: Author as Sender

Oliver Riesen-Mallmann — Thu, 15 Jul 2010 15:28:32 -0500

Hi deadesq,

Quote
deadesq
Error returned was: The following From address failed: Dave Fleishman

Yes, because $PHORUM['system_email_from_address'] is just a mail address like deadesq@deadesq.com (without user name). I think this cause the problem.

Regards
Oliver

Re: Module: Author as Sender

deadesq — Thu, 15 Jul 2010 14:03:36 -0500

Thanks for this--I edited the file, and I'm still getting an error:

User info:
User ID = 2, username = test [ view user's profile ]
User IP address = 63.201.4.214
Additional details:

Message:
There was an error sending the message.
Error returned was: The following From address failed: Dave Fleishman

So--it's either choking on the SMTP module, or on the SMTP server itself. I don't think it's the latter, because I've entered the authenticated server information correctly, and it works, so long as the email address from the post to the board matches the system email address. If it's anything other than that, it throws the error.

Re: Module: Author as Sender

chriss — Thu, 15 Jul 2010 12:38:13 -0500

Quote
deadesq
I'm wondering if it's something having to do with the SMTP send module I'm using. If I change the system-wide email address to a fake address (foo@foo.com for example), it won't send to the Mailman system. It seems to choke at that point, and the log is showing an error in the send. If I turn off the SMTP module, it doesn't send to Mailman at all. I can't find where to do the settings to have it just use the php mailer instead of the SMTP module, but I'll keep looking. Frustrating.

I encountered what looks to be this same problem several months ago and fixed it by hacking the SMTP module. I no longer have access to the system to provide a patch, but still have my notes:

--- Start SMTP module hacks ---
Reason: To allow the predefined "from" address that is sent to the module to be used.
Explanation: Currently the "from" address in the module is set to the system email from address. Modules such as mailinglist (and presumably author as sender) allow the user to define their own "from" address, which this module promptly overrides.

edit the file: mods/smtp_mail/smtp_mail.php
Find:
$mail->From = $PHORUM['system_email_from_address'];
$mail->Sender = $PHORUM['system_email_from_address'];
$mail->FromName = $PHORUM['system_email_from_name'];

Replace those three lines with:
if(!isset($data['from']) || empty($data['from'])) {
$mail->From = $PHORUM['system_email_from_address'];
$mail->Sender = $PHORUM['system_email_from_address'];
$mail->FromName = $PHORUM['system_email_from_name'];
} else {
$mail->From = $data['from'];
$mail->Sender = $data['from'];
$mail->FromName = $data['from'];
}

--- End SMTP module hacks ---

I hope this is still relevant and helps to solve your problem.

Re: Module: Author as Sender

Robert Angle — Thu, 15 Jul 2010 01:01:39 -0500

Quote
deadesq
I'm wondering if it's something having to do with the SMTP send module I'm using. If I change the system-wide email address to a fake address (foo@foo.com for example), it won't send to the Mailman system. It seems to choke at that point, and the log is showing an error in the send. If I turn off the SMTP module, it doesn't send to Mailman at all. I can't find where to do the settings to have it just use the php mailer instead of the SMTP module, but I'll keep looking. Frustrating.

Just a random thought (which usually means nothing)... could it be that it appears to not send to Mailman because foo@foo.com is not a real subscriber of the Mailman list?

I am not using the SMTP module, so I cannot comment further.

Re: Module: Author as Sender

deadesq — Thu, 15 Jul 2010 00:42:23 -0500

Okay--further information. I am not able to edit the php.ini on my server (shared hosting) so I remember now that's why I am using the SMTP module. I suspect that may be part of the problem. I will continue searching through the code, but if that rings a bell for you at all, I'll be very appreciative.

Re: Module: Author as Sender

deadesq — Thu, 15 Jul 2010 00:15:47 -0500

Thanks, Robert.

The emails are not globally set to "hide", and the test user I've set up is not set to hide either. The system is still sending from the global system email, though.

I'm wondering if it's something having to do with the SMTP send module I'm using. If I change the system-wide email address to a fake address (foo@foo.com for example), it won't send to the Mailman system. It seems to choke at that point, and the log is showing an error in the send. If I turn off the SMTP module, it doesn't send to Mailman at all. I can't find where to do the settings to have it just use the php mailer instead of the SMTP module, but I'll keep looking. Frustrating.

Re: Module: Author as Sender

Robert Angle — Thu, 15 Jul 2010 00:08:11 -0500

Quote
deadesq
I would like outgoing emails from phorum, which go to a Mailman list, to appear to be sent from the posting party, not from the system email default. I have tried "Author as Sender", and it doesn't appear to substitute the author of the post for the system email default when it sends to the Mailman list. I suspect I'm not setting up something right, but this is the last piece of the puzzle for me to move over to Phorum, other than trying to figure out how to import a phpBB2 board. That's another day. Thanks for any help.

Hello,

It is working for me, but please note the following.

Since my admin settings are to hide all email addresses, everything gets sent as from the system email address, OR the email address I specify for the FROM address in the mailing list module.

However, if my admin settings did not force the hiding of all email addresses, then the Author as Sender module would use the users email address that he has on file, UNLESS the user was opting to hide it himself in his Control Panel, in which case, the system email or the one specified in the mailing list module would be used.

Hope that is not too confusing, but in short, the users email address should be used UNLESS the user is choosing to hide it, or your system wide defaults are set to hide all addresses.

Re: Module: Author as Sender

deadesq — Wed, 14 Jul 2010 21:47:54 -0500

Sorry for the duplicate post--I posted this over at the Mailing List module thread, too. I'm not sure where is better, but in any case...

Hello, all. Thanks for the hard work you all put in. I've run through all the forums, and the code itself, and I'm still having trouble figuring out one minor issue. I would like outgoing emails from phorum, which go to a Mailman list, to appear to be sent from the posting party, not from the system email default. I have tried "Author as Sender", and it doesn't appear to substitute the author of the post for the system email default when it sends to the Mailman list. I suspect I'm not setting up something right, but this is the last piece of the puzzle for me to move over to Phorum, other than trying to figure out how to import a phpBB2 board. That's another day. Thanks for any help.

Re: Module: Author as Sender

Oliver Riesen-Mallmann — Tue, 22 Jun 2010 02:20:25 -0500

New version 1.4.2:

2010/06/22 version 1.4.2 Oliver Riesen (oliver@riesen.org)
- Bug fix: Remove extraneous stuff from email addresses to avoid double
  name part in some cases.

Re: Module: Author as Sender

Robert Angle — Wed, 02 Jun 2010 07:46:39 -0500

Tested and works great! Thanks :)

Re: Module: Author as Sender

Oliver Riesen-Mallmann — Wed, 02 Jun 2010 03:27:33 -0500

Hi Robert,

Quote
Robert Angle
In your Mailing List module, we can define the From address. But this Author as Sender overrides that.

Please try new version 1.4.1:

2010/06/02 version 1.4.1 Oliver Riesen (oliver@riesen.org)
- Making module compatible with Mailing List Module; thanks to Robert Angle.

Regards
Oliver

Re: Module: Author as Sender

Robert Angle — Tue, 01 Jun 2010 15:31:27 -0500

In your Mailing List module, we can define the From address. But this Author as Sender overrides that.

I want to define the from address in the Mailing List module, but still reference the Authors name.

Such as...

From: mailist_list_from_address@mysite.com

Right now I am getting...

From: system_email_address@mysite.com

How can I get this to work to display the members display name in the From field, but retain the From email address from the Mailing List Module?

Re: Module: Author as Sender

Oliver Riesen-Mallmann — Mon, 25 Aug 2008 07:44:42 -0500

New version 1.4.0:

2008/08/25 version 1.4.0 Oliver Riesen (oliver@riesen.org)
- Using now new mail API for encoding email address as per RFC 2045.
- Adding version check to sanity checks.
- Bug fix: Sanity check for module settings.

Re: Module: Author as Sender

Oliver Riesen-Mallmann — Mon, 25 Aug 2008 07:43:51 -0500

Hi Maurice,

Quote
Maurice Makaay
The mail address is in fact never passed on to the mail API.

Ah! I called your function with the complete string including the email address. So I tried once more, only encodng the name part. That is working. Thanks.

Regards
Oliver

Re: Module: Author as Sender

Maurice Makaay — Sat, 23 Aug 2008 12:42:59 -0500

Taking another look at the email_functions.php, I get the idea that you're not talking about a problem in the core code here. The core code only encodes the From: address' mail name and not the email address that is in there. The mail address is in fact never passed on to the mail API. Therefore, I kind of lost what you are targeting at right now.

Re: Module: Author as Sender

Maurice Makaay — Sat, 23 Aug 2008 05:21:05 -0500

It's even added multiple times in there. That is a strange thing, but for now I'd like to focus on the function, because I still don't understand where your extra spaces in the middle are coming from. Did you really check the function call itself where you wrote "but the new mail API returns..." ? Or is that mocked up data from the end results that you saw so far?

For the address part, I could probably strip off the part and not include that in the encoded data. I think that would keep the mailserver from getting confused.

Re: Module: Author as Sender

Oliver Riesen-Mallmann — Sat, 23 Aug 2008 02:20:04 -0500

Hi Maurice,

Quote
Maurice Makaay
In your string, I see extra spaces around the "=20" between the name and the address. That is one thing that is strange. The other thing is that your encoded string misses the closing "?=". That causes the string to not be recognized as QP by the mail program, showing the unchanged string eventually.

The complete source line from email header are:

Quote

From: =?utf-8?Q? "Oliver=20Riesen" =20 ,
?=@webbox1236.server-home.net

@webbox1236.server-home.net is added by our mail server because of the missing @ I think...

Regards
Oliver

Re: Module: Author as Sender

Maurice Makaay — Fri, 22 Aug 2008 16:19:59 -0500

I forgot the "@" as a safe character, causing this address to be encoded. I can add that one to the safe list, so this kind of address won't be quoted printable encoded.

However, if you have a name with some special character in it, it would still generate a wrong string for you. If I cut and paste the address string and feed it to my 5.2 mail api, it returns:

=?utf-8?Q?"Oliver=20Riesen"=20?=

In your string, I see extra spaces around the "=20" between the name and the address. That is one thing that is strange. The other thing is that your encoded string misses the closing "?=". That causes the string to not be recognized as QP by the mail program, showing the unchanged string eventually.

For now, I have no idea why it would be different in your case. If you cut and past from your above post and encode that, do you get the correct string or not?

Re: Module: Author as Sender

Oliver Riesen-Mallmann — Fri, 22 Aug 2008 15:46:00 -0500

Hi Maurice,

Quote
Maurice Makaay
Take a look at include/api/mail.php (in SVN repository or 5.2 stable snapshot), which will be included in Phorum versions 5.2.8 and up. This API script defines the function phorum_api_mail_encode_quotedprintable(), which can help you to include special characters in the mail headers.

I tried the new mail api without success.

If I call the encoding for example with the following value:

Quote

"Oliver Riesen"

my own function returns:

Quote

"Oliver Riesen"

but the new mail API returns:

Quote

=?utf-8?Q? "Oliver=20Riesen" =20

which is not shown correct in the email program.

Regards
Oliver

Re: Module: Author as Sender

Oliver Riesen-Mallmann — Fri, 02 May 2008 07:57:05 -0500

New version 1.3.0:

2008/05/02 version 1.3.0 Oliver Riesen (oliver@riesen.org)
- Bug fix: Use authors email-address instead of System Emails From Address
  didn't work for guests
- Email address is encoded as per RFC 2047 (Message Header Extensions for
  Non-ASCII Text, see [www.rfc-editor.org]).

Re: Module: Author as Sender

Maurice Makaay — Mon, 28 Apr 2008 11:56:44 -0500

Quote

Since the display name for an email address should contain only ASCII-characters any special character will be replaced by a question mark. See RFC 2822. German umlauts are dissolved to there corresponding two characters.

Take a look at include/api/mail.php (in SVN repository or 5.2 stable snapshot), which will be included in Phorum versions 5.2.8 and up. This API script defines the function phorum_api_mail_encode_quotedprintable(), which can help you to include special characters in the mail headers. Maybe it's a good idea to upgrade your module when 5.2.8 is released or prepare your module to use the mail API code if the API file is available. That would make the module usable for admins that have a Phorum in other languages for which you cannot do ä -> ae like conversions.

Module: Author as Sender

Oliver Riesen-Mallmann — Mon, 28 Apr 2008 11:06:54 -0500

Module: Author as Sender
Version: 1.4.4
Author: Oliver Riesen <oliver@riesen.org>

Uses the authors display name and email address as sender in the FROM-clause for outgoing emails (user and moderator notifications and private mail).

In case of reporting a post the module uses the display name of the reporter instead of the original author.

For user notifications and private mail the authors email address is only used if there exists an email address and if the author allow to show the email address to other users.

Moderator notifications contains the authors email address even if the author doesn't allow to show the email address to other users.

Email address is encoded as per RFC 2045 (Message Header Extensions for Non-ASCII Text, see [www.rfc-editor.org]).

Tested on version 5.2.15a

License:

Free to use, modify, or redistribute this code so long as I am given credit for the original development somewhere. This code comes with absolutely no warranty.

Requirements:

Minimum Phorum version: 5.2.8.

Installation:

1. Unpack the archive.

2. Move the directory "author_as_sender" to the directory "mods" within your Phorum installation. Don't change the directory name!

3. Login as administrator in Phorum's administrative interface and go to the "Modules" section.

4. Enable the module "Author as Sender".

5. Go to the module settings, change and save the options.

Module settings:

Settings for user notifications and private mail

Use authors email-address instead of System Emails From Address

If this option is marked and if the users email address is public the module will use the users email address. In other cases the primal email address is used which is by default "System Emails From Address" from "Global Settings". Other modules like the Mailing List Module can specify a differing email address.

The default value is "checked".

Settings for moderator notifications

Use authors email-address instead of System Emails From Address

If this option is marked the module will use the users email address. In other cases the primal email address is used which is by default "System Emails From Address" from "Global Settings". Other modules like the Mailing List Module can specify a differing email address.

The default value is "checked".

Language support:

This module doesn't contain any language text.

Sanity Checks:

If you have problems with this module login as administrator in Phorum's administrative interface and go to the "System Sanity Checks" section. Check for warnings or errors for the Author as Sender Module.

The following check is performed:

- Phorum version is 5.2.8 or greater?
- Does custom profile field exists?

Changelog:

2008/04/28 version 1.2.0 Oliver Riesen (oliver@riesen.org)
- Rewrite for Phorum 5.2.

2008/05/02 version 1.3.0 Oliver Riesen (oliver@riesen.org)
- Bug fix: Use authors email-address instead of System Emails From Address didn't work for guests.
- Email address is encoded as per RFC 2047 (Message Header Extensions for Non-ASCII).

2008/08/25 version 1.4.0 Oliver Riesen (oliver@riesen.org)
- Using now new mail API for encoding email address as per RFC 2045.
- Adding version check to sanity checks.
- Bug fix: Sanity check for module settings.

2010/06/02 version 1.4.1 Oliver Riesen (oliver@riesen.org)
- Making module compatible with Mailing List Module; thanks to Robert Angle.

2010/06/22 version 1.4.2 Oliver Riesen (oliver@riesen.org)
- Bug fix: Remove extraneous stuff from email addresses to avoid double name part in some cases.

2010/11/24 version 1.4.3 Oliver Riesen (oliver@riesen.org)
- Using now the display name of the reporting user in case of reporting a post instead of the original author; thanks to Robert Angle.

2015/09/08 version 1.4.4 Oliver Riesen (oliver@riesen.org)
- Performance improvement.