Module: Birthdays

Re: Module: Birthdays

slashbin — Tue, 21 Jun 2016 00:05:54 -0500

The module has an issue with leap years. I suggest to change the test
[code="php"]
if($ubirthday["yday"] >= $jetzt["yday"])
[/code]
by
[code="php"]
if (($ubirthday["mon"] > $jetzt["mon"]) || ($ubirthday["mon"] == $jetzt["mon"] && ($ubirthday["day"] >= $jetzt["day"])))
[/code]
in the file birthdays.php

Re: Module: Birthdays

slashbin — Fri, 26 Dec 2014 11:23:51 -0600

It seems to me that there is a small bug in this module. When the birthday is at the beginning of the year, but the current date is towards the end of the previous year, the age is not properly computed. This is because only the difference between the current year and the birth year is used to compute the future age. On my system, I have corrected this by adding the lines

if(($ubirthday["mon"] == 1) && ($jetzt["mon"] > 1)) {
$user_age++;
}

after the 'else' of the condition 'if($daysTillBirthday == 0)'

Re: Module: Birthdays

Ryan — Sat, 01 Aug 2009 20:30:16 -0500

I'm guessing this module is no longer compatible with the latest version of Phorum. Does anyone know how I could do something like this, but just have the birthday to edit in the ControlCenter, and have the age of said birthday appear in the profile?

Re: Module: Birthdays

tsyuha — Fri, 06 Mar 2009 05:08:28 -0600

Quote
Jan-Willem
However, the mod is not working very well for me. If I try to set my birthday it won't remember the date. It allways says december 31 1969, whatever I try. Any suggestions?

Good day!
I have the same problem and after reading this post I don't understood how can I correct this... As I understood, I have to rewrite this module at all for solving this problem. May be I mistake?
Please help me...
With best regards.

Re: Module: Birthdays

Brian Moon — Wed, 11 Feb 2009 20:45:38 -0600

FYI, I just diagnosed a Phorum using this module. It was causing the MySQL server to OOM and causing the server to hit its PHP memory limit. I have not looked deep into the code yet, but it appears this module does not handle thousands of users very well.

Re: Module: Birthdays

Joe Curia — Tue, 11 Nov 2008 12:10:31 -0600

I have uploaded version 1.0.5 of this module with the following changes:

- Fixed a bug in the tpl_cc_usersettings hook (needed to return $profile data)

- Modified to use display_name rather than simply username

- Added the Dutch Informal (from Jan-Willem) and Turkish (from scabboy) language files

Re: Module: Birthdays

ImpalaLove — Tue, 21 Oct 2008 21:29:35 -0500

Hi, this is a great module, works perfectly. However I would like to include Birthdays on the New User Registration page, register.php. Is there an easy way to do this or is it even possible? My PHP skills are a little rusty and I really only know PHP 4 - haven't had time yet to study up on PHP 5, so I'd rather not go hacking around without some guidance. Thanks for any help you can give.

Re: Module: Birthdays

Joe Curia — Wed, 24 Sep 2008 19:19:29 -0500

I just started using this mod and wanted to say thanks for your work on it, it looks great!

I do have one suggestion though as I have users' real names showing on my site and found that those weren't used for this mod. If you change line 291 to read $user['display_name'] rather than $user['username'], this will allow the default to be shown (whether it is user or real name).

Anyways, thanks again for all your hard work.

Re: Module: Birthdays

Sunbringer — Sun, 27 Apr 2008 04:39:59 -0500

After my little changes above your posts it is working well.

Re: Module: Birthdays

John Shallo — Sat, 26 Apr 2008 19:31:12 -0500

Is anyone using this Mod? Is it stable and working well?

Re: Module: Birthdays

Sunbringer — Mon, 07 Apr 2008 11:42:22 -0500

Quote
Sunbringer
Somehow the Birthdays today are not shown. The Birthdays in die Future are working fine, but not the actual birthdays today.

Any hints for that problem?

OK, problem solved: the mod didn't recognise that 2008 is a leap year so this little hack shouldt help out:

change

322    if($ubirthday["yday"] >= $jetzt["yday"])
323        $nextBirthday = mktime(0,0,1,$ubirthday["mon"],$ubirthday["mday"],$jetzt["year"]);
324    else
325        $nextBirthday = mktime(0,0,1,$ubirthday["mon"],$ubirthday["mday"],$jetzt["year"]+1);

322    if((date("L", mktime(0,0,1,$jetzt["mon"],$jetzt["mday"],$jetzt["year"])) == 1) || ($ubirthday["yday"] >= $jetzt["yday"])) 
323        $nextBirthday = mktime(0,0,1,$ubirthday["mon"],$ubirthday["mday"],$jetzt["year"]);
324    else
325        $nextBirthday = mktime(0,0,1,$ubirthday["mon"],$ubirthday["mday"],$jetzt["year"]+1);

greetings
Sun

Re: Module: Birthdays

Adornit — Sun, 06 Apr 2008 08:16:32 -0500

Can you please give me a hint, how to change the fontsize for this module? Changes in cc_usersettings wont show any effect in forum.

Re: Module: Birthdays

Sunbringer — Wed, 02 Apr 2008 07:20:50 -0500

Somehow the Birthdays today are not shown. The Birthdays in die Future are working fine, but not the actual birthdays today.

Any hints for that problem?

Re: Module: Birthdays

Jan-Willem Stekelenburg — Wed, 13 Feb 2008 17:25:38 -0600

So now you know I'm from before 31-12-1969

Re: Module: Birthdays

scabboy — Wed, 13 Feb 2008 16:17:11 -0600

Thanks for new language strings. here is turkish language file.

Re: Module: Birthdays

Steve H — Wed, 13 Feb 2008 14:43:42 -0600

I have set birthdays prior to 1969 with this module, and it worked fine. While it certainly sounds like Jan-Willem is having a problem with the UNIX date, it isn't a universal problem. Perhaps something different in his installation?

At any rate, once I rewrite the module to store YYYY and MMDD the UNIX timestamp issue will go away.

Re: Module: Birthdays

Maurice Makaay — Wed, 13 Feb 2008 02:19:20 -0600

I looked at the code and I see that the getdate() PHP function is used for working with the date. That is problematic here, since UNIX dates (a.k.a. Epoch) are defined as the number of seconds since Januari 1st 1970. Therefore, you can not use dates before that time when using the standard UNIX date processors.

For my own projects, I nowadays use SQL queries for advanced date processing. Most SQL server systems (and MySQL as well) have well written date functions in their library. Of course doing so would make this module MySQL targeted, unless care would be taken to allow multiple db layers (which is not too hard too do; check the spam hurdles module for example).

Re: Module: Birthdays

Jan-Willem Stekelenburg — Tue, 12 Feb 2008 18:44:28 -0600

Here's a Dutch language file.

However, the mod is not working very well for me. If I try to set my birthday it won't remember the date. It allways says december 31 1969, whatever I try. Any suggestions?

Re: Module: Birthdays

Maurice Makaay — Tue, 12 Feb 2008 13:23:40 -0600

Such array would not be accessible from the search function. There are quite some options for working with custom profile fields, but serialized data isn't easily accessible and for sure not by SQL. Therefore if you want data to be searchable, then you can't use array data (as you already found out).

An option would be to use more than one field. Of course I was stupid with YYYYMMDD :-) So instead of one field, you could split it in a YYYY field and a MMDD field. An extreme option would be to create a table for the birthdays storage. For some applications, custom tables might even be needed, because custom fields just don't deliver the goods. But for this typical application, I think that working with custom fields should be sufficient.

Re: Module: Birthdays

Steve H — Tue, 12 Feb 2008 11:00:40 -0600

Quote
mmakaay
Quote
stevehealy
Also the user search now only loads those users with birthdays defined. This should improve performance, at least until all your users add their birthdays. ;)

If you store the birthday as "YYYYMMDD" in the field, then you could use "<" and ">" operators to select only a range from the birthdays. There is no need to pull in all configured birthdays. That should make the script scale just fine, unless you get thousands of user birthdays on a single day ;)

Actually, that won't work because the YYYY will be all over the place. (depending on the age of users) That's why I said earlier that I need to ignore the year when searching.

On top of that, the birthday is stored in an array which doesn't seem to be accessible from the phorum_api_user_search_custom_profile_field. If it is, I need help with the syntax.

My custom profile is "mod_birthdays", which is an array containing "birthday" and "age".

Re: Module: Birthdays

Maurice Makaay — Tue, 12 Feb 2008 04:01:04 -0600

Quote
stevehealy
Also the user search now only loads those users with birthdays defined. This should improve performance, at least until all your users add their birthdays. ;)

If you store the birthday as "YYYYMMDD" in the field, then you could use "<" and ">" operators to select only a range from the birthdays. There is no need to pull in all configured birthdays. That should make the script scale just fine, unless you get thousands of user birthdays on a single day ;)

Re: Module: Birthdays

M@AATW — Tue, 12 Feb 2008 03:45:06 -0600

Thanks for your hard work on this Steve, this is working for me now! Yay!

Re: Module: Birthdays

Steve H — Mon, 11 Feb 2008 17:52:13 -0600

New version uploaded, with some new language strings.

Also the user search now only loads those users with birthdays defined. This should improve performance, at least until all your users add their birthdays. ;) I think it still needs some work, but it may require another overhaul of the code.

Re: Module: Birthdays

Maurice Makaay — Mon, 11 Feb 2008 16:17:52 -0600

Likek thomas pointed out, it is possible to do your own rewriting on the strings. Till now, the main language file and some modules use %variable% as the variable name. So if you want to use this type of rewriting, then use %days% to be compliant with the other code.

For plural words it is fun how some languages might even have different wordings for one, two or more than two. So in my latest module code, I try to leave using different strings open for the language file writer. Here's a slightly generalized excerpt from the onlineusers module file that implements this:

            $lang = $PHORUM['DATA']['LANG']['MOD_.....'];
            $count = ...some code to get a count ...;
            $str = isset($lang["SomeLanguageKey$count"])
                 ? $lang["SomeLanguageKey$count"]
                 : $lang['SomeLanguageKey'];
            $str = str_replace('%count%', $count, $str);

Using this, the language file could define the strings:

$PHORUM['DATA']['LANG']['MOD_.....'] = array(
    "SomeLanguageKey0" => "None at all!",
    "SomeLanguageKey1" => "One single lonely.",
    "SomeLanguageKey2" => "A duo!",
    "SomeLanguagekey"  => "There are %count% of them."
);

Re: Module: Birthdays

Steve H — Mon, 11 Feb 2008 14:48:09 -0600

More on phorum_api_user_search_custom_profile_field()...

What is the best way to combine this with phorum_api_user_search() so that I can search on both regular user fields (like "active") and custom profile fields?

Also, I see that you're using an unspecified operator (%):

$user_ids = phorum_api_user_search_custom_profile_field(
    $field[0], '', '%', TRUE
);

Quote

Valid operators are "=", "!=", "<>", "<", ">", ">=" and "<=", "*". The "*" operator is for executing a "LIKE '%value%'" matching query.

Is % equivalent to *?

edit...
upon further study.. it is also giving an undefined offset warning, thus it should be:

        $field['id'], '', '*', TRUE

Re: Module: Birthdays

Steve H — Mon, 11 Feb 2008 14:09:16 -0600

Quote
mmakaay
You can use phorum_api_user_search_custom_profile_field() for that.
Here a excerpt from the Google Maps module which does a lookup on a custom profile field:

// Collect all users which have a "mod_google_maps" custom user profile field.
require_once('./include/api/custom_profile_fields.php');
$field = phorum_api_custom_profile_field_byname('mod_google_maps');
if (empty($field)) trigger_error(
    'No custom profile field named "mod_google_maps" available',
    E_USER_ERROR
);
$user_ids = phorum_api_user_search_custom_profile_field(
    $field[0], '', '%', TRUE
);

I've been playing with this without success. My problem is that the custom field I need to search on is in an array:

mod_birthdays["birthday"]

I'm not sure if this api will support that, and if it will, what the proper syntax is?

Beyond that, I suspect that there is no good way to search for current birthdays as timestamps with simple pattern matching. I need to store them as separate fields for month, day and year so I can ignore the year when searching. (or perhaps store an additional "fake" timestamp with the year set to an arbitrary year strictly for searching)

Re: Module: Birthdays

pat — Mon, 11 Feb 2008 13:59:41 -0600

regular:

"BlockContentNone" => "No birthdays in the next",
"Days" => "days",

[No birthdays in the next] $30 [days]

___________________________________

turkish:

"BlockContentNone" => "next ",
"Days" => "days in no birthdays",

[next] $30 [days in no birthdays]

Re: Module: Birthdays

scabboy — Mon, 11 Feb 2008 13:25:56 -0600

It shold be like that

[next 30 days] [in] [no birthdays]

according to turkish. Also

I hope that I could explain :)

Re: Module: Birthdays

Thomas Seifert — Mon, 11 Feb 2008 12:24:58 -0600

well, sure. you just need to run your own replacements on the language strings before using them ;).
something like
$PHORUM['DATA']['LANG']['MyLanguageString'] = str_replace("[#]",$myvariablewiththatnumber,$PHORUM['DATA']['LANG']['MyLanguageString']);

Re: Module: Birthdays

Steve H — Mon, 11 Feb 2008 12:11:17 -0600

This reminds me of a question for the experts which I had while working on the language file:

Is it possible to put a variable within a language string?

It would simplify this process significantly if I could write language strings like

    "BlockContentNone"    => "No birthdays in the next [#] days",

(or something like that)