Module: Topic Poll

Re: Module: Topic Poll

zenon — Thu, 26 Sep 2024 06:42:48 -0500

Quote
Oliver Riesen-Mallmann

since there are few other passages with "each" in the source code and perhaps also in other modules, I think we should use a funtion to replace "each()" like in polyfill-each: [github.com]

You mean in the source code of phorum itself, I assume. Because there is only one instance of each() in topic_poll.

Anyway, I have a somewhat unusual setup, with phorum on a distributed glusterfs filesystem on three machines. So each of these three machines sees one and the same filesystem and files on it. But machine A runs almalinux 8.x with PHP 7.4 and machines B and C run almalinux 9.x with PHP 8.3. All three run a webserver. This means that I can switch back and fro between the same (5.2.23) phorum installation on PHP 7.4 or 8.3 just by toggling /etc/hosts on my workstation.

So I added 'require_once("./include/polyfill-each.php");' in common.php. polyfill-each does nothing if each() already exists, so 7.4 still works fine. 8.3 however breaks elsewhere with

PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported in /path/to/phorum/include/upload_functions.php on line 107

That raises two questions:

Will phorum be updated for PHP 8.x?
Should we move this discussion to the main 5.2 support forum?

Cheers

Re: Module: Topic Poll

Oliver Riesen-Mallmann — Tue, 24 Sep 2024 08:11:17 -0500

Hi Zenon,

since there are few other passages with "each" in the source code and perhaps also in other modules, I think we should use a funtion to replace "each()" like in polyfill-each: [github.com]

Copy the content of polyfill-each.php to common.php after line 72.

Regards
Oliver

Re: Module: Topic Poll

Oliver Riesen-Mallmann — Tue, 24 Sep 2024 03:05:12 -0500

Hi Zenon,

I try to publish a new version of the module.

Regards
Oliver

Re: Module: Topic Poll

zenon — Tue, 24 Sep 2024 02:40:43 -0500

Quote
Scott Finegan

You can try the following. Pretty much do it yourself.

Thanks, but if I fix my own the module will still be broken. And it is an active and useful module. And it's only this one line of code that breaks it. Everywhere else foreach() is used, so I suspect that this one instance of each() is purely accidental. So from every point of view it would be much better to have it fixed at the source.

Re: Module: Topic Poll

Scott Finegan — Mon, 23 Sep 2024 21:36:18 -0500

You can try the following. Pretty much do it yourself.

[github.com]

[stackoverflow.com]

[www.google.com]

Re: Module: Topic Poll

zenon — Mon, 23 Sep 2024 09:06:56 -0500

(Copying this here from the wrong place)

Hi

Moving from PHP 7.4 to 8.3,

[23-Sep-2024 12:31:10 UTC] PHP Fatal error:  Uncaught Error: Call to undefined function each() in /path/to/phorum/mods/topic_poll/topic_poll.php:389
Stack trace:
#0 /path/to/phorum/common.php(1909): phorum_mod_topic_poll_read()
#1 /path/to/phorum/read.php(754): phorum_hook()
#2 {main}
  thrown in /path/to/phorum/mods/topic_poll/topic_poll.php on line 389

The offending line is
[code="php"]
list ($message_id, $message) = each($messages);
[/code]
and the cause is that each() was deprecated in PHP 7.2 and was removed in 8.0.

I just checked 1.0.22 and it still uses each().

Re: Module: Topic Poll

Oliver Riesen-Mallmann — Thu, 01 Sep 2016 08:33:37 -0500

New Version:

2016-09-01 v1.0.22 Oliver Riesen-Mallmann 
    - Made XHTML 1.0 Transitional compliant.

Re: Module: Topic Poll

Oliver Riesen-Mallmann — Fri, 22 Apr 2016 00:59:58 -0500

Quote
pierrexuso
Poll-Software without multiple choice option?

Feel free to add it and publish a new version of this module... ;)

Regards
Oliver

Re: Module: Topic Poll

pierrexuso — Thu, 21 Apr 2016 09:48:57 -0500

Poll-Software without multiple choice option?

Re: Module: Topic Poll

Oliver Riesen-Mallmann — Fri, 18 Sep 2015 07:49:01 -0500

New version 1.0.21:

2015-09-18 v1.0.21 Oliver Riesen 

    - Fixed various warnings and errors from the W3C validator.

    - Fixed undefined index warning when using together with the Post Preview
      Module, see:
      [www.phorum.org]

    - Performance improvements.

    - Added simplified chinese language file. Thanks to phorum.org user
      laiweiwei.

Re: Module: Topic Poll

TTV — Mon, 08 Sep 2014 13:09:24 -0500

Quote
Scott Finegan
For the regular forum: Make available the formal dutch.php for selection.
The topic poll comes with a formal dutch.php language file.

If formal Dutch is used, the topic poll uses formal Dutch on its buttons, etc. in my test.

Make a copy of the dutch.php, rename it to dutch_informal.php and test yourself.

Dit not work for some reason, but i decided to delete the informal file, and strangely enough it's working.

Thank you Scott!

Re: Module: Topic Poll

Scott Finegan — Sat, 06 Sep 2014 09:15:35 -0500

For the regular forum: Make available the formal dutch.php for selection.
The topic poll comes with a formal dutch.php language file.

If formal Dutch is used, the topic poll uses formal Dutch on its buttons, etc. in my test.

Make a copy of the dutch.php, rename it to dutch_informal.php and test yourself.

Re: Module: Topic Poll

TTV — Sat, 06 Sep 2014 08:32:22 -0500

Quote
Scott Finegan
Both must be formal, or you need to create an informal for the module.

You mean i should change the filename?? Or simply delete the informal file?

Re: Module: Topic Poll

Scott Finegan — Sat, 06 Sep 2014 08:09:53 -0500

Both must be formal, or you need to create an informal for the module.

Re: Module: Topic Poll

TTV — Fri, 05 Sep 2014 17:05:47 -0500

Quote
Scott Finegan
They are both formal Dutch?

No one is formal Dutch and the other informal...

Re: Module: Topic Poll

Scott Finegan — Fri, 05 Sep 2014 09:47:10 -0500

They are both formal Dutch?

Re: Module: Topic Poll

TTV — Fri, 05 Sep 2014 09:14:25 -0500

Quote
Scott Finegan
The language file must match.

If phorum/include/lang/dutch.php is used the poll seems to work (phorum5.3 dev)

If phorum/include/lang/dutch_informal.php is used the poll remains in english

Yeah tried that yesterday but without any luck, i am going to retry it right now to see what it does.....

Update:

Updated the language file... Still no luck...

Isn't there a way to set a default language in the module itself? Maybe change a line of code somewhere?

Re: Module: Topic Poll

Scott Finegan — Fri, 05 Sep 2014 08:57:42 -0500

The language file must match.

If phorum/include/lang/dutch.php is used the poll seems to work (phorum5.3 dev)

If phorum/include/lang/dutch_informal.php is used the poll remains in english

Re: Module: Topic Poll

TTV — Fri, 05 Sep 2014 04:08:09 -0500

Quote
Scott Finegan
Are you using the Emerald template when you encounter this issue?

edit>> The Classic template would need a matching template in the poll module.

I am using emerald-alt as my standard template, next to the normal emerald, classic and redbirds templates. The module stays in English in all of them..... And yes Dutch is included in the language files of the module. There are currently two Dutch language files for phorum, both of them do not work with the Topic Poll module on my site.

What i have done so far:

Cleaned out cache/cookies of browser
Purge cache
Ran sanity checks
Ran Database integrity
Shut the module off/on

Did all of the above multiple times...

And asked this question...

Would it make any difference if would uninstall and reinstall the module?

Re: Module: Topic Poll

Thomas Seifert — Fri, 05 Sep 2014 00:34:20 -0500

and a matching language as it seems to be about the language.

Re: Module: Topic Poll

Scott Finegan — Thu, 04 Sep 2014 21:26:03 -0500

Are you using the Emerald template when you encounter this issue?

edit>> The Classic template would need a matching template in the poll module.

Re: Module: Topic Poll

TTV — Thu, 04 Sep 2014 10:02:12 -0500

Module language is not changing to Dutch on my site, i have tried several things but nothing seems to be working, what can i do to set it to show in Dutch instead of English?

I am using Nederlands informeel on my site...

Re: Module: Topic Poll

Oliver Riesen-Mallmann — Thu, 06 Jun 2013 10:40:53 -0500

Hi Maurice,

I get some PHP Notice from the Topic Poll Module when using also Post Preview Module:

PHP Notice:  Undefined index: READ in /var/www/.../phorum-5.2.19/mods/topic_poll/topic_poll.php
on line 711, referer: [forum.langzeittest.de]

Regards
Oliver

Re: Module: Topic Poll

Maurice Makaay — Sat, 02 Feb 2013 11:10:56 -0600

No, that has not been implemented. It really is "topic poll", so a poll that is linked to a single topic / thread.

Re: Module: Topic Poll

TheQ — Sat, 02 Feb 2013 04:56:25 -0600

Thanks for very neat module, Maurice. I have one question/request tho: Is it possible to have multiple polls in same thread/post? Basically, I would like to have multiple questions with their own answers in the same thread. This would help our forum members a lot since currently some "voting" that we do is bit taxing.

Thanks!

Re: Module: Topic Poll

pat — Mon, 07 Jan 2013 14:10:55 -0600

Quote
autoven
in the poll editor, can i have more than 2 fields by default? Where can i modify the code?

Modify topic_poll.php to:

[code="php"]
// Initialize a new poll.
$message["meta"]["mod_topic_poll"] = array (
"question" => "",
"answers" => array( 0 => "", 1 => "", 2 => "" ),
"votes" => array(),
"total_votes" => 0,
"votingtime" => 0, // in days, 0 for unlimited
"permission" => "user",
"active" => 1,
"cache_id" => 0,
);
[/code]

Re: Module: Topic Poll

autoven — Mon, 07 Jan 2013 06:03:24 -0600

thanks...it works for me.

Re: Module: Topic Poll

Maurice Makaay — Sun, 06 Jan 2013 10:47:23 -0600

In topic_poll.php, an empty poll is initialized like this:
[code=php]
// Initialize a new poll.
$message["meta"]["mod_topic_poll"] = array (
"question" => "",
"answers" => array( 0 => "", 1 => "" ),
"votes" => array(),
"total_votes" => 0,
"votingtime" => 0, // in days, 0 for unlimited
"permission" => "user",
"active" => 1,
"cache_id" => 0,
);
[/code]

By extending the "answers" array, you can add as many standard answers as you wish.

Re: Module: Topic Poll

autoven — Sat, 05 Jan 2013 18:51:44 -0600

in the poll editor, can i have more than 2 fields by default? Where can i modify the code?

Re: Module: Topic Poll

Thomas Seifert — Sat, 22 Dec 2012 13:49:23 -0600

eh, no, there is no functionality built in for that.
Essentially this means to prepare some base content for each post in a forum.
Guess that would make a different module.