New Count module

Re: New Count module

Maurice Makaay — Wed, 02 Jan 2008 04:24:46 -0600

The "emerald" template does not use {MESSAGES->new} as a string in the template. It only uses it to change the icon in front of the thread subjects. It is however possible to add some code to your template to take care of this yourself. I did try to build a feature that automatically adds the info, but that was not possible. It was possible to add "(1 new)" to the subject, but it wasn't clickable that way, because the link would end up embedded inside the full subject line link.

I did some updates to the module to clean up some code and to extend the documentation in the README file to show how to edit "emerald" for displaying new message counts on the list page. I uploaded it as version 1.13 in the Phorum 5.2 modules forum. Here's the excerpt from the updated documentation that applies to your case:

  The default Phorum 5.1 template will already show the amount of new
  messages for threads on the list page if you have this module enabled.
  The default Phorum 5.2 template ("emerald") however, will not do so.
  In that template, the new message information {MESSAGES->new} is just
  used to change the icon in front of threads that contain new messages.
  To display the number of new messages for threads in that template,
  you will have to edit the list.tpl template.

  You can use these template variables inside the {LOOP MESSAGES} loop:

    {MESSAGES->new}       A formatted string "[X] new" that is set if there
                          are new messages for the thread.
    {MESSAGES->new_count} The number of new messages for the thread.

  You can for example use the following code somewhere after the
  {MESSAGES->subject} in list.tpl to match the old 5.1 behavior:

    {IF MESSAGES->new}
      
        {MESSAGES->new}
      
    {/IF}

Re: New Count module

M@AATW — Wed, 02 Jan 2008 00:50:19 -0600

Does this display the count next to messages in 5.2? i.e

'2 new' or '5 new' next to each message in list.tpl ?

I can't get it to work in 5.2.

It works fine for a total on index.tpl.

Any ideas?

Re: New message count for future version 5.2

Maurice Makaay — Fri, 11 May 2007 05:22:30 -0500

There's nothing wrong with nitpicking ;-)
I've got this code in my latest version of the new_count module already:

    // If we have no forums at all, then the new count will not be set.
    if (!isset($PHORUM["DATA"]["MOD_NEW_COUNT"])) return;

Ah, I'm at 1.12 in my module repository, but I uploaded only up to 1.10. Probably because I didn't thinkt the bugs were that bad. My changelogs for the last two versions:

1.11 Fixed PHP warning that was shown in case no forums were defined at all.

1.12 Fixed another couple of small undefined index warnings.

I uploaded the latest release in this message.

Re: New message count for future version 5.2

Mathias — Fri, 11 May 2007 03:40:58 -0500

Found a small bug in the, when you go to index.php and there is no forums to display (e.g. they're all private and your account doesn't have access to them) you get a PHP error:
Notice: Undefined index: MOD_NEW_COUNT in C:\www\phorum\mods\new_count\new_count.php on line 152
This is because the index hook is never reached if no forums are found, thus the data isn't setup properly.

This is easily fixed by sticking:
if(!count($PHORUM["DATA"]["FORUMS"])) return;
somewhere early in mod_new_count_after_header().

Happens during quite rare/silly circumstances, but still. :)

Re: New message count for future version 5.2

Maurice Makaay — Thu, 24 Aug 2006 08:00:32 -0500

Here's a followup release for version 1.9.2. This version can be used safely with both the stable Phorum 5.1 release and the current Phorum 5.2 development tree.

1.10 PHP warnings were shown in case there was a "thread moved" notification
in the forum. These notifications are now skipped when counting new
messages for the message list.

Modified the module, so now it will work for both Phorum 5.1 and 5.2.

Removed the need for the common hook in the code (it was used for
setting up some data to prevent undefined index warnings later on,
but this could be handled more gracefully).

Note to Oliver: If you extend on a module, please leave the Changelog and README files intact. Your 1.9.2 package did not contain these files anymore. Especially the README is useful for this module, because it contains installation and customization information. Thanks!

Edit: attachments deleted, because a new version was released.

Re: New message count for future version 5.2

Chanh Ong — Sun, 11 Jun 2006 22:42:01 -0500

New count module fixes!

I tried to validate my site with the html validation service and found out there were a few error in the new_count.php

Missing ";" in new_count.php
line 128: ' ' .
$PHORUM["DATA"]["NEW_MESSAGES"] .
' ' .
$PHORUM["DATA"]["LANG"]["new_count_total_new_threads"] .
line 132: ' ' .

Re: New message count for future version 5.2

Oliver Riesen-Mallmann — Fri, 21 Apr 2006 10:03:49 -0500

Hi,

here is a new version which will work with the actual snapshot and with the future version 5.2 of Phorum. ATTENTION: this module version will not work with Phorum 5.1.x!

Message and thread count values are now formatted by the Phorum core so this module is calculating a wrong total because of the thousands separator.

The new version correct this error and format also the total with the separators given in the language file.

HTML-error reported by Chanh Ong is fixed also.

Bye
Oliver

[Attachement removed. New version available]

Re: New message count next to "new" in list view

Panu — Tue, 24 Jan 2006 16:03:04 -0600

Great work B&M. The once hacky module is starting to look like a real polished piece of software :)

Only downside is the extra db hit with the latest version. (maybe it is as efficient as the previous way of calculating a little bit less tho)

Re: New message count next to "new" in list view

Maurice Makaay — Sun, 22 Jan 2006 14:54:36 -0600

I added a couple of features too and restructured the information for the module a bit. Here's the changelog and the 1.9 version of the module.

    Added a settings screen so now users of this module can choose to
    either show the totals automatically in the header or hack the
    templates to exactly show it where they like it to be.

    Another setting has been added to configure if the totals for
    the index and list pages should be displayed in case no new
    messages are available. Hiding was the default behaviour in the
    previous versions.

    Displaying of forum totals for the list view now also works when in
    threaded view.

    Migrated information about the module from the module code
    to a README and Changelog file.

    Added a new localization option, so languages that use multiple
    plural words can set them in the language strings (you can now
    define the default new_count_single and new_count_multiple, but
    also new_count_2, new_count_3, etc.).

    Added a Dutch translation for the module.

While testing this module, I did find another issue:
Announcements + replies to announcements are counted as a new message for every forum in the folder the announcement is in. So if you have 5 forums and post a new announcement, the new message count will be 5. The same way like Phorum will add a new flag to each forum in this case. The new flag isn't a real problem I think, but it would be good if the new count would at least be 1. This is probably something that has to be fixed in the Phorum db-layers.

Edit: attachments deleted, because a new version was released.

Re: New message count next to "new" in list view

Thomas Seifert — Thu, 15 Dec 2005 03:40:46 -0600

blm, do you have a screenshot of how this looks like?

Re: New message count next to "new" in list view

Brian Moon — Wed, 14 Dec 2005 23:00:52 -0600

I have made some changes to this code. It addresses a couple of issues that Panu had. In addition, it add a total new thread count and adds the total posts and threads to the index.php page as well.

Re: New message count next to "new" in list view

Panu — Thu, 12 May 2005 17:29:40 -0500

Added total new messages in all threads by CBiLL's request.

Localisation of it kind of sucks, but modules lang-string wasn't visible to list-template for some reason so I had to parse the whole sucker in the module,

Works for me, but if you have read all messages in this thread, you can see there has been some weird errors...

Re: New message count next to "new" in list view

regdos.com — Tue, 10 May 2005 13:07:41 -0500

tkt Wrote:
> Two possible solutions (with polish translation
> files) in attachments
> (The 1st looks, maybe, more universal, but when
> I've written it I saw, that something like the 2nd
> one would be better)

Wersja 1 za cholere nie dzia³a po polsku.

Ale w sumie ³adnie zrobione gratuluje

Re: New message count next to "new" in list view

M@AATW — Thu, 05 May 2005 09:41:51 -0500

I keep getting these errors when I'm using one template:

Warning: array_diff(): Argument #1 is not an array in /home/wtower/public_html/phorum/mods/new_count/new_count.php on line 39

Warning: Invalid argument supplied for foreach() in /home/wtower/public_html/phorum/mods/new_count/new_count.php on line 44

Re: New message count next to "new" in list view

tkt — Sat, 23 Apr 2005 12:50:11 -0500

I've tried to make polish translation of the language file, but it isn't possible yet.
The problem is that in polish there are diferent word for 2, 3 or 4 new items, and different for 5 and more, like following:

1 nowy
2,3,4 (also 22,23,24,32,33,34 etc.) nowe
5 nowych

Two possible solutions (with polish translation files) in attachments
(The 1st looks, maybe, more universal, but when I've written it I saw, that something like the 2nd one would be better)

This hanges would be usefull while making other slavonic-languages translations.

ps. If you want to see it working, look at [puszkin.org]

Re: New message count next to "new" in list view

Thomas Seifert — Mon, 14 Feb 2005 03:23:39 -0600

we will never add something like that to the core-distribution.
even if its an option or you only add "new" (which doesn't make much of a difference) it will make the index-page slow as hell with firing dozens of queries just for listing how many new messages are in a folder and all subsequent forums.

Re: New message count next to "new" in list view

nikhil — Sun, 13 Feb 2005 18:02:11 -0600

We can keep this feature as an "option". This is a very handy feature expecially for those forums where you want to have folders on the main page and still want the users to come to know about the new postings. Or option can also be kept for only "new" appearing instead of the message count.

Re: New message count next to "new" in list view

Thomas Seifert — Sun, 13 Feb 2005 17:54:55 -0600

have fun with the load on the server this would create.

Re: New message count next to "new" in list view

nikhil — Sun, 13 Feb 2005 16:58:39 -0600

I have another suggestion. Once implemented, this would make this module real useful and worth including with the original phorum distribution.
Suppose, I have made some folders in phorum and have forums inside them. Now, I should get the new message count next to the folders also? What I mean is, suppose I have a folder "bla Folder" and there are 3 forums in it f1, f2 and f3. Now suppose a new post is done in f2, then, next to the bla Folder on the main page, (1 new) appears.

Re: New message count next to "new" in list view

Panu — Wed, 19 Jan 2005 02:59:37 -0600

Sorry, my mistake, I should have said either:

if messageid > $PHORUM['user']['newinfo']['min_id']

then I count message as new

or

messageid < $PHORUM['user']['newinfo']['min_id']

then I don't count message as new.

So I do exactly the same as main phorum code? What could be the reason for threaded read to have "new" attached to messages that have messageid < minid?

Re: New message count next to "new" in list view

Thomas Seifert — Wed, 19 Jan 2005 02:31:35 -0600

you shouldn't count as new if *smaller* than min_id.

all messages with a smaller id than min_id are taken as old/read.

Re: New message count next to "new" in list view

Panu — Tue, 18 Jan 2005 17:34:27 -0600

Ok I kind of found the problem, but I'm not sure what's right.

I don't count message as new if
messageid > $PHORUM['user']['newinfo']['min_id']

Phorum shouldn't either, but it does...

if (!isset($PHORUM['user']['newinfo'][$row['message_id']]) && $row['message_id'] > $PHORUM['user']['newinfo']['min_id']) {
    $messages[$key]["new"]=" " . $PHORUM["DATA"]["LANG"]["newflag"];
}

Or have I understood min_id wrong?

Anyway attached is new version of the mod, I fixed a problem when showing old messages

Re: New message count next to "new" in list view

Panu — Tue, 18 Jan 2005 11:11:05 -0600

Thankyou for testing.

I tested my own phorum and I get the correct amount every time. I found another problem thou which I'm fixing tonight.

There's not many places where it can go wrong on the mod, it basically just removes already read message id's from an array and count's the remaining array.

So the only thing that comes to my mind is that you run out of newflags? On the other hand you shouldn't see the "new" next to the subject in threaded view either? I quess.

Additionally I don't calc the message as new if the message id is smaller than users newinfo minid

so if you can find that, for the user and then compare that to the "missing" messages id's.

Hmm I don't know if you understood anything from the above sentence, even I had some difficulties.

Re: New message count next to "new" in list view

SalsaShark — Tue, 18 Jan 2005 09:50:14 -0600

Sorry, it was 1.4, but I'm using 1.5 now. I have List view as Flat and Read view as Threaded. Example:

[age.salsashark.net]

Note, for example, the "New Recruit" thread. It just reports "new" but in the read view you can see there are quite a few:

[age.salsashark.net]

This happens in several threads. Another example is the "Outstanding wrestler" thread which shows 11 new, but actually has 15 new:

[age.salsashark.net]

Re: New message count next to "new" in list view

Panu — Fri, 14 Jan 2005 17:35:32 -0600

new version...

added support for Phorums module localisation feature add fixed some cosmetic things.

Thread new message counting error not fixed because I'm not able to reproduce it.

Re: New message count next to "new" in list view

Panu — Fri, 14 Jan 2005 11:09:36 -0600

Well that's the still unreleased version... :) 1.4 is the latest I have uploaded.

but anyway can you give the following information:

what are the Thread Override fileds saying in your profile?

I only get "new" when threaded view is selected.

If threaded view is used it returns the messages untouched. I have to double check mixed threaded/list/read case.

But anyway the counts should be correct assuming Phorum is reporting them correctly.

Can you attach a screenshot showing the bug?

Re: New message count next to "new" in list view

SalsaShark — Fri, 14 Jan 2005 08:07:53 -0600

Assuming 1.5 is the latest version, yes.

Re: New message count next to "new" in list view

Panu — Thu, 13 Jan 2005 16:11:53 -0600

Well I have already done it, haven't just uploaded it yet.

I thought that I implement new-notification in read-page before releasing, but now when that's going to be in v. 5.1 I don't have to. So I'll propably upload it tomorrow.

Re: New message count next to "new" in list view

Chris Eaton — Thu, 13 Jan 2005 15:56:02 -0600

Creating a language file is really easy, you should consider doing it. It'll also handle upgrades to the module much better then hacking the module code will.

Re: New message count next to "new" in list view

Panu — Thu, 13 Jan 2005 11:54:23 -0600

Hmm, works for me? Are you using the latest version?