Tree lines like Phorum 3 module!

Re: Tree lines like Phorum 3 module!

Diego — Fri, 12 Dec 2008 18:55:37 -0600

tried to implement this in 5.2 but nothing happens
I know this is for 5.1 versions but I see last user implemented it succesfully in 5.2
any other experience with 5.2? I see missing tags like {marker} and others

thanks

Re: Tree lines like Phorum 3 module!

chrissi — Sun, 04 May 2008 07:59:23 -0500

hello folks,

this for solving the problem with the gaps between the lines in IE7. (tested for Version 5.2.7)

After studying a long time, i figured out, that the reason is the following in the css.tpl for the img: "vertical-align: middle".
IE7 is adding a pixel above the gifs in that case .. well :(

My way out of it:
Do eyerything as described in the last Update from Snake (TreeviewModUpdate.zip).
Then change all the 8 img-tag-lines in mods/treeview.php like this:

$t_gif="";

with an extra style="vertical-align: top;"

Then there are 2 possibilities i found for changing the templates list_threads.tpl AND read_threads.tpl:

1)
Put a trans.gif after MESSAGES->indent_cnt, like:

       {MESSAGES->indent_cnt}

The result is not quite perfect: In Firefox the subject is 1 or 2 pixel above the middle and in IE7 it is 1 or 2 pixel below ..:) But for those who don´t need it perfect, it´s ok.

OR

2) For the perfect ones :)
Change the templates list_threads.tpl AND read_threads.tpl in that way that you use a new table for the one td where the indent and the subject is!

for example:

       {MESSAGES->indent}{marker}
        {IF MESSAGES->sort PHORUM_SORT_STICKY}
          {LANG->Sticky}:
        {/IF}
        {IF MESSAGES->sort PHORUM_SORT_ANNOUNCEMENT}
          {LANG->Announcement}:
        {/IF}
        {IF MESSAGES->moved}
          {LANG->MovedSubject}:
        {/IF}
        {MESSAGES->subject} {MESSAGES->new}

change to:

      
	
	  
	     {MESSAGES->indent_cnt}
	    
		{IF MESSAGES->sort PHORUM_SORT_STICKY}
		  {LANG->Sticky}:
		{/IF}
		{IF MESSAGES->sort PHORUM_SORT_ANNOUNCEMENT}
		  {LANG->Announcement}:
		{/IF}
		{IF MESSAGES->moved}
		  {LANG->MovedSubject}:
		{/IF}
		{MESSAGES->subject} {MESSAGES->new}

Please be careful if this code really fits in your files, because the MESSAGES->indent and the ROWS->indent -variables don´t exist any longer (my Version here: 5.2.7), but i´m not really sure about it. Well, in the treeview.php the MESSAGES->indent_cnt -variable is used and it works for list_threads.tpl and read_threads.tpl ..

(One more note: If the links "delete, move, merge threads" in the date-field bother, just delete the br there, and set the width for the td to 220, for example)

That´s it! Believe me, i feel much more relaxed now ..:)

PS: My special advice: Change the gifs with photoshop as you like it, but t,l,i,trans-gifs must have same width and m,n,c must have same width. All gifs must have same height, and it must be corrected in the files above, surely.

Re: Tree lines like Phorum 3 module!

Snake — Mon, 26 Mar 2007 19:48:21 -0500

The Site I have for my testing is done on my internal/local web-server, I have tested it via other computers as well, externally locating via my referring URL.

By Extensive, that is what I meant, the time it takes to edit, LOL.

Not having a test forum is a swine, I was using only 1 test forum, & a server crash caused the whole thing to screw up completely. Now I have 2 test forums, development & stable. Soon as the MOD I'm working on, on the first test forum is working correctly, & I've tested the shit out of it, I copy it across to the second test Forum, replacing the database & the files for that forum.

Although I've done work with HTML for years, I'm a true beginner with PHP/MySQL/CSS Style Sheets. So I'm prone to use the easiest method available to me, until my knowledge/experience gets better, LOL.

As a side-note, for a different thread you posted on, I have a query for you on Multi level folder support for new index view, if you could kindly take a look, & see if you can help with that thread? I'll double check that thread regularly, for any new messages you post, instead of cross-posting on this thread.

Thanks.

Re: Tree lines like Phorum 3 module!

freedman — Mon, 26 Mar 2007 17:05:46 -0500

I didn't see any sites posted which are using your edits, so I wasn't sure who was and who wasnt, :P..

I dont think my mods are very extensive, just more time consuming.. since all the modifications would be to code in loops, it shouldn't be that extensive, more just time consuming, I think.
I also dont have handy a test phorum, so I have to be careful about what I do in production.

if your mod solves the gap problems, then it's probably the right thing, although I'm a big fan of using CSS to do as much work as possible, and saving bandwidth.

Re: Tree lines like Phorum 3 module!

Snake — Mon, 26 Mar 2007 16:33:46 -0500

Thanks for the feedback on how you made your own edit.

With your version, you specified how you fixed it, did it completely remove all the gaps?

It seems to be quite a bit of editing in your version, granted that when I was coding my update to Brian's MOD, it took abit of time to get it all right, but now, as it is, if your following the instructions correctly, it should take less than 5 minutes to complete the edits to the files listed in the update version I previously uploaded here.

You specified that your not using this mod at the moment, if you get the chance sometime, let me know how it looks on your site, if you still get any gaps, or if its fixed it.

Yeah, I looked at lafcpug phorum prior to starting the coding of this MOD, I have seen other phorums as well with the same issue, that's partly why I coded this update, I wanted my own Phorum gaps solved as well.

IE screwing with the view of a site, tell me about it, IE is one of the worst culprits for that.

Since I made the MOD update, I have further tested it against IE 6.5, IE 7.0, Mozilla Firefox 2.0.0.3 & Netscapte (but I can't remember what version that was), so far the MOD looks stable.

Re: Tree lines like Phorum 3 module!

freedman — Mon, 26 Mar 2007 16:04:55 -0500

I was looking at the lafcpug phorum, and under IE7, as a general user, I see gaps in the vertical lines.. I've experienced this type of thing on many sites I've developed that have to have lines spanning columns. Different browsers do different things when given the same instruction and it's terribly annoying...
here's how I've solved it...
instead of using normal images within the tabledata, you have to make the lines the table background image... the browser will extend this properly based on the proper instruction.
so, for example...
THIS:


 
   
  www.lafcpug.org];
   Re: Shake Basics

should be:


 
   
  www.lafcpug.org];
   Re: Shake Basics

the only difference is that we're specifying a background image which is the vertical bar, so it will extend past the gaps should the browser decide to stick some space in their (often it will render a font slightly larger than you planned, and that's where you get a pixel or 2 gap.

to save bandwidth, and hastle, it would make more sense to use CSS to solve this problem and have a class you use for the td which has the background image/background repeat in it.

for alternating rows, the TR should have a class which specifies the row color, which should cascade down to the td's so you can add a subclass to the td's

so, I've attached a couple pics.. one that shows your site with the spaces as I see them in IE7, and another with some quickie mods with IMHO, better use of CSS.

.treecontinue1 {
	background-image:url(Phorum  Shake 4_1_files/i1.gif);
	background-repeat:repeat-y;
	PADDING-RIGHT: 0px; PADDING-LEFT: 5px;
}

        
            Re" target="_blank"  rel="nofollow">www.lafcpug.org]: 
            Compression in fileout nodes

note, the class phorumtablerowalt, was moved up to the TR, so you dont need it in each column...this is a waste of bandwidth. now we can use additional classes in the TD.
in this case, treecontinue1, sets the background of i1.gif (this is i.gif with an additional 5 pixels on the lefthand side, to adjust for the left padding).

to deal with the corners, you'd need to make additional background images and associated css styles which dont 'repeat-y' but are just a few pixels in lengths to fill in any potential top gap.
there should be treecontinue2, which has 2 vertical bars, etc...
so, you just specify the right class for the td depending on what's going on in that frame, then simply use one transparent gif to push the + and corners and end pieces into the right position.

I'm not currently using this mod, although I'd like to, I just dont have time to get all this done at the moment, otherwise, I'd have just modified and posted an updated version, but I think this should be enough for someone to move forward.

Files included:
Pic with spaces.
pic with spaces fixed on the left vertical bar.
new i1.gif with the vertical bar scooted over 5 pixels
(NOTE: i1.gif is only a pixel or 2 tall, since the browser will repeat the image, there's no need to have the file any larger than necessary.--ideally for bandwidth savings, it should be exactly 1 pixel tall.--it also doesn't need any of the transparent pixels on the right so this could be trimmed even more)

Re: Tree lines like Phorum 3 module!

Snake — Sat, 17 Mar 2007 19:51:27 -0500

OK, I'm in the middle of testing my forum, prior to compiling an archive of the files that make this work true (on user & admin/moderator accounts).

As soon as all the tests are complete, I will upload a .zip file for those wanting to update.

P.S. I know some people have uploaded archives in tar.gz file format, I have no idea what program uses that, so mine will only be .zip

************

UPDATE:
OK, after my Test Server crashed, rebuild & even more testing, it's finally finished. I have tested the Treeview Forum MOD with Multiple Messages, Users, & Forums, and it all seems to work, all lined up correctly, WITHOUT ANY GAPS.

Enjoy.

Re: Tree lines like Phorum 3 module!

Snake — Fri, 16 Mar 2007 21:37:44 -0500

I still haven't sorted any new images yet, the issue with the gaps in User Mode was simple. However, the Admin/Moderate Threaded Mode was tricky.

Goto your "include/lang/english.php" file, then do this:

rename these
"DeleteThread" => "Delete Thread",
"MergeThread" => "Merge Thread",
"MoveThread" => "Move Thread",
to
"DeleteThread" => "Delete",
"MergeThread" => "Merge",
"MoveThread" => "Move",

Once these are renamed, save your file, clear the cache, refresh your page. They will now ALL show up on 1 line, NO GAPS, fixed.

It's like almost 3am here, if you need the full info on how I set mine, I will post that when asked.

Re: Tree lines like Phorum 3 module!

Snake — Wed, 14 Mar 2007 09:35:35 -0500

Hi, I have been reading the messages re: this Tree Threading, after installing the MOD, it took me a couple of hours to fix the issue of gaps showing, but its all sorted, & looks cool.

What I would like to know, the images used for the tree, is there any chance of having a slightly larger version of these, as they show up as real small. I've tried making larger images, but it screws up the whole page. Even if some1 could let me know how to fix the alignment sizes, with larger images, would be helpful.

Also, quite some time back, "D-rex" metioned about using alternating colours in his forum, that is what I would like to do for my Forum, he mentioned he fixed it, but I haven't been able to find any information on how he did that. I've been playing with the settings in some of the *.tpl files, in the Templates folder, to see if I can set it myself, but all I have been able to do is edit the thread colours, not the individual posted message colours. I would be grateful if some help could with this, or even a clue as to which file (there are lots of them).

I am fairly new to PHP & Forum/Phorum Design, so any help is grately appreciated.

Re: Tree lines like Phorum 3 module!

orinoco — Tue, 06 Feb 2007 18:46:33 -0600

Hi,

these are my modified default

css.tpl
list_threads.tpl
read_threads.tpl

files.

Beside the usual required modifications there's a special modification in the list_threads.tpl file which keeps the nice treeview look even for admins by replacing the written admin links "delete", "move" and "merge" into "x, -> and -><- signs in one line back again. The written words are not completely deleted but moved into title options of the referring links, so they appear when hovering over the admin links.

71c71
<               {LANG->DeleteMessage}
---
>               x
74c74
<               {LANG->DeleteThread}{IF ROWS->move_url} | {LANG->MoveThread}{/IF} | {LANG->MergeThread}{/IF}
---
>               x{IF ROWS->move_url} | ->{/IF} | -><-{/IF}

regards

Orinoco

Re: Tree lines like Phorum 3 module!

Michael Horton — Sun, 01 Oct 2006 13:10:45 -0500

If you read and follow this enitre thread you can remove the gaps. Just make sure you are not logged in as admin or a mod. Mods and admins will never see the tree lines without gaps.

Re: Tree lines like Phorum 3 module!

vaidotas — Sun, 01 Oct 2006 10:54:28 -0500

I am using treeview on eugenol_5-1-8 template [www.phorum.org]

Please help, what I need to change to remove lines and gaps?

Thanks.

My test site is here [www.skydive.lt]

Re: Tree lines like Phorum 3 module!

Panu — Mon, 07 Aug 2006 14:30:15 -0500

Quote
pat
Sometimes it just takes somebody to take the lead. Why don't you two just stick your heads together and issue an Classical-Treeview-Template-Set. It shouldn't be hard for knowledgeable guys like you.

Well I have had plans (before Brian informed about the next gen template) to make my own template (tm) :) for years (since 5beta) but real world issues like 3 under 4 year old kids have limited my time to do much.

Either I should ask some tips for the kids from Brian or few hours less sleep during night time (hanging on a thread alredy...)

So thank you for your kind words but even if want to I'm just not able at the moment. I'm more than willing to help and test or give some opinions even if that is considered helpful.

I may check the current state of the template as it is and maybe change the default template as needed so the template can be shipped with the mod for example. I'm sure Ulf is cabable of doing that too.

Re: Tree lines like Phorum 3 module!

pat — Mon, 07 Aug 2006 12:22:34 -0500

Quote
Ulf Dunkel
Wouldn't it be nice to have the treeview stuff implemented as a base module in Phorum 5 finally?

Quote
Panu
If it was cleaned up a little with admin sized images for example it would be perfect...

Sometimes it just takes somebody to take the lead. Why don't you two just stick your heads together and issue an Classical-Treeview-Template-Set. It shouldn't be hard for knowledgeable guys like you.

Re: Tree lines like Phorum 3 module!

Panu — Mon, 07 Aug 2006 10:56:48 -0500

Well it's more like an hack at the moment because you need to change css and templates.

I would be happy if it replaced the "triangle" theme though :-) It's the main advantage UI vise compared to "other" forums. Unfortunately not many of my users use it and I have settled to use flat view be default.

If it was cleaned up a little with admin sized images for example it would be perfect...

Re: Tree lines like Phorum 3 module!

Ulf Dunkel — Mon, 07 Aug 2006 10:12:35 -0500

Wouldn't it be nice to have the treeview stuff implemented as a base module in Phorum 5 finally?

Re: Tree lines like Phorum 3 module!

Thomas Seifert — Thu, 03 Aug 2006 14:46:22 -0500

ah the admin / mods.
they have larger lines because of the delete/move links in the list-view.
either remove those or make larger images just for moderators.

Re: Tree lines like Phorum 3 module!

Michael Horton — Thu, 03 Aug 2006 12:50:27 -0500

OK, accidently stumbled onto this. There appears to be no gaps in the tree line if I log out. If I log in the gaps appear. I'm the admin so I assume this is something I just have to live with as do the moderators?

I recall Brian saying something about mods will not see tree lines in pretty way "due to the moderation links under the messages."

Re: Tree lines like Phorum 3 module!

Michael Horton — Tue, 01 Aug 2006 12:27:55 -0500

tried it. No result. Dang. One of these days Panu.

;)

Re: Tree lines like Phorum 3 module!

Panu — Tue, 01 Aug 2006 06:42:33 -0500

you could try border-bottom: 0px; instead of border-bottom: none;

Re: Tree lines like Phorum 3 module!

Michael Horton — Mon, 31 Jul 2006 13:29:58 -0500

Well as is uusal with me I am a bit confused. I removed

border-bottom-style: solid;
border-bottom-color: #F2F2F2;
border-bottom-width: 0px;

from phorumtablerow and phorumtablerowalt

Is that it? No change on my end. Still see the little gaps

Re: Tree lines like Phorum 3 module!

Panu — Mon, 31 Jul 2006 02:56:18 -0500

FF and Opera look fine here. IE shows a linewidth worth of space but ok, what would you expect :)

btw is not valid, you have to get rid of everything else than

for the gaps to go away try to remove

border-bottom-style: solid;
border-bottom-color: #F2F2F2;
border-bottom-width: 0px;

from phorumtablerow

Re: Tree lines like Phorum 3 module!

Michael Horton — Mon, 31 Jul 2006 01:28:21 -0500

Wait. I now have gaps in Camino. Thats weird. Clean one second, gaps the next. Still, I feel like we accomplished a lot Panu

;)

Re: Tree lines like Phorum 3 module!

Michael Horton — Mon, 31 Jul 2006 01:21:20 -0500

Dang. It worked!! I have NO gaps in Camino but gaps in Safari and FF and first post in thread as well as stickys and Announcement are a little to the right of the forum border where they should be. Thanks so much Panu.

Cant quite figure out what difference is with Safari and FF. Still got gaps in there but Camino is SO clean.

I also notice in Thread view that in FF and Camino and NOT Safari the tiny "Delete Thread | Move Thread | Merge Thread" that Mods and Admin see, do not wrap as they do in Safari.

Not a big deal but looks nicer in Safari.

Boy, whatever happened to standards?

Re: Tree lines like Phorum 3 module!

Panu — Sun, 30 Jul 2006 04:24:57 -0500

You still have padding-left: 0px somewhere...

this is taken from your page source:


  
                        

 New" target="_blank"  rel="nofollow">wiki.lafcpug.org] Board

As son as you have removed that padding from the list_threads.tpl

{ELSE}
  style="padding-left: {ROWS->indent_cnt}px">

I think you can remove that same padding from (or the whole style="...) from sticky and announcement blocks too.

Then make sure that you have the following in your stylesheet

PhorumTableRow and PhorumTableRowAlt have

height: 15px; //(this should be 21 or less, if you still have gaps it should be smaller than 21)
padding: 0px;
margin: 0px;
padding-left 5px;

And then try again.

Re: Tree lines like Phorum 3 module!

Michael Horton — Sun, 30 Jul 2006 02:53:14 -0500

Hi D-Rex

Before I give thie "Gap Fix for Preview Cure" a try I have a question. Not sure about your change in List Thread:

ADD
between {ROWS->new}
and {IF VIEWCOUNT_COLUMN}

My code as it exists now

{ROWS->subject} {ROWS->new}

{/IF}
{IF VIEWCOUNT_COLUMN}

So, question is..exactly where do I put the change since there is a and [/IF] in between. Or do I just replace and [/IF] with

Thanks from a PHP moron

Re: Tree lines like Phorum 3 module!

Michael Horton — Sun, 30 Jul 2006 02:17:41 -0500

Well I tried this. At least I think I tried it if I understand what you are saying. No change.

Thanks for staying with me on this Panu. Much appreciated. I just dont seem to be getting anywhere though. Still gaps in FF and Safari and Camino (smaller gaps in Camino)

I dunno. Guess Tree lines are not in the cards for me.

Re: Tree lines like Phorum 3 module!

Panu — Fri, 28 Jul 2006 15:17:46 -0500

You have

but

So

setting padding-left: 5px; only affects the very first thread.

Remove style="padding-left: 0px;" from the template and add padding-left: 5px; to PhorumTableRow and PhorumTableRowAlt in css file.

Re: Tree lines like Phorum 3 module!

Michael Horton — Fri, 28 Jul 2006 14:46:57 -0500

Ok, I will. Any idea on how I might be able to indent the top post in a thread a couple pixels? Or are you not seeing that now. As I see it, the "box" rests right up against the forum wall rather than a couple pixels to the right as in Phorum 3.

Re: Tree lines like Phorum 3 module!

Panu — Fri, 28 Jul 2006 14:42:47 -0500

No especially when I'm using exactly the same resolution (Dell)... :)

You could try Camino for another Gecko based browser to see if it's some setting of your FF. Not sure what setting it might be but Mac is different to windows in some ways.