Module: Forum Subscriptions

With 500 members plus I had to change to smtp because only about 2% of the emails were going out.

The number of members is totally irrelevant for the mail functionality. Apparently your hosting partner does not have their PHP / system setup working for solid mail delivery via PHP directly.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce

Hello, this module functionality looks great for us, thanks Joe!

One thing is that it do not send emails. NO cronjob. No errors in Event Log (img below). Module settings below.


.

What could be the cause of problem? Thanks for advice!

Kind regards
Bartek

the log entries report it has sent the email. Are you sure that they are not going out and not only landing in the spam folder?

---

Thomas Seifert

Hi Thomas,

checked twice on two accounts - no mail in inbox&spam folders. What do you suggest to check (logs/files) in engine?

Thanks for info :)
Bartek

I'd say, check the mailserver logs - but I also didn't write this module.

---

Thomas Seifert

You could also add to the module error logs Joe integrated within the code in order to check on specific data. I regret that he does not seem to be part of the team anymore.

I was wonderring if there is a way to have the default state of a new user to be subscribed to all forums? Then they will have the option to opt out if they want. This is a rally helpful mod. Thanks.

-Luis

I think there is a bug in the forum_subscriptions/db_functions.php:483

$return_val shouldn't be DB_RETURN_ASSOC but rather DB_RETURN_ASSOCS. In this case the whole assignment should be pulled out of if-then-else branching and assigned DB_RETURN_ASSOCS.

Otherwise, it issues a warning like that:

Warning: Illegal string offset 'forum_id' in [%phorum_folder%]/mods/forum_subscriptions/db_functions.php on line 497
Warning: Illegal string offset 'forum_id' in [%phorum_folder%]/mods/forum_subscriptions/db_functions.php on line 497
Warning: Illegal string offset 'forum_id' in [%phorum_folder%]/mods/forum_subscriptions/db_functions.php on line 498
Warning: Illegal string offset 'forum_id' in [%phorum_folder%]/mods/forum_subscriptions/db_functions.php on line 497
Warning: Illegal string offset 'forum_id' in [%phorum_folder%]/mods/forum_subscriptions/db_functions.php on line 497
Warning: Illegal string offset 'forum_id' in [%phorum_folder%]/mods/forum_subscriptions/db_functions.php on line 498

I noticed the warning is issued in case a user tries to subscribe to

• an already subscribed forum;
• a forum when already subscribed to all of them;
• all forums when already subscribed to all of them.

Would you confirm this bug should be corrected?

Looking forward to your answer.

Thank you.

Joe,

I think forum access functions like

Language: PHP
phorum_api_user_check_access(PHORUM_USER_ALLOW_READ, PHORUM_ACCESS_LIST, $user_id)

or

Language: PHP
phorum_api_user_check_access(PHORUM_USER_ALLOW_READ, $mail_data["forum_id"], $user_id)

in forum_subscriptions_after_post.php don't yield the correct results, which can be retrieved from

Language: PHP
phorum_db_user_get($user_id, true)

in 'forum_permissions' and 'group_permissions'.

I found that phorum_api_user_check_access with 3 parameters is called only in your module. It can be the cause of problem.

Would you please examine this issue and comment?