Module: Spam Hurdles 2, release candidate - testers welcome

Correct

So you are using PHP 5.4 as it seems.
Change this line to

Language: PHP
$scrambled{(int)(((int)$scramblePassword{$k}) * $numberOfRows) + $i} = $escaped{$k};

and it should avoid those warnings.

---

Thomas Seifert



Edited 1 time(s). Last edit at 12/11/2012 06:13AM by Thomas Seifert.

Thank you very much!

Quote
Thomas Seifert
So you are using PHP 5.4 as it seems.
Change this line to

Language: PHP
$scrambled{(int)(((int)$scramblePassword{$k}) * $numberOfRows) + $i} = $escaped{$k};

and it should avoid those warnings.

Yes, thanks! PHP version 5.4.18 here and that got rid of the notice warnings for me too. Thanks again.

Quote
kswift
This works well, generally! However since the previous spam hurdles, and still with this version, I have had a problem:

I would completely disable the 'Spam Hurdles for posting new messages' section, because we only need this to prevent robots from signing up. However despite only enabling the 'Spam Hurdles for user registration' section, we still get the occasional message that is kept in unapproved mode because of spam hurdles somehow thinking it is spam.
Any idea what may cause this?

Using version 5.2.16.

I'm having the same problem except all messages are being unapproved or fully blocked (depending on the setting in the module). There isn't an option to disable the hurdle for posting new topics/messages, so how do we use spam hurdles to only provide the captcha for registration, or should we be using a different module?

Well. if you disabled all "Spam Hurdles for posting new messages" its not enabled for new messages anymore.

---

Thomas Seifert

Well, we've caught a bug related to Spam Hurdles module. I was able to reproduce it at different Phorum setups even at a newly clean one.

We are on
Phorum 5.2.19,
Spam Hurdles 2.0.2.
(nginx 1.2.4
PHP 5.3.21
MySQL 5.1.67)

Okay, if we turn on spam hurdles with default settings and approve "Enable Caching Messages" in Cache Settings here is what happens. Let's say a user posts a new topic message, which is sent to moderation by the Spam Hurdles module.
Then if a moderator goes to that new topic message, there is a number of warnings popping up like those:

Quote

Notice: Undefined index: message_ids in [phorum_dir]/read.php on line 270

Warning: sort() expects parameter 1 to be array, null given in [phorum_dir]/read.php on line 276

Warning: array_slice() expects parameter 1 to be array, null given in [phorum_dir]/read.php on line 305

Warning: Invalid argument supplied for foreach() in [phorum_dir]/read.php on line 325

The reason for those warnings is a PHP code block related to cache regime for the message.
It tries to read data from cache represented by phorum_messages.meta field. It expects either message_ids or message_ids_moderator but it's empty in that field. It gets null instead of an array. And after trying to apply array operations to a null value we get abeforementioned warnings.

If caching messages is turned off moderator doesn't see the warnings. Because message data is read and rebuild from database and everything goes well.

This problem doesn't bother much. It can be deflected by suppressing errors. But anyway this shouldn't be the way the code logic is organized.

Please comment on this issue and possibly provide a solution vector.

Best wishes!

Hi Yupri,

Quote
yupri
Well, we've caught a bug related to Spam Hurdles module. I was able to reproduce it at different Phorum setups even at a newly clean one.

I tried to figure out the problem, but I wasn't able to reproduce it.

I think you have a problem with serialize/unserialize the meta column. "message_ids" is stored as serialized data in this field and the "message_ids" value is always included. It shouldn't be possible that "message_ids" is missing.

Is it possible, that you make some more tests? Please contact me via PM.

Regards
Oliver

---

Using Phorum since 7/2000: forum.langzeittest.de (actual version 5.2.23)
Modules "Made in Germany" for version 5.2: Author_as_Sender, CarCost, Close_Topic, Conceal_Message_Timestamp,
Format_Email, Index_Structure, Mailing_List, Pervasive_Forum, Spritmonitor, Terms_of_Service and German_Language_Files_Package.

Hi there, is there any way to update Captcha to the latest version?

Do you mean the reCaptcha one?