Firefox PHP

Module: Spam Hurdles 2, release candidate - testers welcome

Posted by Maurice Makaay 
Re: Module: Spam Hurdles 2, beta - testers welcome
August 20, 2010 12:03AM
Hi,

Quote
noe
They get this message: "The data that you have submitted to the server have been rejected, because it looks like they were posted by an automated bot"

I get the same problem, after this upgrade:
* Phorum from 5.2.14 to 5.2.15a
* spamhurdles from 2.0.0 to 2.0.1

I commented the lines related to PM in the infos.txt file, and in the Phorum admin of spamhurdles, section "Spam Hurdles for posting private messages (PM)", I disabled 4 of the 5 hurdles (I enabled the one in the middle "Hurdle: Check if an HTML commented form field is submitted").

Now it works.

My template is based on the Emerald one, but modified.

Cactus : [www.cactuspro.com]
Re: Module: Spam Hurdles 2, beta - testers welcome
August 20, 2010 05:29PM
Thanks for the report. I will look into it!


Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce
Re: Module: Spam Hurdles 2, beta - testers welcome
October 06, 2010 12:53AM
It has been a while, but I now have had time to look into the issue. Unfortunately, I have been unable to find an issue the PM handling. I installed a basic Phorum 5.2 using Emerald and installed the 2.0.1 version of the spam hurdles module. Using that configuration I could post CAPTCHA-protected PM's.

Can you please check if switching to the main Emerald template changes things? The only reason that I can think of for the PM protection not working, would be some missing template code.


Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce
Re: Module: Spam Hurdles 2, beta - testers welcome
October 06, 2010 01:11PM
I think that the template code is the issue here. If you check out changeset 4610, then you can see that template data might need to be updated in order to make SpamHurdles v2 work for the PM posting as well.

What you need to check, is if you have the following in your pm_post.tpl:

 {HOOK "tpl_pm_editor_before_textarea"}

If not, then take a look at the template that you used as your base template and add the hook statement in your own pm_post.tpl at the correct position. That should make PM posting with SpamHurdles v2 work.


Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce
Re: Module: Spam Hurdles 2, release candidate - testers welcome
October 12, 2010 01:36AM
I just released version 2.0.2 of the module This version was also added to the Phorum 5.2 code, making Spam Hurdles 2 the default for the next stable Phorum release!

Changes for this version:

  • Implemented more complete logging of blocked form posts using the Event Logging module.
  • Extended the settings for this module to make it possible to enable or disable the logging of form posts that are blocked by the Spam Hurdles module.
  • Added code to the settings screen that will check if all templates contain the required template hooks. If there are template files that do not contain the required hooks, then a warning message is printed in the settings screen, telling the admin what templates to update with what hook.


Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce
noe
Re: Module: Spam Hurdles 2, beta - testers welcome
October 12, 2010 01:22PM
Quote
Maurice Makaay
I think that the template code is the issue here. If you check out changeset 4610, then you can see that template data might need to be updated in order to make SpamHurdles v2 work for the PM posting as well.

What you need to check, is if you have the following in your pm_post.tpl:

 {HOOK "tpl_pm_editor_before_textarea"}

If not, then take a look at the template that you used as your base template and add the hook statement in your own pm_post.tpl at the correct position. That should make PM posting with SpamHurdles v2 work.

Yes, that was it, thanks!
Re: Module: Spam Hurdles 2, release candidate - testers welcome
October 12, 2010 02:00PM
Hi Maurice,

Quote
Maurice Makaay
Added code to the settings screen that will check if all templates contain the required template hooks. If there are template files that do not contain the required hooks, then a warning message is printed in the settings screen, telling the admin what templates to update with what hook.

I think this should be part of a sanity check...

Regards
Oliver


Using Phorum since 7/2000: forum.langzeittest.de (actual version 5.2.23)
Modules "Made in Germany" for version 5.2: Author_as_Sender, CarCost, Close_Topic, Conceal_Message_Timestamp,
Format_Email, Index_Structure, Mailing_List, Pervasive_Forum, Spritmonitor, Terms_of_Service and German_Language_Files_Package.
Re: Module: Spam Hurdles 2, release candidate - testers welcome
October 12, 2010 02:22PM
A sanity check is too late for this. The admin who enables the setting needs to know right away that his template might be causing issues for the selected protection. When things are wrong, nobody can post a form at all. That's why I put this sanity-check-like check right in the admin settings form.

A sanity check could be an option next to the checking that is already done in the admin settings. I'll see what I can do for that.


Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce
Re: Module: Spam Hurdles 2, release candidate - testers welcome
October 29, 2010 10:33PM
Hello,

Please find attached a completed french.php file.

There's a typo in the English message NeedJavascript:
s/diabled/disabled/

Thanks again for your module, Maurice!

Edit maurice: removed the language file, because it is now part of the Phorum distribution.

Cactus : [www.cactuspro.com]



Edited 1 time(s). Last edit at 11/02/2010 04:58PM by Maurice Makaay.
Re: Module: Spam Hurdles 2, release candidate - testers welcome
November 02, 2010 05:01PM
The code has been updated. Thanks!


Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce
Sorry, only registered users may post in this forum.

Click here to login