Module: Embed Images

Check if version 1.0.6 brings you joy and happiness.
I added the new German language files to the package as well.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce

Hi Maurice,

Quote
Maurice Makaay
Check if version 1.0.6 brings you joy and happiness.
I added the new German language files to the package as well.

Thanks!

Sorry to give you some more feedback (and work) but I just compared your new version with my installed one and I found that I did some changes to functions.php to avoid some HTML Validator warnings (cdata and alt-tag added, backslash escaped):

@@ -46,17 +46,19 @@
         "</style>\n" .
 
         "\n<script type=\"text/javascript\">\n" .
+        "//<![CDATA[\n" .
         "/***********************************************************\n" .
         " * This site uses \"Image Thumbnail Viewer Script\"\n" .
         " * (c) Dynamic Drive (www.dynamicdrive.com)\n" .
         " * This notice must stay intact for legal use.\n" .
         " * Visit [www.dynamicdrive.com] for full source code\n" .
         " ***********************************************************/\n" .
-        "thumbnailviewer['defineLoading'] = '<img src=\"{$PHORUM["http_path"]}/mods/embed_images/viewers/dynadrive/code/loading.gif\">&nbsp;&nbsp;{$PHORUM["DATA"]["LANG"]["mod_embed_images"]["LoadingImage"]}';\n" .
-        "thumbnailviewer['definefooter'] = '<div class=\"footerbar\">{$PHORUM["DATA"]["LANG"]["mod_embed_images"]["Close"]} X</div>';\n" .
+        "thumbnailviewer['defineLoading'] = '<img src=\"{$PHORUM["http_path"]}/mods/embed_images/viewers/dynadrive/code/loading.gif\" alt=\"{$PHORUM['DATA']['LANG']['mod_embed_images']['LoadingImage']}\" />&nbsp;&nbsp;{$PHORUM["DATA"]["LANG"]["mod_embed_images"]["LoadingImage"]}';\n" .
+        "thumbnailviewer['definefooter'] = '<div class=\"footerbar\">{$PHORUM["DATA"]["LANG"]["mod_embed_images"]["Close"]} X<\/div>';\n" .
         "thumbnailviewer['enableAnimation'] = " . (empty($PHORUM["mod_embed_images"]["dynadrive_animate"]) ? 'false' : 'true') . ";\n" .
         (empty($PHORUM["mod_embed_images"]["dynadrive_animate"]) ? "thumbnailviewer.opacitystring='';\n" : '') .
         (empty($PHORUM["mod_embed_images"]["dynadrive_noload"]) ? "thumbnailviewer.createthumbBox();\n" : '') .
+        "//]]>\n" .
         "</script>\n";
 }

BTW: info.txt is still linking to phorum-support.de instead of linking to this thread.

Regards
Oliver

---

Using Phorum since 7/2000: forum.langzeittest.de (actual version 5.2.23)
Modules "Made in Germany" for version 5.2: Author_as_Sender, CarCost, Close_Topic, Conceal_Message_Timestamp,
Format_Email, Index_Structure, Mailing_List, Pervasive_Forum, Spritmonitor, Terms_of_Service and German_Language_Files_Package.

Fixed in the new 1.0.6 package.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce

Hi Maurice,

Quote
Maurice Makaay
Fixed in the new 1.0.6 package.

Once more: thanks a lot!

Regards
Oliver

---

Using Phorum since 7/2000: forum.langzeittest.de (actual version 5.2.23)
Modules "Made in Germany" for version 5.2: Author_as_Sender, CarCost, Close_Topic, Conceal_Message_Timestamp,
Format_Email, Index_Structure, Mailing_List, Pervasive_Forum, Spritmonitor, Terms_of_Service and German_Language_Files_Package.

I have Phorum 5.2.7 installed and I'm currently using the default emerald template. I added Embed Images 1.0.6, but when I activated the module, the images I had in my test forum displayed the following error "Image error sh: convert: not found" (Screenshot below). The Embed Images module was installed in the standard fashion, and no changes were made to its settings. This only appears to occur for images that are large enough to need resizing - Images smaller than the default 200 x 200 pixel size are drawn without issue. Can anyone tell me what I have done wrong here?

The event logging module shows the following issues:

---

1) PHP warning: dl() [<a href='function.dl'>function.dl</a>]: Unable to load dynamic library './gd.so' - ld.so.1: httpd: fatal: ./gd.so: open failed: No such file or directory

PHP warning generated at /usr/local/apache2/htdocs/staffweb/phorum/include/api/image.php:205

---

2) PHP warning: dl() [<a href='function.dl'>function.dl</a>]: Unable to load dynamic library './imagick.so' - ld.so.1: httpd: fatal: ./imagick.so: open failed: No such file or directory

PHP warning generated at /usr/local/apache2/htdocs/staffweb/phorum/include/api/image.php:177

---

3) PHP warning: dl() [<a href='function.dl'>function.dl</a>]: Unable to load dynamic library './socket.so' - ld.so.1: httpd: fatal: ./socket.so: open failed: No such file or directory

PHP warning generated at /usr/local/apache2/htdocs/staffweb/phorum/include/api/http_get.php:195

---

4) PHP warning: dl() [<a href='function.dl'>function.dl</a>]: Unable to load dynamic library './curl.so' - ld.so.1: httpd: fatal: ./curl.so: open failed: No such file or directory

PHP warning generated at /usr/local/apache2/htdocs/staffweb/phorum/include/api/http_get.php:77





Edited 1 time(s). Last edit at 05/20/2008 04:19PM by todddarnell.

Your PHP seems to be lacking support for any of the image resizing methods that are implemented by the Phorum image API. The best option is to install PHP's GD extension on the system. If it's not your system, then ask the maintainers of the system to install GD.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce

Excellent. We'll get that installed and I'll let you know if I have any other issues.

Thanks for the quick reply!

Hi Maurice,

my forum users found another problem with emded images module in Internet Explorer if the image is inside a quote:



Link to example: [forum.langzeittest.de]

In Firefox and Safari it's working fine.

Regards
Oliver

---

Using Phorum since 7/2000: forum.langzeittest.de (actual version 5.2.23)
Modules "Made in Germany" for version 5.2: Author_as_Sender, CarCost, Close_Topic, Conceal_Message_Timestamp,
Format_Email, Index_Structure, Mailing_List, Pervasive_Forum, Spritmonitor, Terms_of_Service and German_Language_Files_Package.

That is because the image div is floating. If you add "overflow:hidden" to the style for the quote div, this should be fixed, because the div will then wrap around the float nicely.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce

Hi Maurice,

Quote
Maurice Makaay
If you add "overflow:hidden" to the style for the quote div, this should be fixed, because the div will then wrap around the float nicely.

Thanks, that's working fine. Can you please add it also to the emarald template in Phorum distribution?

#phorum blockquote.bbcode>div {
    margin: 0;
    padding: 5px;
    border: 1px solid {quote_border_color};
    overflow: hidden;
}

Regards
Oliver

---

Using Phorum since 7/2000: forum.langzeittest.de (actual version 5.2.23)
Modules "Made in Germany" for version 5.2: Author_as_Sender, CarCost, Close_Topic, Conceal_Message_Timestamp,
Format_Email, Index_Structure, Mailing_List, Pervasive_Forum, Spritmonitor, Terms_of_Service and German_Language_Files_Package.



Edited 1 time(s). Last edit at 05/23/2008 04:43AM by Oliver Riesen.