Module: Embed Images

If an image is scaled down, then animation is broken, because it's turned into a JPG image. That's a fact that you cannot easily change. You'd need to write an image scaling routine that would scale all separate frames and build a new scaled animated GIF image. If you open the image in the viewer, it should animate.

Not liking animated images at all, I am quite happy with this behavior myself.

I'll have to look into the image retrieval problem. For my site it looks like problems that are introduced on purpose to test the error message handling, but I see one that I can't explain right now. That one might fit your case.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce

Hi Maurice,

Quote
mmakaay
If an image is scaled down, then animation is broken, because it's turned into a JPG image. That's a fact that you cannot easily change. You'd need to write an image scaling routine that would scale all separate frames and build a new scaled animated GIF image. If you open the image in the viewer, it should animate.

Ok, now I understand and I agree, in this case it's not necessary to keep an animated gif. Perhaps this hint should be go to README?

Regards
Oliver

---

Using Phorum since 7/2000: forum.langzeittest.de (actual version 5.2.23)
Modules "Made in Germany" for version 5.2: Author_as_Sender, CarCost, Close_Topic, Conceal_Message_Timestamp,
Format_Email, Index_Structure, Mailing_List, Pervasive_Forum, Spritmonitor, Terms_of_Service and German_Language_Files_Package.

Hi Maurice,

for reconciling miscellaneous german language files please add the attached files (originally from the German Language Files Package) to the next version of your module. Please remove any german_sie.php or german_du.php from module language folder (if existent). Thanks.

Regards
Oliver

[File removed]

---

Using Phorum since 7/2000: forum.langzeittest.de (actual version 5.2.23)
Modules "Made in Germany" for version 5.2: Author_as_Sender, CarCost, Close_Topic, Conceal_Message_Timestamp,
Format_Email, Index_Structure, Mailing_List, Pervasive_Forum, Spritmonitor, Terms_of_Service and German_Language_Files_Package.



Edited 1 time(s). Last edit at 05/12/2008 03:27PM by Oliver Riesen.

Hi Maurice,

according to structuring the language file and charset support I attach new german languages files in ISO-8859-1 and UTF-8. Please add them to the next release of your module.

Regards
Oliver

mmakaay: Removed attachments, added to version 1.0.6 of the module

---

Using Phorum since 7/2000: forum.langzeittest.de (actual version 5.2.23)
Modules "Made in Germany" for version 5.2: Author_as_Sender, CarCost, Close_Topic, Conceal_Message_Timestamp,
Format_Email, Index_Structure, Mailing_List, Pervasive_Forum, Spritmonitor, Terms_of_Service and German_Language_Files_Package.



Edited 1 time(s). Last edit at 05/15/2008 04:02PM by Maurice Makaay.

Hi Maurice,

Quote
Maurice Makaay
I'll have to look into the image retrieval problem. For my site it looks like problems that are introduced on purpose to test the error message handling, but I see one that I can't explain right now. That one might fit your case.

Did you find already some time to have a look?

And perhaps in your next version you change in info.txt also

url: [www.phorum-support.de]

by

url: [www.phorum.org]

Regards
Oliver

---

Using Phorum since 7/2000: forum.langzeittest.de (actual version 5.2.23)
Modules "Made in Germany" for version 5.2: Author_as_Sender, CarCost, Close_Topic, Conceal_Message_Timestamp,
Format_Email, Index_Structure, Mailing_List, Pervasive_Forum, Spritmonitor, Terms_of_Service and German_Language_Files_Package.

Quote
Oliver Riesen
Did you find already some time to have a look?

Yes I had time and I wasn't able to reproduce. The problem cases that were on my test site were all on purpose for testing error handling.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce

Hi Maurice,

Quote
Maurice Makaay
I wasn't able to reproduce.

I did some tests. It seems that it depends on the images source. If an image is published by a script I get the error. If I save the image to a file on my web server it works correct. Perhaps because of different headers?

Please try in your test forum:

 (not working with embed_images)

Header:

Connection: close
Transfer-Encoding: chunked
Content-Type: image/png
Date: Thu, 15 May 2008 07:36:26 GMT
Server: lighttpd/1.4.13

200 OK

 (working)

Header:

Date: Thu, 15 May 2008 07:47:44 GMT
Server: Apache/1.3.33 (Unix) PHP/5.0.4 FrontPage/5.0.2.2623 mod_ssl/2.8.22 OpenSSL/0.9.7e
Last-Modified: Thu, 15 May 2008 07:46:20 GMT
Etag: "258008-131-482bea4c"
Accept-Ranges: bytes
Content-Length: 305
Content-Type: image/png

200 OK

Regards
Oliver

---

Using Phorum since 7/2000: forum.langzeittest.de (actual version 5.2.23)
Modules "Made in Germany" for version 5.2: Author_as_Sender, CarCost, Close_Topic, Conceal_Message_Timestamp,
Format_Email, Index_Structure, Mailing_List, Pervasive_Forum, Spritmonitor, Terms_of_Service and German_Language_Files_Package.

no problem on my test site

Maybe spritmonitor is disallowing deep linking from your site or so? I have no other clue why this might not work for you.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce

Hi Maurice,

Quote
Maurice Makaay
I have no other clue why this might not work for you.

I investigated some more and it seems that is isn't a problem of you module, therefore I started a new thread.

Regards
Oliver

---

Using Phorum since 7/2000: forum.langzeittest.de (actual version 5.2.23)
Modules "Made in Germany" for version 5.2: Author_as_Sender, CarCost, Close_Topic, Conceal_Message_Timestamp,
Format_Email, Index_Structure, Mailing_List, Pervasive_Forum, Spritmonitor, Terms_of_Service and German_Language_Files_Package.

Sorry Maurice,

next problem with embed images. Look at the following bbcode tags (carriage return only for documentation). Both version (lowercase and uppercase) work when Embed Images Module is off.



After enabling your module the uppercase version doesn't work any longer:



Regards
Oliver

---

Using Phorum since 7/2000: forum.langzeittest.de (actual version 5.2.23)
Modules "Made in Germany" for version 5.2: Author_as_Sender, CarCost, Close_Topic, Conceal_Message_Timestamp,
Format_Email, Index_Structure, Mailing_List, Pervasive_Forum, Spritmonitor, Terms_of_Service and German_Language_Files_Package.