Module: Embed Images
Posted by Maurice Makaay
April 05, 2011 03:05PM |
Admin Registered: 20 years ago Posts: 8,532 |
Did you upgrade to 5.2.16 at some point? So were you running an earlier version before?
Please, upload the file include/api/http_get.php from your installation here, so I can check it.
Maurice Makaay
Phorum Development Team
my blog
linkedin profile
secret sauce
Please, upload the file include/api/http_get.php from your installation here, so I can check it.
Maurice Makaay
Phorum Development Team



Re: Module: Embed Images April 05, 2011 03:13PM |
Registered: 13 years ago Posts: 6 |
April 05, 2011 03:17PM |
Admin Registered: 20 years ago Posts: 8,532 |
Only partly successful then. The file that you uploaded is part of 5.2.15. It is definitely not the one that is included with 5.2.16. Re-upload all 5.2.16 files to get this fixed.
A custom template in your own template directory is good indeed. That will allow you to blindly upload all files from the 5.2.16 package, without risking overwriting customizations.
Maurice Makaay
Phorum Development Team
my blog
linkedin profile
secret sauce
A custom template in your own template directory is good indeed. That will allow you to blindly upload all files from the 5.2.16 package, without risking overwriting customizations.
Maurice Makaay
Phorum Development Team



Re: Module: Embed Images April 05, 2011 03:21PM |
Registered: 13 years ago Posts: 6 |
April 05, 2011 03:52PM |
Admin Registered: 20 years ago Posts: 8,532 |
PEBKAC ... everybody runs into one of those as some point, being the one that is "BKAC" ;-)
Maurice Makaay
Phorum Development Team
my blog
linkedin profile
secret sauce
Edited 1 time(s). Last edit at 04/05/2011 04:01PM by Maurice Makaay.
Maurice Makaay
Phorum Development Team



Edited 1 time(s). Last edit at 04/05/2011 04:01PM by Maurice Makaay.
Re: Module: Embed Images April 05, 2011 04:27PM |
Registered: 13 years ago Posts: 6 |
Re: Module: Embed Images April 10, 2011 05:57PM |
Registered: 15 years ago Posts: 10 |
Hi there,
I've got a specific problem with this module. My phorum is a wii gaming/hacking forum and lots of people uses game tags provided by a certain site. And that site presumably uses an automatic redirector to keep the background processing of the images to minimum. And that just confuses embedded images plugin, it fails with "HTTP request failed with code 400".
Here is an example image url that doesn't show
which redirects to here,
Any suggestions other than disabling embedded images plugin? (Just upgraded to the latest version of this module and phorum btw.)
I've got a specific problem with this module. My phorum is a wii gaming/hacking forum and lots of people uses game tags provided by a certain site. And that site presumably uses an automatic redirector to keep the background processing of the images to minimum. And that just confuses embedded images plugin, it fails with "HTTP request failed with code 400".
Here is an example image url that doesn't show
[www.wiinnertag.com]
which redirects to here,
[www.wiinnertag.com]
Any suggestions other than disabling embedded images plugin? (Just upgraded to the latest version of this module and phorum btw.)
April 11, 2011 01:49AM |
Admin Registered: 20 years ago Posts: 8,532 |
This is not a problem of the embed images module. The site that is sending the redirect is not following protocol here. This makes the load operation fail. The problem is that the redirect header from that site looks like:
This redirect should have been:
or what might work too in this case (depends on the server):
What happens now, is that (as instructed by the Location header) a request is sent to www.winnertag.com to get the file ../wiinnertag_images/cached_signs/WiiCrazy.jpg, but the server sees the ../etc as an invalid request, resulting in a 400 error.
The way to fix this, is to inform the winnertag.com owners about their issue. They will have to fix this on their side. The location header must not contain a relative path. An absolute URI must be used instead.
The specification for this can be found in RFC2616:
Maurice Makaay
Phorum Development Team
my blog
linkedin profile
secret sauce
Language: PHPLocation: ../wiinnertag_images/cached_signs/WiiCrazy.jpg
This redirect should have been:
Language: PHPLocation: http://www.wiinnertag.com/wiinnertag_images/cached_signs/WiiCrazy.jpg
or what might work too in this case (depends on the server):
Language: PHPLocation: /wiinnertag_images/cached_signs/WiiCrazy.jpg
What happens now, is that (as instructed by the Location header) a request is sent to www.winnertag.com to get the file ../wiinnertag_images/cached_signs/WiiCrazy.jpg, but the server sees the ../etc as an invalid request, resulting in a 400 error.
The way to fix this, is to inform the winnertag.com owners about their issue. They will have to fix this on their side. The location header must not contain a relative path. An absolute URI must be used instead.
The specification for this can be found in RFC2616:
Quote
14.30 Location
The Location response-header field is used to redirect the recipient to a location other than the Request-URI for completion of the request or identification of a new resource. For 201 (Created) responses, the Location is that of the new resource which was created by the request. For 3xx responses, the location SHOULD indicate the server's preferred URI for automatic redirection to the resource. The field value consists of a single absolute URI.
Location = "Location" ":" absoluteURI
An example is:
Location: http:\//www.w3.org/pub/WWW/People.html
Maurice Makaay
Phorum Development Team



Re: Module: Embed Images April 11, 2011 02:53PM |
Registered: 15 years ago Posts: 10 |
April 11, 2011 03:34PM |
Admin Registered: 20 years ago Posts: 8,532 |
Glad to hear they fixed it on there side.
Good luck with the mod!
Maurice Makaay
Phorum Development Team
my blog
linkedin profile
secret sauce
Good luck with the mod!
Maurice Makaay
Phorum Development Team



Sorry, only registered users may post in this forum.