Module: Embed Images
Posted by Maurice Makaay
Re: Module: Embed Images October 29, 2009 05:16AM |
Registered: 15 years ago Posts: 17 |
Re: Module: Embed Images November 11, 2009 02:26PM |
Registered: 23 years ago Posts: 83 |
If you use Dynamic Drive. the last line of the JS it inserts (thumbnailviewer.createthumbBox();) generates the associated HTML, but the script appears in the head, so as soon as it does that, the browser stops parsing it as head and assumes it's into the body, so when the browser gets to the actual </head> and <body> tags, it treats them as an unmatched </head> that it ignores and an extra <body> whose attributes it has to migrate to the earlier implied <body>. Doesn't really break anything, but it's a little sloppy.
Re: Module: Embed Images November 25, 2009 10:07PM |
Registered: 15 years ago Posts: 2 |
Re: Module: Embed Images November 26, 2009 01:26PM |
Registered: 15 years ago Posts: 2 |
November 26, 2009 02:05PM |
Admin Registered: 20 years ago Posts: 8,532 |
I'm not sure what the error was, but I'm glad you got it to work.
If others find this part of the thread with the same problem: check out the webserver's error log or specific PHP error log. There might be hints why the resizing isn't working. Possibilities could be things like restrictions on the PHP installation or system setup issues that block the webserver from downloading images for resizing.
Maurice Makaay
Phorum Development Team
my blog
linkedin profile
secret sauce
If others find this part of the thread with the same problem: check out the webserver's error log or specific PHP error log. There might be hints why the resizing isn't working. Possibilities could be things like restrictions on the PHP installation or system setup issues that block the webserver from downloading images for resizing.
Maurice Makaay
Phorum Development Team



November 27, 2009 08:45AM |
Admin Registered: 19 years ago Posts: 746 |
Hi Maurice,
it seems that /mods/embed_images/viewers/dynadrive/code/thumbnailviewer.js tries to load an image from root folder:
I think path is missing:
Regards
Oliver
Using Phorum since 7/2000: forum.langzeittest.de (actual version 5.2.23)
Modules "Made in Germany" for version 5.2: Author_as_Sender, CarCost, Close_Topic, Conceal_Message_Timestamp,
Format_Email, Index_Structure, Mailing_List, Pervasive_Forum, Spritmonitor, Terms_of_Service and German_Language_Files_Package.
it seems that /mods/embed_images/viewers/dynadrive/code/thumbnailviewer.js tries to load an image from root folder:
defineLoading: '<img src="loading.gif" \/> Loading Image...', //Define HTML for "loading" div
I think path is missing:
defineLoading: '<img src="mods\/embed_images\/viewers\/dynadrive\/code\/loading.gif" \/> Loading Image...', //Define HTML for "loading" div
Regards
Oliver
Using Phorum since 7/2000: forum.langzeittest.de (actual version 5.2.23)
Modules "Made in Germany" for version 5.2: Author_as_Sender, CarCost, Close_Topic, Conceal_Message_Timestamp,
Format_Email, Index_Structure, Mailing_List, Pervasive_Forum, Spritmonitor, Terms_of_Service and German_Language_Files_Package.
November 29, 2009 11:48AM |
Admin Registered: 20 years ago Posts: 8,532 |
If I would change that code, it means that I would be changing dynadrive's code, which makes it less easy to upgrade. The path should be overwritten from the function image_viewer_common() in viewers/dynadrive/functions.php.
Maurice Makaay
Phorum Development Team
my blog
linkedin profile
secret sauce
Maurice Makaay
Phorum Development Team



December 04, 2009 09:21AM |
Registered: 17 years ago Posts: 533 |
I like the how you can use the Embed Attachments module in conjunction with this module to get attached images to display inside the message body of posts.
However, when someone quotes your post, the image is not rendered in the quote. I would love if this could be added as an option. This way, when someone quotes the picture will be displayed within the bbcode quote instead of rendered as "(attachment 101 mypic.jpg)".
We have a picture sharing post that is several pages long. Sometimes new ones make comments about older posts, and without the image displaying inside the quote, we have no idea what they are talking about.
- Bob
However, when someone quotes your post, the image is not rendered in the quote. I would love if this could be added as an option. This way, when someone quotes the picture will be displayed within the bbcode quote instead of rendered as "(attachment 101 mypic.jpg)".
We have a picture sharing post that is several pages long. Sometimes new ones make comments about older posts, and without the image displaying inside the quote, we have no idea what they are talking about.
- Bob
December 04, 2009 11:27AM |
Admin Registered: 20 years ago Posts: 8,532 |
The problem is that the attachment does not belong to that post. The attachment rendering only works for attachments that belong to the same post.
The way in which this works, is that the rendering is done with the list of attachments as a starting point. So for each attachment, the [attachment ..] link is processed. That's why attachments links from other messages won't render currently.
For what you require, the whole process would need to be different. We'd have to scan the body for [attachment ..] links to replace them. One extra issue that would rise from doing things this way, is that you can try to include images from random threads in a posting. Security-wise, this would need some extra code to not only find these attachment links, but also to check if the attachment is part of the same thread and if the authenticated user is authorized to view the image.
I will keep the idea in mind, but don't expect this overhaul to be implemented really soon.
Maurice Makaay
Phorum Development Team
my blog
linkedin profile
secret sauce
The way in which this works, is that the rendering is done with the list of attachments as a starting point. So for each attachment, the [attachment ..] link is processed. That's why attachments links from other messages won't render currently.
For what you require, the whole process would need to be different. We'd have to scan the body for [attachment ..] links to replace them. One extra issue that would rise from doing things this way, is that you can try to include images from random threads in a posting. Security-wise, this would need some extra code to not only find these attachment links, but also to check if the attachment is part of the same thread and if the authenticated user is authorized to view the image.
I will keep the idea in mind, but don't expect this overhaul to be implemented really soon.
Maurice Makaay
Phorum Development Team



Re: Module: Embed Images December 17, 2009 03:41AM |
Registered: 15 years ago Posts: 41 |
Sorry, only registered users may post in this forum.