Module: Embed Images

A different technique is used there. For [attachment ...], the data is loaded directly from the attachment data in the database. No need for an HTTP request to fetch the data. For [img] images, the scripts do not know that this is a file that is available in the Phorum database. Therefore, for these an HTTP request has to be done to fetch the data. Therefore, these cases cannot be compared.

Try disabling "Show BBcode

Here is a url to a thread that has several of the error messages in it, in case you need to see it.

[www.mytreasurespot.com]

No need to see it. But check my previous post. I had forgotten to escape my [img] bbcode, causing it to break my post.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce

Thanks Marice. I had tried turning off "show bbcode" and it did not work. Today, I tried turning off everything but "all images" and it worked. I then turned on the other options one at a time except for "show bbcode". It is now working. I don't know what did it but I'm not going to look a gift horse in the mouth.

Thanks for all the help.

I perused all the posts in this thread and did not see a resolution for the inquiry I am asking here. I downloaded the most recent version of Phorum and many of the mods and so far everything has been a piece of cake. Very very easy, and I must applaud everyone who contributes to this project for making it so intuitive and simple to implement.

This embed image mod works as it should for me, but it displays one behavior I would like to modify but I do not know how. I do not want the mod to apply to any images used in the signature of a member. Is there a way to do this? If not, then is there a way to limit the size of an image used in a signature so that no thumbnail is made for it.

Mind you, I only have a few days experience with Phorum, so forgive me if my inquiry sounds naive.

TIA

There is currently unfortunately no way to handle this. The issue here is that the signatures are formatted along with the message bodies. They are literally concatenated before they are sent to the formatting code. Historically, this is a performance choice that was made to only need one formatting loop to format both the body and the signature. Therefore, for the formatting processes, there is no visible difference between signature images and body images.

Maybe some hackery could be done in this module to ignore images in signatures. I am not fully sure if that would work out well. I'll put it on my todo list.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce

Quote
Maurice Makaay
There is currently unfortunately no way to handle this. ... I'll put it on my todo list.

Thank you for the quick reply. Perhaps in the meantime I should just make sure that my members are aware that if the signature images are two large dimensionally that they might not display as they expect them to. I can live with that, thanks again.

This may also be solved by updating the Signature Restrictions module to have the option of restricting image sizes if the admin does not want to deny images. This would still be some work for Maurice but may be quicker/simpler than processing signatures separate of the message bodies.

---

Joe Curia (aka Azumandias)
Modules: l0Admin Mass Email00000000l000000Automatic Time Zones000ll.l00000Enhanced Custom Profiles0.00Google Calendar0000l.l000000Post Previews
000000000Admin Security Suite000000000000Check Modules for Upgrades0000External Authentication000000Group Auto-Email00000.00000Private Message Alerts
000000000Attachment Download Counter0000Custom Attachment Icons000ll.ll00Favorite Forums000000.00000Highlighted Search Terms0000Self-Delete Posts Option
000000000Attachment Watermarks0l00000000Custom Language Database00l.l.0Forum Lockdown00000.00000Ignore Forums0000000000000Threaded Tree View
000000000Automatic Message Pruning00.llll.00Easy Color Scheme Manager0l.l00Forum Subscriptions0000lll000Moderated User Group
Templates:lGeneric Integration000000000 0000Simple Rounded000000 00000000Tabbed Emerald

I think that would be considerably more work. For changing this module, it would involve:

1. add a separator marker between body and signature
2. in the formatting, cut the message in body and signature based on the marker
3. format the body part
4. do not format the signature
5. put body and signature back together
6. pass the result on to the next module

It could be relatively easy this way. It'd need some consideration with hook priorities to make sure that this one runs before the signature formatting hook, but all in all I think this could be quite a clean and small change when implemented like this.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce

Embed Images has a bug when used with serf friendly URLs anybody got a fix?