Module: Google Maps

Quote
Maurice Makaay
Great .. only 25% of the browsers have an issue ;-) I'll try to find the issue. If you have additional input (MSIE versions affected, any error messages, a fix :-) I'd be interested in that. I'll first have to bring up a windows system here, so I can test on MSIE myself.

The user that first reported the issue was showing as using IE 7. I then logged in using IE 8 and while the Search Location worked for me and I was able to Save my Changes, the community map is still not working for me either.

I will see if anything is showing in the event logging.

And I feel your pain. I hate having to rewrite good code so that it is backwards compatible with the MSIE :-)

---

Robert Angle
Phorum lover, nothing more.
Ruminations

Event Logging only displays information when I have it show "Debug" stuff (which logs things at ridiculous rates by the way, several dozen things per minute).

I conjured up these logs on my own attempts to view the map. It's all gibberish to me...

---

Message:

PHP notice: Undefined index: to_id

PHP notice generated at /forum/mods/bulk_pm.php:25

Back trace:

Function bulk_pm called
----
Function call_user_func_array called at
{path to Phorum}/common.php:1885
----
Function phorum_hook called at
{path to Phorum}/common.php:853
----
Function include_once called at
{path to Phorum}/addon.php:80
----

Request info:

HTTP_HOST = www.jwtalk.net
HTTP_REFERER = [www.jwtalk.net]
REQUEST_URI = /forum/addon.php?10,module=google_maps,addon=mapframe,reset_latitude=36.26835376180222,reset_longitude=-31.6015625,reset_zoom=1,reset_type=terrain,type=plotter,api_language=en
QUERY_STRING = 10,module=google_maps,addon=mapframe,reset_latitude=36.26835376180222,reset_longitude=-31.6015625,reset_zoom=1,reset_type=terrain,type=plotter,api_language=en

---

Message:

PHP notice: Undefined index:

PHP notice generated at /forum/cache/tpl-jwtalk2-settings-d9c3e476463f713008d432dea71c47e2.php-stage2:103

Back trace:

Function include called at
{path to Phorum}/cache/tpl-jwtalk2-settings-d9c3e476463f713008d432dea71c47e2.php:7
----
Function require_once called at
{path to Phorum}/common.php:707
----
Function include_once called at
{path to Phorum}/addon.php:80
----

Request info:

HTTP_HOST = www.jwtalk.net
HTTP_REFERER = [www.jwtalk.net]
REQUEST_URI = /forum/addon.php?10,module=google_maps,addon=mapframe,reset_latitude=36.26835376180222,reset_longitude=-31.6015625,reset_zoom=1,reset_type=terrain,type=plotter,api_language=en
QUERY_STRING = 10,module=google_maps,addon=mapframe,reset_latitude=36.26835376180222,reset_longitude=-31.6015625,reset_zoom=1,reset_type=terrain,type=plotter,api_language=en

---

Message:

PHP notice: Undefined index:

PHP notice generated at /forum/cache/tpl-jwtalk2-settings-d9c3e476463f713008d432dea71c47e2.php-stage2:101

Back trace:

Function include called at
{path to Phorum}/cache/tpl-jwtalk2-settings-d9c3e476463f713008d432dea71c47e2.php:7
----
Function require_once called at
{path to Phorum}/common.php:707
----
Function include_once called at
{path to Phorum}/addon.php:80
----

Request info:

HTTP_HOST = www.jwtalk.net
HTTP_REFERER = [www.jwtalk.net]
REQUEST_URI = /forum/addon.php?10,module=google_maps,addon=mapframe,reset_latitude=36.26835376180222,reset_longitude=-31.6015625,reset_zoom=1,reset_type=terrain,map_longitude=-81.5190053,map_latitude=41.0814447,map_zoom=1,map_type=terrain,marker_longitude=-81.5190053,marker_latitude=41.0814447,streetview_longitude=,streetview_latitude=,streetview_heading=,streetview_pitch=,streetview_zoom=,geoloc_country=United+States,geoloc_city=Akron,type=viewer,api_language=en
QUERY_STRING = 10,module=google_maps,addon=mapframe,reset_latitude=36.26835376180222,reset_longitude=-31.6015625,reset_zoom=1,reset_type=terrain,map_longitude=-81.5190053,map_latitude=41.0814447,map_zoom=1,map_type=terrain,marker_longitude=-81.5190053,marker_latitude=41.0814447,streetview_longitude=,streetview_latitude=,streetview_heading=,streetview_pitch=,streetview_zoom=,geoloc_country=United+States,geoloc_city=Akron,type=viewer,api_language=en

---

And about 20 or more in addition to these.

---

Robert Angle
Phorum lover, nothing more.
Ruminations

The event logs that you show here are not related to the Google Maps module.

You might want to look into templates/jwtalk2/settings.tpl though, just to get the logs down for yourself. Check out /forum/cache/tpl-jwtalk2-settings-d9c3e476463f713008d432dea71c47e2.php-stage2. On line 101 in that file, some undefined index is used. This can be related to a statement in your settings.tpl file.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce

Bring it up here in on this Phorum and you will see that it does not work in Internet Explorer...

[www.phorum.org]

Also, notice that there are links below the map, kinda displayed like a mess. But when you mouse over them, they disappear one by one.

Looking at that link above in Firefox however works just fine.

---

Robert Angle
Phorum lover, nothing more.
Ruminations

The links are from the jumpmenu module, so I suspect the issue might have something to do with that module.

I just found some time to experiment a bit and I found that users not being able to search for a location could be because they enter a string and then hit <enter>, instead of clicking the search button. I accidentally replaced the type="submit" button with type="button" in the location editor.

Please try if clicking the search button does make the search work for you. If yes, then that problem can be fixed with the new version of the module that I'll upload in a minute.

I have to leave now, but when I get back home later today, I'll investigate the issue further.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce

Quote
Maurice Makaay
The links are from the jumpmenu module, so I suspect the issue might have something to do with that module.

I am not using jumpmenu, just to let you know.

Quote
Maurice Makaay
I just found some time to experiment a bit and I found that users not being able to search for a location could be because they enter a string and then hit <enter>, instead of clicking the search button. I accidentally replaced the type="submit" button with type="button" in the location editor.

Please try if clicking the search button does make the search work for you. If yes, then that problem can be fixed with the new version of the module that I'll upload in a minute.

Yes, when I type my location and press my enter key, nothing happens. But if I click the Search Location button with my mouse pointer, it does mark the map with my location.

Viewing the community map still shows nothing though, either on my site, or here on phorum.org's map at the link I posted above.

I don't think so, but changing the order in which the input fields are displayed doesn't affect this, right?....

---

Robert Angle
Phorum lover, nothing more.
Ruminations

Quote
Maurice Makaay
If yes, then that problem can be fixed with the new version of the module that I'll upload in a minute.

I just upgraded and it did not work. Pressing Enter still submits the form and 'updates your profile' instead of submits the location to the Search Location button.

Could it be a conflict with having 2 type="submit" buttons on the page in the form?

At any rate, the plot point issue is of more significance. I can always add a statement to this panel telling the user to use their mouse pointer and not their enter key.

---

Robert Angle
Phorum lover, nothing more.
Ruminations

I have a display issue in MSIE as well with the map not stretching across the screen.

Here is Firefox and Chrome with plot points working....




and here is Internet Explorer 8, with plot points not working, and map covering only half of the screen....




And then if you notice, I changed the individual marker image. But I had to overwrite the one that comes with the package. Is there a way to make this image point to a file in my custom template directory, so that it is not overwritten when I upgrade the module package?

---

Robert Angle
Phorum lover, nothing more.
Ruminations

As for the stretching: did you update the usermap.tpl according to the new mods/google_maps/templates/emerald/usermap.tpl? All maps must be contained in a surrounding div now. The surrounding div determines the size of the map that is shown.

Does the usermap on phorum.org look good to you? (ignore the links at the bottom; those are from the jumpmenu and I still have to figure out what causes those to fail) --> usermap When I open this usermap in MSIE9, then things look okay to me.

For the marker, I don't have a really cool solution for you. You need a hack now in the maptool/mapframe.php script. In there, the marker image is hard-coded:

Language: PHP
    var ploticon = new google.maps.MarkerImage(
        "<?php print htmlspecialchars($PHORUM["http_path"]) .
                     "/mods/google_maps/maptool/marker.png" ?>",

You can hack this code to make the ploticon point to an image in your own template directory. For a clean way to override the image, I'll have to do some more work on the code. I'll add it to my TODO list for the mod.


Edit: I just uploaded a new package, in which I added some new code for the location editor. This change should make the location form work correctly. Both pressing <enter> and clicking the search button should now trigger a location search, without submitting the form. I upgraded the module on phorum.org, so you can also test it within the control center here.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce



Edited 1 time(s). Last edit at 04/17/2011 02:09PM by Maurice Makaay.

Quote
Maurice Makaay
Does the usermap on phorum.org look good to you? (ignore the links at the bottom; those are from the jumpmenu and I still have to figure out what causes those to fail) --> usermap When I open this usermap in MSIE9, then things look okay to me.

Still no plot points in IE8 here at phorum.org...

---

Robert Angle
Phorum lover, nothing more.
Ruminations