Module: Topic Poll

Quote
pierrexuso
Poll-Software without multiple choice option?

Feel free to add it and publish a new version of this module... ;)

Regards
Oliver

---

Using Phorum since 7/2000: forum.langzeittest.de (actual version 5.2.23)
Modules "Made in Germany" for version 5.2: Author_as_Sender, CarCost, Close_Topic, Conceal_Message_Timestamp,
Format_Email, Index_Structure, Mailing_List, Pervasive_Forum, Spritmonitor, Terms_of_Service and German_Language_Files_Package.

New Version:

2016-09-01 v1.0.22 Oliver Riesen-Mallmann <oliver@riesen.org>
    - Made XHTML 1.0 Transitional compliant.

---

Using Phorum since 7/2000: forum.langzeittest.de (actual version 5.2.23)
Modules "Made in Germany" for version 5.2: Author_as_Sender, CarCost, Close_Topic, Conceal_Message_Timestamp,
Format_Email, Index_Structure, Mailing_List, Pervasive_Forum, Spritmonitor, Terms_of_Service and German_Language_Files_Package.

(Copying this here from the wrong place)

Hi

Moving from PHP 7.4 to 8.3,

[23-Sep-2024 12:31:10 UTC] PHP Fatal error:  Uncaught Error: Call to undefined function each() in /path/to/phorum/mods/topic_poll/topic_poll.php:389
Stack trace:
#0 /path/to/phorum/common.php(1909): phorum_mod_topic_poll_read()
#1 /path/to/phorum/read.php(754): phorum_hook()
#2 {main}
  thrown in /path/to/phorum/mods/topic_poll/topic_poll.php on line 389

The offending line is

Language: PHP
list ($message_id, $message) = each($messages);

and the cause is that each() was deprecated in PHP 7.2 and was removed in 8.0.

I just checked 1.0.22 and it still uses each().

You can try the following. Pretty much do it yourself.

[github.com]

[stackoverflow.com]

[www.google.com]

Quote
Scott Finegan

You can try the following. Pretty much do it yourself.

Thanks, but if I fix my own the module will still be broken. And it is an active and useful module. And it's only this one line of code that breaks it. Everywhere else foreach() is used, so I suspect that this one instance of each() is purely accidental. So from every point of view it would be much better to have it fixed at the source.

Hi Zenon,

I try to publish a new version of the module.

Regards
Oliver

---

Using Phorum since 7/2000: forum.langzeittest.de (actual version 5.2.23)
Modules "Made in Germany" for version 5.2: Author_as_Sender, CarCost, Close_Topic, Conceal_Message_Timestamp,
Format_Email, Index_Structure, Mailing_List, Pervasive_Forum, Spritmonitor, Terms_of_Service and German_Language_Files_Package.

Hi Zenon,

since there are few other passages with "each" in the source code and perhaps also in other modules, I think we should use a funtion to replace "each()" like in polyfill-each: [github.com]

Copy the content of polyfill-each.php to common.php after line 72.

Regards
Oliver

---

Using Phorum since 7/2000: forum.langzeittest.de (actual version 5.2.23)
Modules "Made in Germany" for version 5.2: Author_as_Sender, CarCost, Close_Topic, Conceal_Message_Timestamp,
Format_Email, Index_Structure, Mailing_List, Pervasive_Forum, Spritmonitor, Terms_of_Service and German_Language_Files_Package.

Hi

Quote
Oliver Riesen-Mallmann

since there are few other passages with "each" in the source code and perhaps also in other modules, I think we should use a funtion to replace "each()" like in polyfill-each: [github.com]

You mean in the source code of phorum itself, I assume. Because there is only one instance of each() in topic_poll.

Anyway, I have a somewhat unusual setup, with phorum on a distributed glusterfs filesystem on three machines. So each of these three machines sees one and the same filesystem and files on it. But machine A runs almalinux 8.x with PHP 7.4 and machines B and C run almalinux 9.x with PHP 8.3. All three run a webserver. This means that I can switch back and fro between the same (5.2.23) phorum installation on PHP 7.4 or 8.3 just by toggling /etc/hosts on my workstation.

So I added 'require_once("./include/polyfill-each.php");' in common.php. polyfill-each does nothing if each() already exists, so 7.4 still works fine. 8.3 however breaks elsewhere with

PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported in /path/to/phorum/include/upload_functions.php on line 107

That raises two questions:

1. Will phorum be updated for PHP 8.x?
2. Should we move this discussion to the main 5.2 support forum?

Cheers