Firefox PHP

Help needed with a complicated mod!

Posted by Mandingo 
Re: Help needed with a complicated mod!
July 13, 2004 04:56PM
You know, I always meant to allow users to subscribe to threads without replying. It just never got put in the code... or did it and we don't have a link....

Brian - Cowboy Ninja Coder - Personal Blog - Twitter
Re: Help needed with a complicated mod!
July 13, 2004 05:01PM
Hmm..that's interesting Brian!
Re: Help needed with a complicated mod!
July 13, 2004 06:52PM
Yes for email-notifications, not for bookmarking.


Thomas Seifert
Phorum Development Team / Mysnip-Solutions.de
Custom Phorum and general software development
worry-free Phorum Hosting
Re: Help needed with a complicated mod!
July 13, 2004 07:32PM
But it would effectively have the same function as bookmarking if there was such an option within subscriptions, wouldn't it?
Re: Help needed with a complicated mod!
July 13, 2004 09:03PM
Well, a user can view their subscribed threads list and use that for bookmarks I guess. That list is available in the CC already.

Brian - Cowboy Ninja Coder - Personal Blog - Twitter
Re: Help needed with a complicated mod!
July 14, 2004 10:24AM
I hacked a bookmarking feature into the forum I run and the users really like it. It's a higher traffic forum in which subscribing to a thread has the potential of inundating you with email. I was able to use the subscription framework by introducing a new subscription type to pass into the phorum_user_subscribe function. Subscribed threads and bookmarked threads appear together in the control center. If you guys think it might be a useful feature, I could send you my code changes. (Unfortunately, I wasn't able to put it into a module.)
Re: Help needed with a complicated mod!
July 14, 2004 10:28AM
> Subscribed threads and bookmarked threads appear together in the control center.

Clearly separated to see which ones you subscribed and which ones you bookmarked?

> If you guys think it might be a useful feature, I could send you my code changes.

If you submit a patch just for this feature we could look at it for deciding if to include it.
Sounds like it doesn't need too many changes in the core-code.


Thomas Seifert
Phorum Development Team / Mysnip-Solutions.de
Custom Phorum and general software development
worry-free Phorum Hosting
Re: Help needed with a complicated mod!
July 14, 2004 01:52PM
ts77 Wrote:
-------------------------------------------------------
> > Subscribed threads and bookmarked threads
> appear together in the control center.
>
> Clearly separated to see which ones you subscribed
> and which ones you bookmarked?

At the moment, it's all displayed in the same table. Instead of saying "unsubscribe", the bookmarked threads say "unbookmark".

> > If you guys think it might be a useful
> feature, I could send you my code changes.
>
> If you submit a patch just for this feature we
> could look at it for deciding if to include it.
> Sounds like it doesn't need too many changes in
> the core-code.

Thanks, I'll do that. I wasn't able to find anything in the docs directory about submitting patches... is it as simple as "cvs diff > my.patch"? Where should I submit it? (Sorry if this is documented somewhere...)
Re: Help needed with a complicated mod!
July 14, 2004 02:26PM
> is it as simple as "cvs diff > my.patch"

yeah, if you did use the cvs-version and have a checkout which you edit for that :).

Just send it to my email-address, I'll look through it.


Thomas Seifert
Phorum Development Team / Mysnip-Solutions.de
Custom Phorum and general software development
worry-free Phorum Hosting
Re: Help needed with a complicated mod!
July 19, 2004 07:37AM
So, you can have a look at the test forum.

[dev.phorum.org]

I have just commited my changes to the patch submitted by arlo. I merged Bookmarked threads and Subscribed threads into one thing called Followed Threads.

Brian - Cowboy Ninja Coder - Personal Blog - Twitter



Edited 1 time(s). Last edit at 07/19/2004 07:38AM by brianlmoon.
Sorry, only registered users may post in this forum.

Click here to login