Tree lines like Phorum 3 module!

I don't even know how I got those gaps. The Phorum I had installed I had screwed up in more than one way, so when I re-installed it, the errors were fixed, and the gaps were gone. How did you get gaps, and what did you do to fix them?

Why would you want regular alternating-color rows? It looks very confusing with them, and it's hard to distinguish one topic from another. Maybe you could make a module or hack that alternates the colors only for the replies, and a set color for the topics.

-------------------------------------------

"Everything we see or seem, is but a dream within a dream." -Edgar Allan Poe

Just change the template to alternate between rows instead of when the thread changes.

Brian - Cowboy Ninja Coder - Personal Blog - Twitter

@ Brian:

Thank you very much again. Your hint helped to solve my problem. I'm not very familiar with PHP-coding, so I did not expect that it would be so easy.

@ portal of curiousity:

I do not let borders being displayed between my table rows. I don't know your website. Are borders between your table rows being displayed? If yes then you will never see the gaps which I ment.

Why I do want alternating colours for every line? I think this is a question of favour. I like it best. Feel free to see my screenshot attached.



Edited 3 time(s). Last edit at 09/23/2004 11:51AM by D-rex.

portal of curiousity Wrote:
-------------------------------------------------------
> How did you get
> gaps, and what did you do to fix them?


I got them by starting with the default css. I was not able to close the gaps
completely by altering the border and padding values for TableRow and TableRowAlt
in css.tpl.

My way to fix them is based on the code of Phorum 3, where the tree-images of each
row are being embedded within their own small additional table. If anybody knows a
more simple way to fix the tiny little gaps, please let us know!

Here is my solution:


GAP FIX FOR TREEVIEW

-------------------------------------------------------------------------------------
css.tpl

-> FOR .PhorumTableRow AND.PhorumTableRowAlt


DELETE: height: 35px; padding: 3px; all border-bottom-x;

ADD: height: 21px; padding-bottom: 0px; padding-top: 0px; padding-left: 3px;
ADD: padding-right: 3px; border-top-width: 0px; border-bottom-width: 0px;

-> FOR img

DELETE: vertical-align: middle;

--------------------------------------------------------------------------------------
list_threads.tpl

ADD <table cellspacing="0" cellpadding="0" border="0><tr><td>
between <td class="PhorumTableRow<?php echo $rclass;?>">
and {ROWS->indent}


ADD </td></tr></table></td>
between {ROWS->new}</span>
and {IF VIEWCOUNT_COLUMN}

--------------------------------------------------------------------------------------
read_threads.tpl

ADD <table cellspacing="0" cellpadding="0" border="0><tr><td>
between <td class="PhorumTableRow<?php echo $rclass;?>">
and {MESSAGES->indent}


ADD </td></tr></table></td>
between ({LANG->UnapprovedMessage}){/IF}
and {IF VIEWCOUNT_COLUMN}


--------------------------------------------------------------------------------------
treeview.php

ADD </td><td>-tags at the end of each img src - definition.


For example:

$t_gif="<img src=\"images/t.gif\" width=\"12\" height=\"21\" border=\"0\"></td><td>";

--------------------------------------------------------------------------------------

Man, you can give some headaches.

First of all, thank you very much for the module.

The second thing is, if you want to remove the gaps between the the images, REMOVE ALL '&nbsp;' IN treeview.php.

I needed probably 3 hours to figure this out. I would recommend to change that.

Best wishes,
Alex

There is no "top and bottom padding":

Using Phorum 5.0.12

.PhorumTableRow
{
background-color: {backcolor};
border-bottom-style: solid;
border-bottom-color: {listlinecolor};
border-bottom-width: 1px;
color: {defaulttextcolor};
font-size: {defaultfontsize};
font-family: {defaultfont};
height: 35px;
padding: 3px;


If padding is set to 0, there are still big gaps between each row and the gif line images don't touch as they should.

Patrick Wrote:
-------------------------------------------------------
> There is no "top and bottom padding":
>

>         height: 35px; 
>         padding: 3px;

>
> If padding is set to 0, there are still big gaps
> between each row and the gif line images don't
> touch as they should.

try to make height smaller too...?


---
-=[ Panu ]=-

Patrick Wrote:
[...]
> If padding is set to 0, there are still big gaps
> between each row and the gif line images don't
> touch as they should.

I finally succeeded removing the last gaps with adding
20c20
< <table class="PhorumStdTable" cellspacing="0">
---
> <table class="PhorumStdTable" cellspacing="0" cellpadding="0">

in the templates/default/list_thread.tpl file

Hi,

sorry, I was just downloading the treeview.zip and I see here, that I must update so many things and tags. Or is the treeview.php the right one version which need not to be updated? Thank you. :-)

Hi Brian,

brianlmoon Wrote:
> this is a very highly requested feature for Phorum
> 5.

Yes, and this is why phorum have become so famous. You have such a great overview whats going on in a discussion and so on. And now with phorum5, I do not see any thread-trees.


> I originally thought I would have to make a
> hacked template to do it. But, thanks to our
> awesome module system, here it is. No recursion
> either so it is a lot faster than I thought it
> would have been.

yep.

> A couple of things may have to be done for this to
> work.

I was just downloading your treeview.zip. I did all what you said here.

>
> 1) Required: Move the images in the images dir in
> this zip file to the main Phorum images dir.

= OK

>
> 2) You will have to edit the CSS for
> PhorumTableRow. The top and bottom padding will
> have to be removed.

= OK

> 3) If black images will not work well on your
> site, there are white versions in the images dir.
> You will need to either rename them or change the
> html img tag defs at the top of the mod_treeview
> function.

= OK

> That should do it. There is a chance that mods
> will never see the tree in a pretty way due to the
> moderation links under the datestamp.
>

The Phorum Module Settings allows me to switch on/off this treeview-module.

/forum/admin.php?module=mods

List Page Tree View
Displays threaded list view with the tree lines like Phorum 3
[Off] [On]

Of course, I switched on this module, but I still cannot see any trees.

What do I wrong? I also had a look in the database, it works very fine. But nothing happen.

Thank you.