Message icons module

I uploaded a new release of the message_icons module. You can find it in the first posting of this thread.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce

Hello Maurice,

Your icons mod is great.
Can you add an icon for deplaced thread (sujet déplacé) ?

French file for your mod isn't terminated. Should i fill it and send you the translated file in french ?

Please do so. If you place the translation in this thread, I'll add it to the package.

I'll see what I can do for moved threads. Shouldn't be too hard.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce

Cool. :)

I've attached french file.

Maurice: and I have detached it, since it's now in the distribution. Thanks.



Edited 1 time(s). Last edit at 09/01/2006 06:39AM by mmakaay.

Hello Maurice,

I have a problem with icons module.
With my phorum i see this text in the title of my read page : <img src="./mods/message_icons/annoucement.gif" ...

I should see only the subject of the thread and not the html text for icons.

How can i solve this problem ?

Thanks

I changed "Discussion close" to "Discussion fermée". I think that is the correct French wording. Most French I know hate to use English words in their forums ;-)

About the title problem: I cannot reproduce that on my development server (see the link below). This is the most current Phorum 5.1 with this module installed. Can you reproduce the problem on this Phorum?

Phorum 5.1 development server.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce

Oups i forgot to translate close. ;)

About the problem i put on my header the code from Brian :
[www.phorum.org]

I have :
$TITLE = htmlspecialchars($PHORUM["DATA"]["MESSAGE"]["subject"]);

I've used $TITLE variable for my title read page.
So you have <img src="..... before the real title. :(

I add a strip_tags on the title but it's not very good for title with "<" or others special characters.

For the french translation :
I suggest to change "Message" by "Discussion".
Message in french is for a post.


PS : In french we also say "close". It means "fermé".
It comes from "Clôturer" verbe.
ex:
"La discussion est close."
"Les débats sont clos."

If you want to add moved icon in the module you should change :

if ($args[$id]["sort"] == PHORUM_SORT_ANNOUNCEMENT) {
$marker = "announcement";
} elseif ($args[$id]["sort"] == PHORUM_SORT_STICKY) {
$marker = "sticky";
} elseif ($args[$id]["closed"] || (isset($PHORUM["DATA"]["OPTION_ALLOWED"]["allow_reply"]) && !$PHORUM["DATA"]["OPTION_ALLOWED"]["allow_reply"])) {
$marker = "closed";
} elseif ($args[$id]["moved"]) {
$marker = "moved";
} else {
$marker = "message";
}
$args[$id]["meta"]["mod_message_icons"]["marker"] = $marker;
}

return $args;



I also moved sticky code to the top because if you have a sticky without allowed answer, the icons module add a closed icon and not a sticky icon.

Quote

I suggest to change "Message" by "Discussion".
Message in french is for a post.

Better not do that, since the message icon will also be added in threaded view. Then it really is a message and not a discussion.

Quote

PS : In french we also say "close". It means "fermé".
It comes from "Clôturer" verbe.

Vraiment, mais j'ais vu que "fermée" est utilisé dans la fichier "francais.php".
(don't know if that was right, but it sure looks like French to me ;-)

Quote

} elseif ($args[$id]["moved"]) {

I added this, with an additional check to see if "moved" is set in the array (this is not always the case, which would cause undefined index warnings). I took the standard message icon and have drawn a kind of arrow on it. That's the new icon moved.gif for this feature.

I moved sticky up the list too, so now it's in sync with the way in which announcements are handled.

I'll upload the new "momo release" (1.0.4) to the start of this thread.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce