Javascript Forum Menu Module
Posted by Joe Curia
|
February 21, 2007 10:30PM |
|
February 22, 2007 04:54AM |
This sounds like something that I wanted to add to the forum jumpmenu. On my site, I'm not using it, because of the MSIE bug which causes select boxes to always be drawn on top of everything. Since my site uses CSS drop down menu's, they would fall behind the select list :-( I'll check it out. Maybe I can use this one instead now. Thanks.
Edit:
BTW, I see this in the dropdown javascript code:
Are you sure you're allowed to ship the code with the module?
Edit:
I attached the Dutch translation for the mod.
Attachment is removed from this post. It's now part of the mod
Edit:
There's some stale code in the module:
Maurice Makaay
Phorum Development Team
my blog 
linkedin profile 
secret sauce
Edited 6 time(s). Last edit at 02/28/2007 05:02PM by mmakaay.
Edit:
BTW, I see this in the dropdown javascript code:
// YOU MAY NOT // (1) Remove or modify this copyright notice. // (2) Distribute this code, any part or any modified version of it. // Instead, you can link to the homepage of this code: // [www.php-development.ru].
Are you sure you're allowed to ship the code with the module?
Edit:
I attached the Dutch translation for the mod.
Attachment is removed from this post. It's now part of the mod
Edit:
There's some stale code in the module:
$headtags = array();
$headtags = $PHORUM["DATA"]["HEAD_TAGS"];
Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauceEdited 6 time(s). Last edit at 02/28/2007 05:02PM by mmakaay.
|
February 22, 2007 09:38AM |
|
February 22, 2007 10:33AM |
Yes, you can remove the first line. As soon as you assign a new value to a PHP variable, the old one's data is lost. The first array will be created in the first line and deleted in the second line. It's safe to drop it.
I found the license a bit hard to understand, because it sounded ambiguous. If you're not allowed for some reason to use the library, then we could also use some code from the editor tools module for creating the popup. Probably not needed, but keep it in mind.
Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce
I found the license a bit hard to understand, because it sounded ambiguous. If you're not allowed for some reason to use the library, then we could also use some code from the editor tools module for creating the popup. Probably not needed, but keep it in mind.
Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce
|
February 22, 2007 12:04PM |
|
February 22, 2007 12:31PM |
Quote
If there are any other locations where you would like the menu to be able to appear, please let me know and I will try to incorporate them.
An idea: to be ultimately flexible, you could also allow for using an admin defined object id name to associate the menu with. So you can have some default options and one custom option, for which the admin can provide an id name. This can be put in a drop down menu, which shows all hard-coded options and one custom id option. Using some javascript, you can arrange for an extra form field for entering the object id to be displayed if the custom id option is selected.
I am working on some changes for the In Body Attachments module, where I present different "subforms" in the module settings, based on the selection in a drop down list. If you want to implement this and want a bit of example code, then let me know. I'll send you the settings.php example.
Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce
|
February 22, 2007 12:37PM |
|
February 22, 2007 02:24PM |
Download the latest in body attachment module that you can find in my package archive. Look at the bottom of the settings.php for an example.
Another idea:
For the custom location, wouldn't it be easiest to not add anything to the output from the module? You can let the admin modify the template for it. AFAICS, all the admin would have to do to make it work is add an id="menu_parent" to the item in the page that has to be the menu parent. For me that would be all I'd need.
Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce
Another idea:
For the custom location, wouldn't it be easiest to not add anything to the output from the module? You can let the admin modify the template for it. AFAICS, all the admin would have to do to make it work is add an id="menu_parent" to the item in the page that has to be the menu parent. For me that would be all I'd need.
Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce
|
February 22, 2007 08:37PM |
Quote
As always, requests for added/improved features are welcome, either email or post here (email included in readme).
No problem ;-) I uploaded a new version of the mod to the first message in this thread (version 1.02). There's quite a list of changes in there. See the readme.txt for the exact changelog. I also added some points to the todo's.
For custom placement, I added a Custom option and a help text to the settings menu. IMO that is enough for allowing customized menu placement. I have used that to get the menu going on my website. The default options resulted in some weird problems because of the structure of my site. But with the new Custom option, I simply appointed the right id to one of the elements on my page and that was enough to get things going.
Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce
|
February 23, 2007 12:40AM |
Sorry, only registered users may post in this forum.