Topic Poll Module
Posted by Maurice Makaay
Re: Topic Poll Module (only for Phorum 5.1.16 and higher) July 20, 2007 04:19AM |
Registered: 21 years ago Posts: 174 |
July 20, 2007 04:25AM |
Admin Registered: 20 years ago Posts: 8,532 |
So you are really using Phorum 5.1.23 and poll module 1.0.7? That is the combination that you should use, because these are compatible. Other combinations might not work because of the internal changes.
Maurice Makaay
Phorum Development Team
my blog
linkedin profile
secret sauce
Maurice Makaay
Phorum Development Team



July 20, 2007 10:30AM |
Registered: 21 years ago Posts: 687 |
Wow, this module has really been improved since when I first ran it on Phorum 3.x!
Has anybody experienced the following problem?
Once a poll is created, it correctly renders in my message body and allows people to vote, but a new message appears below it, with empty "array" options, as if it is trying to render again, but does not have the correct template files.
I am running latest versions of both the module and Phorum.
UDDATE: Oops, scrap everything I've said! I was *still* running the old version of the mod that didn't work - I didn't notice as the name had changed <blush!>
Thanks,
/\dam
--
My notable Phorum sites:
Movie Deaths Database - "review comments" system mostly powered by Phorum
Learn Chinese! - integrated forum quiz
Edited 2 time(s). Last edit at 07/20/2007 10:32AM by sheik.
Once a poll is created, it correctly renders in my message body and allows people to vote, but a new message appears below it, with empty "array" options, as if it is trying to render again, but does not have the correct template files.
I am running latest versions of both the module and Phorum.
UDDATE: Oops, scrap everything I've said! I was *still* running the old version of the mod that didn't work - I didn't notice as the name had changed <blush!>
Thanks,
/\dam
--
My notable Phorum sites:
Movie Deaths Database - "review comments" system mostly powered by Phorum
Learn Chinese! - integrated forum quiz

Edited 2 time(s). Last edit at 07/20/2007 10:32AM by sheik.
July 20, 2007 10:37AM |
Admin Registered: 20 years ago Posts: 8,532 |
This module does not have anythting to do with other modules. This module is a full rewrite (or "write" as I never wrote a poll module before) and not based on other code. I'd really love to see how you would run this on Phorum 3 ;-)
Maurice Makaay
Phorum Development Team
my blog
linkedin profile
secret sauce
Maurice Makaay
Phorum Development Team



Re: Topic Poll Module (only for Phorum 5.1.16 and higher) July 20, 2007 12:39PM |
Registered: 21 years ago Posts: 174 |
Quote
mmakaay
So you are really using Phorum 5.1.23 and poll module 1.0.7? That is the combination that you should use, because these are compatible. Other combinations might not work because of the internal changes.
You were right, I was using 5.1.20 and I didn't notice that the only version that I should use was .23, I'm sorry about that, I usually take care about this kind of things, I think I was confused by the readme of the other poll module
Thanks!
July 20, 2007 07:11PM |
Admin Registered: 20 years ago Posts: 8,532 |
No problem. I'm simply really happy that it's not some weird bug that caused the problems for you ;-)
Maurice Makaay
Phorum Development Team
my blog
linkedin profile
secret sauce
Maurice Makaay
Phorum Development Team



July 21, 2007 03:38AM |
Registered: 21 years ago Posts: 687 |
> This module does not have anything to do with other modules.
I realise that now - but if you look at my edited post, you'll see I thought it was an update of an older module :-)
I especially like the template previews in the settings by the way - very cool.
/\dam
--
My notable Phorum sites:
Movie Deaths Database - "review comments" system mostly powered by Phorum
Learn Chinese! - integrated forum quiz
I realise that now - but if you look at my edited post, you'll see I thought it was an update of an older module :-)
I especially like the template previews in the settings by the way - very cool.
/\dam
--
My notable Phorum sites:
Movie Deaths Database - "review comments" system mostly powered by Phorum
Learn Chinese! - integrated forum quiz

Re: Topic Poll Module July 21, 2007 01:30PM |
Registered: 21 years ago Posts: 174 |
graphic design question
I implemented the module in one of my websites.
I would like to remove the line that appears when showing the results (before or after the message body). I tried to track in the code where is that printed but couldn't find it.
Where is this separator line coded so I can remove it?
Thanks!
I implemented the module in one of my websites.
I would like to remove the line that appears when showing the results (before or after the message body). I tried to track in the code where is that printed but couldn't find it.
Where is this separator line coded so I can remove it?
Thanks!
July 21, 2007 06:21PM |
Admin Registered: 20 years ago Posts: 8,532 |
It's in the module script topic_poll.php. This code is not in the templates. For a next version, I might incorporate this in a template. For the current release, you'll have to hack topic_poll.php. Find the function function phorum_mod_topic_poll_format(). In that function you will find the code for the <hr> separator.
Maurice Makaay
Phorum Development Team
my blog
linkedin profile
secret sauce
Maurice Makaay
Phorum Development Team



Re: Topic Poll Module July 22, 2007 07:18AM |
Registered: 21 years ago Posts: 174 |
yeah you are right, I did a search for <hr> tag and it appears as <hr size="0"/>, that's why I couldn't find it.
little suggestion: possibility of changing the graphical tag for a text tag, something like [poll] message body. I already hacked it myself but maybe its useful for more people.
thanks!
little suggestion: possibility of changing the graphical tag for a text tag, something like [poll] message body. I already hacked it myself but maybe its useful for more people.
thanks!
Sorry, only registered users may post in this forum.