Firefox PHP

Topic Poll Module

Posted by Maurice Makaay 
Re: Topic Poll Module (only for Phorum 5.1.16 and higher)
June 19, 2007 11:07PM
Hello Maurice,

Thanks a lot, I just tested it and it works fine.
Thanks Fran for the translation, you were faster than me :-)

While we are at it, what would you think of this new "feature":
at the moment, the admin can decide if all users or only registered can create a poll. However, the user which create the poll can decide if all users or only registered can vote. Could this be enforced by the admin?
Either by putting this as an option in the admin:
* Who is allowed to vote on a poll in this forum?
1. All users
2. registered users
3. the poll creator decides
Or by associating this with the question "Who are allowed to create polls in this forum?".

Also, should the question "Who are allowed to create polls in this forum?" be "Who is allowed to create polls in this forum?"

Thanks a lot, Maurice!
Yann

Cactus : [www.cactuspro.com]
Re: Topic Poll Module (only for Phorum 5.1.16 and higher)
June 20, 2007 12:57AM
An association with the creation permissions seems the wrong solution to me. I'd go for the options in the admin configuration. I'll have to look into that, but it doesn't sound too difficult to me.

"Who are" vs. "Who is": I'll need some input from a native English speaker for that. In Dutch, "Who is" suggests that only one user would be allowed to create polls.


Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce
Re: Topic Poll Module (only for Phorum 5.1.16 and higher)
June 20, 2007 01:06AM
Quote
mmakaay
"Who are" vs. "Who is": I'll need some input from a native English speaker for that. In Dutch, "Who is" suggests that only one user would be allowed to create polls.

In Proper English, "Who ARE" is plural, "Those who are allowed" and "Who IS" is singular, "One who is allowed." however, people do take liberties with the written word...

so I believe "who ARE" is correct in this context, but people are used to japanenglish translations of websites and technical manuals, sometimes get used to seeing things wrong.
Re: Topic Poll Module (only for Phorum 5.1.16 and higher)
June 20, 2007 08:59AM
Hi Maurice,

Do not take my word for English remarks, I am not an English native speaker :) (However you can ask me anything in French).

Here's another wish :)
Having the possibility to select several answers.
Here's an example:
Question : Where have you been to?
[ ] Europe
[ ] North America
[ ] South America
[ ] Africa
[ ] Asia
etc...
However, the results would have to be calculated differently. At the moment, the total of percentages equals 100% (for one only choice possible). Here, for each question the percentage shown would have to be the percentage of people who chose this answer.

Does it sound interesting (and feasible)?

Cheers
Yann

Cactus : [www.cactuspro.com]
Re: Topic Poll Module (only for Phorum 5.1.16 and higher)
June 20, 2007 09:46AM
That is a request that was done by my own user base as well and I have that option on my todo list. It's a rather large feature, so don't expect anything really soon here, but I guess that after development of Phorum 5.2 calms down (that's where most of my coding time is spent currently), there will be an update to support this feature.


Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce
Re: Topic Poll Module (only for Phorum 5.1.16 and higher)
June 23, 2007 03:02PM
Hi,

In the French translation file, the alt and title tags have not been translated, "Poll" should be replace by "Sondage". That's for those 2 variables:
OldPollSubjectTag
NewPollSubjectTag

Thanks,
Yann

Cactus : [www.cactuspro.com]
Re: Topic Poll Module (only for Phorum 5.1.16 and higher)
July 13, 2007 06:53PM
I have a new installation of Phorum (v 5.1.23) to which I added Topic Poll. The installation from admin worked perfectly. The button to add a poll is available and the poll page comes up when clicked. However, "Add Extra Answer" returns me to the edit post page and, when I try to add the poll "Save and go back...", it returns with message telling me to save the message to save poll. Upon saving and returning to thread, the poll does not appear in the post. I see no indication anywhere in the data tables that the poll was saved.

Did I do something wrong?
Re: Topic Poll Module (only for Phorum 5.1.16 and higher)
July 13, 2007 09:30PM
I can replicate that behavior on my own server, so it's not something that you have done wrong. I'm going to look into it right now and find out what's going wrong here.


Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce
Re: Topic Poll Module (only for Phorum 5.1.16 and higher)
July 13, 2007 09:51PM
The topic poll module was incompatibel with Phorum 5.1.23. You can do the required update yourself or download version 1.0.7 once I have uploaded it to the starting message of this thread. The required change that has to be done is in the file mods/topic_poll/topic_poll.php:
226        // The changed meta data must be stored in $_POST, so it will
227        // be put in the form. Also sign it, to make Phorum accept it.
228        $meta = serialize($message["meta"]);
229        $_POST["meta"] = $meta;
230        $_POST["meta:signature"] = phorum_generate_data_signature($meta);
Change that code to:
226        // The changed meta data must be stored in $_POST, so it will
227        // be put in the form. Also sign it, to make Phorum accept it.
228        $meta = base64_encode(serialize($message["meta"]));
229        $_POST["meta"] = $meta;
230        $_POST["meta:signature"] = phorum_generate_data_signature($meta);
I think that this change will get the Topic Poll working for you like it should. Thanks for reporting the problem!


Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce
Re: Topic Poll Module (only for Phorum 5.1.16 and higher)
July 13, 2007 11:07PM
Maurice:

That did the trick! Thanks!

Tom
Sorry, only registered users may post in this forum.

Click here to login