Firefox PHP

Fixes for PHP 7/8

Posted by Sergei K 
All files from this thread

File Name File Size   Posted by Date  
PHP_7_8_compatibility_fixes_s2k0z.pdf 394.9 KB open | download Scott Finegan 12/03/2022 Read message
2022-12-04 16_15_21-sk757a_phorum - phorum - Codeberg.org – Chromium.png 12.6 KB open | download Sergei K 12/04/2022 Read message
Fixes for PHP 7/8
August 12, 2021 12:49AM
If someone is interested in the work of Phorum with PHP 7/8 you can try the version with my fixes which you can download at [github.com]



Edited 1 time(s). Last edit at 08/13/2021 03:22PM by Sergei K.
Re: Fixes for PHP 7/8
October 28, 2021 06:00PM
In local it's good with php 7,4 . Modules for 7,2 no
Re: Fixes for PHP 7/8
January 28, 2022 01:23PM
How long did it take you to fix the code ? hours ? days ? 1 week ?

is there some generic changes to do, or has it be a step by step (after seing errors).

I'm asking because i need to move, but i have a specific release of 5.2.19 (with 20 mods) and i guess, i would be quicker to update the code directly, without even going 5.2.23 before (as there won't be any official future release; otherwise, i would move to the last release).

Thanks
Re: Fixes for PHP 7/8
January 29, 2022 06:18AM
I tried to run on the new version of PHP, collected the errors that occurred. Then I fixed them consistently. Both where errors occur and sometimes other places that are searched through files. After the changes, I tested a little creating a new installation and publishing messages. It took me a few hours throughout the day.
Re: Fixes for PHP 7/8
January 31, 2022 08:01AM
Thanks Sergei, it helps
Re: Fixes for PHP 7/8
January 31, 2022 01:21PM
Sergei,
Thank you for your work. I manage a phorum installation that's used a fair bit, and am nervous about upgrading, but also hate the errors that a slightly modified Phorum 5.2.23 generates with PHP7. Would you be willing to help me benefit from your experience? mpotts@mcn.org
Re: Fixes for PHP 7/8
February 01, 2022 03:01AM
Hello Michael,
I replied to you in email.
Re: Fixes for PHP 7/8
March 14, 2022 05:29PM
@Sergei K

I'm so grateful for the work you did. I was able to get this version installed. However, it did not fix my issue. It did move it, though. ;)

I'm still getting no results if I search for someting. And I get errors like this on the top of the screen (I've taken out my home directory):

Warning: count(): Parameter must be an array or an object that implements Countable in /include/forum_functions.php on line 71

Warning: count(): Parameter must be an array or an object that implements Countable in /include/forum_functions.php on line 71

Warning: Cannot modify header information - headers already sent by (output started at /include/forum_functions.php:71) in /.cache/tpl-lightweight_blue-header-4078174761e651367bdf29ce021b700b.php-stage2 on line 4

Warning: Cannot modify header information - headers already sent by (output started at /include/forum_functions.php:71) in .cache/tpl-lightweight_blue-header-4078174761e651367bdf29ce021b700b.php-stage2 on line 6
Re: Fixes for PHP 7/8
March 19, 2022 09:05AM
Hello Preston

Glad to hear that my efforts aren't completely lost. It's not an easy time for me (and for all of us) and I'll need some time to dive into php specifics, but I'll fix the problem. There are signs of activity in the github repository and may even be able to implement a maintenance release. Personally, I want that.
Re: Fixes for PHP 7/8
November 29, 2022 03:55PM
Quote
Sergei K
you can download at [github.com]

Sergei, the github link is down, and the git account seems to be 404'ing. Is there any chance you could re-upload this somewhere, please? Php8.0 has killed my phorum admin section.

Thank you
Re: Fixes for PHP 7/8
December 01, 2022 03:16AM
I'm in the same boat, updating to PHP 8 breaks my Phorum (both normal and admin) and it would be really nice to get those fixes to see if I can keep it running.
Re: Fixes for PHP 7/8
December 01, 2022 02:02PM
Hello people. When I started doing this, I thought that there would be at least one person who would really need it. Who not only wants to get a new release, but is ready to help with testing. I can write code, but I can't fully test it myself because I've never used phorum. My fixes, although they work, most likely do not cover all cases. Especially in plugin code. If any of you are willing to help in this way, please let me know.
Re: Fixes for PHP 7/8
December 02, 2022 10:01AM
The file I downloaded and saved last year was created Aug. 13 of 2021

available here -> [www.phorum.org]
Re: Fixes for PHP 7/8
December 03, 2022 07:28PM
@Scott Finegan: Thanks, I took a look at that file, but it appears wildly different to the last official version 5.2.23. I had expected it to be much more similar to that one (only fairly small changes to fix errors with newer PHP versions).

@Sergei K: Which version did you start out with when you made fixes to make it compatible with newer PHP versions?
Re: Fixes for PHP 7/8
December 03, 2022 11:45PM
This is the file that was on GitHub when I downloaded it.
It appears to be Phorum Core
I took a brief look at that time.

Attached is a print to pdf of the visible parts of the diff page (overflow not included).

Sorry, I didn't expect to be sharing it, however it does give the line #s changed, and examples of how the code needs to be modified to work.
Attachments:
open | download - PHP_7_8_compatibility_fixes_s2k0z.pdf (394.9 KB)
Re: Fixes for PHP 7/8
December 04, 2022 06:14AM
Download archive

View changes



Edited 1 time(s). Last edit at 12/04/2022 06:23AM by Sergei K.
Re: Fixes for PHP 7/8
December 04, 2022 06:19AM
Master branch on GitHub


Re: Fixes for PHP 7/8
December 14, 2022 07:30AM
I decided to give up and instead I migrated my Phorum to SMF, which is actively maintained. They have a fairly good converting tool, and there wasn't much cleanup needed afterwards. One thing the converter failed to migrate was PMs, possibly because my Phorum was not at the latest version. The PM format in my DB was not what the converter expected, but the amount of PMs was so low that I decided to just skip it.

One caveat is that the converter tool only works with SMF version 2.0.19, so I had to install that version to do the migration, and then I could upgrade SMF to the latest afterwards. All running smoothly now.

It was a good run with Phorum while it lasted, though!
Re: Fixes for PHP 7/8
December 14, 2022 11:07AM
Unfortunately, migration is the only viable option in this situation.
Re: Fixes for PHP 7/8
May 15, 2023 02:24AM
@Scott Finnegan
Unfortunately I have this message after the check (it is OK) :
Fatal error: Uncaught mysqli_sql_exception: Nom du champ 'cache_version' déjà utilisé in .....\Forum\include\db\PhorumMysqlDB\mysqli.php on line 209
Re: Fixes for PHP 7/8
May 15, 2023 08:34AM
Translated error msg.

Quote

Field name 'cache_version' already used in .....\Forum\include\db\PhorumMysqlDB\mysqli.php on line 209
Re: Fixes for PHP 7/8
May 16, 2023 01:02AM
And now ? How to resolve the issue ? :)
Re: Fixes for PHP 7/8
May 16, 2023 09:35AM
Not that simple.

What version of Phorum?
What version of php?
What version of MySQL ?
Running on Linux or Windows?

Where is the "cache directory", and do you have permissions?

Temporarily disable all Modules not absolutely needed for reading the Forum.
Test again. If it works enable modules one at a time, and test.


Even though the fatal error is shown in mysqli.php, the problem may be in another file, or with permissions.

Where is the error shown? -> Phorum error log?, on the screen? or one of the below.
php error log, mysql error log. If they are not enabled, enable them.
Re: Fixes for PHP 7/8
May 17, 2023 02:29AM
Thank you for your prompt response
my English is poor and I prefer explain in a file my problems step by step...
https://www.sapbm.com/upgrade_english.pdf



Edited 2 time(s). Last edit at 05/17/2023 02:33AM by tellioub.
Sorry, only registered users may post in this forum.

Click here to login