moderation.php doesn't work

Hi!

For some weeks i'm having a problem with moderation.

I can't:

- MOVE / DELETE / EDIT threads
- DELETE / EDIT posts

The only thing i can do is HIDE threads/posts. It always worked perfect for me as an admin, and for the users, the EDIT mode was set to 5min.

Here is the moderation.php code. If something is wrong, please let me know, it suddenly stopped working.... Thanks!

<?php

////////////////////////////////////////////////////////////////////////////////
// //
// Copyright (C) 2003 Phorum Development Team //
// [www.phorum.org] //
// //
// This program is free software. You can redistribute it and/or modify //
// it under the terms of either the current Phorum License (viewable at //
// phorum.org) or the Phorum License that was distributed with this file //
// //
// This program is distributed in the hope that it will be useful, //
// but WITHOUT ANY WARRANTY, without even the implied warranty of //
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. //
// //
// You should have received a copy of the Phorum License //
// along with this program. //
////////////////////////////////////////////////////////////////////////////////
define('phorum_page','moderation');

include_once("./common.php");
include_once("./include/moderation_functions.php");
include_once("./include/thread_info.php");
include_once("./include/email_functions.php");

if(!phorum_check_read_common()) {
return;
}

$PHORUM["DATA"]["MODERATOR"] = phorum_user_access_allowed(PHORUM_USER_ALLOW_MODERATE_MESSAGES);

$msgthd_id = (isset($_POST["thread"])) ? (int)$_POST["thread"] : (int)$PHORUM['args'][2];

$mod_step = (isset($_POST["mod_step"])) ? (int)$_POST["mod_step"] : (int)$PHORUM['args'][1];

if(empty($msgthd_id) || !phorum_user_access_allowed(PHORUM_USER_ALLOW_MODERATE_MESSAGES)) {
phorum_return_to_list();
}

$template="message";
// set all our URL's
phorum_build_common_urls();


// a hook for doing stuff in moderation, i.e. logging moderator-actions
phorum_hook("moderation",$mod_step);


switch ($mod_step) {

case PHORUM_DELETE_MESSAGE: // this is a message delete

// check that they're an admin if they want to delete an announcement
$message = phorum_db_get_message($msgthd_id);
if ($message["sort"] == PHORUM_SORT_ANNOUNCEMENT && !$PHORUM["user"]["admin"]){
$PHORUM['DATA']['MESSAGE']=$PHORUM["DATA"]["LANG"]["DeleteAnnouncementForbidden"];
break;
}
if($PHORUM["user"]["admin"]){$msg_ids=phorum_db_delete_message($msgthd_id, PHORUM_DELETE_MESSAGE);}
else {
$msg_ids=phorum_db_delete_message($msgthd_id, PHORUM_DELETE_MESSAGE,1);
}
foreach($msg_ids as $id){
$files=phorum_db_get_message_file_list($id);
foreach($files as $file_id=>$data){
phorum_db_file_delete($file_id);
}
}
phorum_hook("delete", $msg_ids);
$nummsgs=count($msg_ids);
$PHORUM['DATA']['MESSAGE']=$nummsgs." ".$PHORUM["DATA"]['LANG']['MsgDeletedOk'];
if(isset($PHORUM['args']["prepost"])) {
$PHORUM['DATA']["URL"]["REDIRECT"]=phorum_get_url(PHORUM_CONTROLCENTER_URL,"panel=".PHORUM_CC_UNAPPROVED);
} else {
$PHORUM['DATA']["URL"]["REDIRECT"]=$PHORUM["DATA"]["URL"]["TOP"];
}
break;

case PHORUM_DELETE_TREE: // this is a message delete
// check that they're an admin if they want to delete an announcement
$message = phorum_db_get_message($msgthd_id);
if ($message["sort"] == PHORUM_SORT_ANNOUNCEMENT && !$PHORUM["user"]["admin"]){
$PHORUM['DATA']['MESSAGE']=$PHORUM["DATA"]["LANG"]["DeleteAnnouncementForbidden"];
break;
}
if($PHORUM["user"]["admin"]){$msg_ids=phorum_db_delete_message($msgthd_id, PHORUM_DELETE_TREE);}
else {
$msg_ids=phorum_db_delete_message($msgthd_id, PHORUM_DELETE_TREE,1);
}

foreach($msg_ids as $id){
$files=phorum_db_get_message_file_list($id);
foreach($files as $file_id=>$data){
phorum_db_file_delete($file_id);
}
}
phorum_hook("delete", $msg_ids);
$nummsgs=count($msg_ids);
$PHORUM['DATA']['MESSAGE']=$nummsgs." ".$PHORUM["DATA"]["LANG"]['MsgDeletedOk'];
if(isset($PHORUM['args']["prepost"])) {
$PHORUM['DATA']["URL"]["REDIRECT"]=phorum_get_url(PHORUM_CONTROLCENTER_URL,"panel=".PHORUM_CC_UNAPPROVED);
} else {
$PHORUM['DATA']["URL"]["REDIRECT"]=$PHORUM["DATA"]["URL"]["TOP"];
}
break;

case PHORUM_MOVE_THREAD: // this is the first step of a message move

$PHORUM['DATA']['URL']["ACTION"]=phorum_get_url(PHORUM_MODERATION_ACTION_URL);
$PHORUM['DATA']["FORM"]["forum_id"]=$PHORUM["forum_id"];
$PHORUM['DATA']["FORM"]["thread_id"]=$msgthd_id;
$PHORUM['DATA']["FORM"]["mod_step"]=PHORUM_DO_THREAD_MOVE;

// get all the forums the moderator may move to
$PHORUM['DATA']["MoveForumsOption"]="";

$forums=phorum_db_get_forums();

foreach($forums as $id=>$forum){
if($forum["folder_flag"]==0 && phorum_user_moderate_allowed($id)){
$forum_data[strtolower($forum["name"])]=array("forum_id"=>$id, "name"=>$forum["name"]);
}
}

ksort($forum_data);

$PHORUM['DATA']['FRM']=1;
$PHORUM['DATA']['FORUMS']=$forum_data;
$output=true;

$template="move_form";

break;

case PHORUM_DO_THREAD_MOVE: // this is the last step of a message move

$PHORUM['DATA']['MESSAGE']=$PHORUM["DATA"]['LANG']['MsgMoveOk'];
$PHORUM['DATA']["URL"]["REDIRECT"]=$PHORUM["DATA"]["URL"]["TOP"];
phorum_db_move_thread($msgthd_id, $_POST['moveto']);
phorum_hook("move_thread", $msgthd_id);
break;

case PHORUM_CLOSE_THREAD: // we have to close a thread

$PHORUM['DATA']['MESSAGE']=$PHORUM["DATA"]['LANG']['ThreadClosedOk'];
$PHORUM['DATA']["URL"]["REDIRECT"]=$PHORUM["DATA"]["URL"]["TOP"];
phorum_db_close_thread($msgthd_id);
phorum_hook("close_thread", $msgthd_id);
break;

case PHORUM_REOPEN_THREAD: // we have to reopen a thread

$PHORUM['DATA']['MESSAGE']=$PHORUM["DATA"]['LANG']['ThreadReopenedOk'];
$PHORUM['DATA']["URL"]["REDIRECT"]=$PHORUM["DATA"]["URL"]["TOP"];
phorum_db_reopen_thread($msgthd_id);
phorum_hook("reopen_thread", $msgthd_id);
break;

case PHORUM_MOD_EDIT_POST: // moderator wants to edit a post

$message=phorum_db_get_message($msgthd_id);
$message['forum_id']=$PHORUM['forum_id'];

// expose the actual message fields
foreach($message as $key=>$value){
if(!is_array($value)){
$PHORUM["DATA"]["EDIT"][$key]=htmlspecialchars($value);
}
}

// expose the meta data that are scalar values
foreach($message["meta"] as $key=>$value){
if(!is_array($value)){
$PHORUM["DATA"]["EDIT"]["meta"][$key]=htmlspecialchars($value);
}
}

if(isset($message["meta"]["attachments"]) && is_array($message["meta"]["attachments"])){
foreach($message["meta"]["attachments"] as $file_data){
$PHORUM["DATA"]["EDIT"]["attachments"][]=array("file_id"=>$file_data["file_id"], "file_name"=>htmlspecialchars($file_data["name"]));
}
}

$PHORUM['DATA']['EDIT']['special']=$PHORUM['DATA']['EDIT']['sort'];
$PHORUM['DATA']['EDIT']['private']=$PHORUM['DATA']['EDIT']['private'];
$PHORUM['DATA']['EDIT']['show_announcement'] = $PHORUM["user"]["admin"];

if(isset($PHORUM['DATA']['EDIT']['user_id'])) {
$PHORUM['DATA']['EDIT']['emailreply']= phorum_db_get_if_subscribed($PHORUM['DATA']['EDIT']['forum_id'],$PHORUM['DATA']['EDIT']['thread'],$PHORUM['DATA']['EDIT']['user_id']);
}

$PHORUM['DATA']["EDIT"]["mod_step"]=PHORUM_SAVE_EDIT_POST;
$PHORUM['DATA']["URL"]["ACTION"]=phorum_get_url(PHORUM_MODERATION_ACTION_URL);

$PHORUM['DATA']["EDIT"]["useredit"]=false;
if ($PHORUM["DATA"]["EDIT"]["user_id"] > 0){
$PHORUM["DATA"]["EDIT"]["moderator_useredit"] = 1;
}
$PHORUM["DATA"]["EDIT"]["edit_allowed"] = 1;

$template="edit";

break;

case PHORUM_SAVE_EDIT_POST: // saving the edited post-data


phorum_handle_edit_message();


$PHORUM["DATA"]["URL"]["REDIRECT"] = phorum_get_url(PHORUM_READ_URL, $_POST['thread'], $_POST["message_id"]);
break;

case PHORUM_APPROVE_MESSAGE: // approving a message

$PHORUM['DATA']['MESSAGE']="1 ".$PHORUM["DATA"]['LANG']['MsgApprovedOk'];

$old_message = phorum_db_get_message($msgthd_id);
$newpost=array("status"=>PHORUM_STATUS_APPROVED);

// setting the new status
phorum_db_update_message($msgthd_id, $newpost);

// updating the thread-info
phorum_update_thread_info($old_message['thread']);

// updating the forum-stats
phorum_db_update_forum_stats(false, 1, $old_message["datestamp"]);

if($old_message['status'] != PHORUM_STATUS_HIDDEN ) {
phorum_email_notice($old_message);
}

if(isset($PHORUM['args']["prepost"])) {
$PHORUM['DATA']["URL"]["REDIRECT"]=phorum_get_url(PHORUM_CONTROLCENTER_URL,"panel=".PHORUM_CC_UNAPPROVED);
} else {
$PHORUM['DATA']["URL"]["REDIRECT"]=$PHORUM["DATA"]["URL"]["TOP"];
}
break;
case PHORUM_APPROVE_MESSAGE_TREE: // approve a message and all answers to it

$old_message = phorum_db_get_message($msgthd_id);
$newpost=array("status"=>PHORUM_STATUS_APPROVED);

$mids = phorum_db_get_messagetree($msgthd_id, $old_message["forum_id"]);
// make an array from the string
$mids_arr=explode(",",$mids);

// count the entries for later use
$num_approved=count($mids_arr);
foreach($mids_arr as $key => $mid) {
// setting the new status
phorum_db_update_message($mid, $newpost);

}

// updating the thread-info
phorum_update_thread_info($old_message['thread']);

// updating the forum-stats
phorum_db_update_forum_stats(false, "+$num_approved", $old_message["datestamp"]);

$PHORUM['DATA']['MESSAGE']="$num_approved ".$PHORUM['DATA']['LANG']['MsgApprovedOk'];
if(isset($PHORUM['args']["prepost"])) {
$PHORUM['DATA']["URL"]["REDIRECT"]=phorum_get_url(PHORUM_CONTROLCENTER_URL,"panel=".PHORUM_CC_UNAPPROVED);
} else {
$PHORUM['DATA']["URL"]["REDIRECT"]=$PHORUM["DATA"]["URL"]["TOP"];
}
break;

case PHORUM_HIDE_POST: // hiding a message (and its replies)

$old_message = phorum_db_get_message($msgthd_id);
$newpost=array("status"=>PHORUM_STATUS_HIDDEN);

$mids = phorum_db_get_messagetree($msgthd_id, $old_message["forum_id"]);
// make an array from the string
$mids_arr=explode(",",$mids);

// count the entries for later use
$num_hidden=count($mids_arr);


foreach($mids_arr as $key => $mid) {
// setting the new status
phorum_db_update_message($mid, $newpost);
}

phorum_hook("hide", $msgthd_id);

// updating the thread-info
phorum_update_thread_info($old_message['thread']);

// updating the forum-stats
phorum_db_update_forum_stats(false, "-$num_hidden", $old_message["datestamp"]);

$PHORUM['DATA']['MESSAGE']="$num_hidden ".$PHORUM['DATA']['LANG']['MsgHiddenOk'];
if(isset($PHORUM['args']["prepost"])) {
$PHORUM['DATA']["URL"]["REDIRECT"]=phorum_get_url(PHORUM_CONTROLCENTER_URL,"panel=".PHORUM_CC_UNAPPROVED);
} else {
$PHORUM['DATA']["URL"]["REDIRECT"]=$PHORUM["DATA"]["URL"]["TOP"];
}


break;

default:
if(!isset($PHORUM['DATA']['MESSAGE'])) $PHORUM['DATA']['MESSAGE']="";
$PHORUM['DATA']["URL"]["REDIRECT"]=$PHORUM["DATA"]["URL"]["TOP"];
}

$PHORUM['DATA']["BACKMSG"]=$PHORUM['DATA']["LANG"]["BackToList"];

include phorum_get_template("header");
phorum_hook("after_header");

include phorum_get_template($template);

phorum_hook("before_footer");
include phorum_get_template("footer");

?>

it doesn't help to post your moderation.php or does that mean that you modified it?
which phorum version are you running?
what do you mean with "doesn't work" is there any error message or what exactly happens?

---

Thomas Seifert

Ok, i'm running version 5.0.15. What happens? Really simple, when i click on every moderation tool, it appears mi default success message. So, i think the action is already done, but when i come back, the post/thread is just like it was in the begining. So, nothing happens, it never dit EDIT, MOVE or DELETE my post/thread. So, moderation, doesnt work...

I have no idea why this is happening for you. We've never seen these issues. This is not really an issue that we will be looking into any further, because Phorum 5.0 is getting really old now that 5.2 is the stable release version. Maybe it's time for you to upgrade your forums. Also to get rid of possible security bugs which might be in your install right now.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce