Firefox PHP

Module: Post Previews

Posted by Joe Curia 
Re: Module: Post Previews
December 22, 2010 09:07PM
The Ajax request returns:
<br />
<b>Fatal error</b>:  Cannot redeclare phorum_format_messages() (previously declared in /home/ppbb/public_html/phorum/include/format_functions.php:49) in
<b>include/format_functions.php</b> on line <b>220</b><br />

In some other comment from above, I see that there is a call like this in the module code:
include("./include/format_functions.php");

Change that call to:
include_once "./include/format_functions.php";

Currently, the format_functions library is loaded twice.


Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce
Re: Module: Post Previews
December 22, 2010 09:11PM
Gee, thanks! I have been trying to use the firebug stuff and not having a lot of luck. guess in a panic is not the best time to learn a debug tool!
you rock.
Maurice / Joe, the offending "include" is in the orginal code for the preview
December 22, 2010 09:23PM
[ppbb@boxster mods]$ vi ./post_previews/post_previews.php

I changed that to include_once and we are good!
I had used the include_once in the snippit that I had added to the forum_subscriptions and it confliced with this one.

This is the code that I updaded of Joe's:
// get the message body to preview - formatted as necessary
if (!empty($PHORUM["phorum_mod_post_previews"]["show_formatted"])) {

include_once("./include/format_functions.php");
$messages[$message_id] = $message;
$formatted_messages = phorum_format_messages($messages);

$body = $formatted_messages[$message_id]["body"];

} else {

$body = $message["body"];
Re: Module: Post Previews
December 23, 2010 02:07AM
Rob, thanks for reporting the bug and helping with the debugging. Maurice, thank you for taking the time to track down the source of this issue. I will include this fix in the next release of my module.


Joe Curia (aka Azumandias)
Modules: l0Admin Mass Email00000000l000000Automatic Time Zones000ll.l00000Enhanced Custom Profiles0.00Google Calendar0000l.l000000Post Previews
000000000Admin Security Suite000000000000Check Modules for Upgrades0000External Authentication000000Group Auto-Email00000.00000Private Message Alerts
000000000Attachment Download Counter0000Custom Attachment Icons000ll.ll00Favorite Forums000000.00000Highlighted Search Terms0000Self-Delete Posts Option
000000000Attachment Watermarks0l00000000Custom Language Database00l.l.0Forum Lockdown00000.00000Ignore Forums0000000000000Threaded Tree View
000000000Automatic Message Pruning00.llll.00Easy Color Scheme Manager0l.l00Forum Subscriptions0000lll000Moderated User Group
Templates:lGeneric Integration000000000 0000Simple Rounded000000 00000000Tabbed Emerald
Re: Module: Post Previews
December 23, 2010 02:10AM
Thank you guys for all the cool mods!
Re: Module: Post Previews
January 04, 2011 12:11PM
Hi Joe,

I published a new version of my German Language Files Package which includes also translations for you module in two character sets iso-8859-1 and utf-8.

Please add the attached language files to the next release of your module and remove maybe existing old style files like german.php oder german-sie.php. Thanks!

Regards
Oliver


Using Phorum since 7/2000: forum.langzeittest.de (actual version 5.2.19)
Modules "Made in Germany" for version 5.2: Author_as_Sender, CarCost, Close_Topic, Conceal_Message_Timestamp,
Format_Email, Index_Structure, Mailing_List, Pervasive_Forum, Spritmonitor, Terms_of_Service and German_Language_Files_Package.
Attachments:
open | download - post_previews-german.zip (2.5 KB)
Re: Module: Post Previews
January 19, 2011 11:58PM
The positioning of the preview window seems to be dependent to the current width of the browser window. Is it possible to position the window related to the link position the user is hovering over?
Re: Module: Post Previews
January 20, 2011 02:23AM
What browser/version are you using? What exactly are you looking for? The preview window should appear directly below or above the focused link depending on how close it is to the upper or lower limits of the window. It should also be horizontally aligned to start at the start of the link, though it does shift over to avoid running off the right edge of the window. This is the exact behavior I see in IE and FireFox. Do you see the same preview positioning on the Phorum website as on your personal Phorum installation?


Joe Curia (aka Azumandias)
Modules: l0Admin Mass Email00000000l000000Automatic Time Zones000ll.l00000Enhanced Custom Profiles0.00Google Calendar0000l.l000000Post Previews
000000000Admin Security Suite000000000000Check Modules for Upgrades0000External Authentication000000Group Auto-Email00000.00000Private Message Alerts
000000000Attachment Download Counter0000Custom Attachment Icons000ll.ll00Favorite Forums000000.00000Highlighted Search Terms0000Self-Delete Posts Option
000000000Attachment Watermarks0l00000000Custom Language Database00l.l.0Forum Lockdown00000.00000Ignore Forums0000000000000Threaded Tree View
000000000Automatic Message Pruning00.llll.00Easy Color Scheme Manager0l.l00Forum Subscriptions0000lll000Moderated User Group
Templates:lGeneric Integration000000000 0000Simple Rounded000000 00000000Tabbed Emerald
Re: Module: Post Previews
January 20, 2011 05:30AM
Thanks for your quick response! I use Chrome and FF. On the official Phorum Preview is not activated. But the window clearly is x-shifting its position depending to the width of the browser window.
Re: Module: Post Previews
January 20, 2011 07:18AM
The module is most definitely installed on this Phorum. There are no positioning issues here.

Unless you provide us with a live URL for demonstrating the issue, it is not possible to debug your issue.


Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce
Sorry, only registered users may post in this forum.

Click here to login