New editor tools module for Phorum 5.1+

As a proof of concept, for testing out the extensibility of the editor tools module, I wrote an addon module for the Editor Tools that implements topic smileys. If you enable the Topic Smiley module in addition to the Editor Tools module, it will override the functionality of the subject smiley tool button. Instead of simply adding smileys to the subject, it will make sure that at most one smiley can be used in the subject and that this smiley is always placed at the verty start of the subject.

The effect of using this module will be that users won't be able to spam the subjects with images, resulting in cleaner message lists. Because all smileys are placed at the start of the subject, the nature of the smiley will be drawn more into the direction of a topic smiley, which can indicate the mood or type of topic.

Note: this module requires editor_tools version 1.1.3 or higher to work.

Currently, the module is activated on my development site, so if you like, you can test it out there. Username/password = phorum/phorum: [phorum-dev.gitaar.net]

Changelog:
----------

2007-04-20 v1.0.5

    - Fixed a PHP warning about "uknown modifier ..." just before the
      posting editor when a subject smiley contains a "/" in it.

2007-03-19 v1.0.4

    - On initialization of a reply message in the posting editor,
      mangle the message subject to prevent stacking of Re: Re: Re: etc...
      in case the original message contains a smiley at the start.

2007-01-15 v1.0.3

    - Changed for compatibility with Editor Tools 1.1.16 (the format
      of the javascript smileys arrays changed to work around a
      javascript problem in MSIE6).

2006-07-17 v1.0.2

    - Changed for compatibility with Editor Tools 1.1.6 (some internal
      names changed in that version).

2006-07-17 v1.0.1

    - Reject the subject if it only contains a smiley. Added language
      support and changed the processing hook for this to work, so
      if upgrading from v1.0.0, you'll have to disable and re-enable
      the module in the admin panel.

2006-07-16 v1.0.0

    - Initial release.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce



Edited 7 time(s). Last edit at 04/20/2007 12:45PM by mmakaay.

Maurice,

I got a whole bunch of message when testing this thing out. Thanks
Notice: Undefined index: CHARSET in /vol-thishost-1/www-phorum-dev/trunk/common.php on line 319

Notice: Undefined index: StartNewTopic in /vol-thishost-1/www-phorum-dev/trunk/posting.php on line 230

Notice: Undefined index: AttachMaxAttachments in /vol-thishost-1/www-phorum-dev/trunk/posting.php on line 447

Notice: Undefined index: CHARSET in /vol-thishost-1/www-phorum-dev/trunk/posting.php on line 483

Notice: Undefined index: CHARSET in /vol-thishost-1/www-phorum-dev/trunk/posting.php on line 483

Notice: Undefined index: CHARSET in /vol-thishost-1/www-phorum-dev/trunk/posting.php on line 483

Notice: Undefined index: CHARSET in /vol-thishost-1/www-phorum-dev/trunk/posting.php on line 483

Notice: Undefined index: CHARSET in /vol-thishost-1/www-phorum-dev/trunk/posting.php on line 483

Notice: Undefined index: CHARSET in /vol-thishost-1/www-phorum-dev/trunk/posting.php on line 483

Notice: Undefined index: CHARSET in /vol-thishost-1/www-phorum-dev/trunk/posting.php on line 483

Notice: Undefined index: CHARSET in /vol-thishost-1/www-phorum-dev/trunk/posting.php on line 483

Notice: Undefined index: CHARSET in /vol-thishost-1/www-phorum-dev/trunk/posting.php on line 483

Notice: Undefined index: CHARSET in /vol-thishost-1/www-phorum-dev/trunk/posting.php on line 483

Notice: Undefined index: CHARSET in /vol-thishost-1/www-phorum-dev/trunk/posting.php on line 483

Notice: Undefined index: CHARSET in /vol-thishost-1/www-phorum-dev/trunk/posting.php on line 483

Notice: Undefined index: CHARSET in /vol-thishost-1/www-phorum-dev/trunk/posting.php on line 483

Notice: Undefined index: CHARSET in /vol-thishost-1/www-phorum-dev/trunk/posting.php on line 483

Notice: Undefined index: CHARSET in /vol-thishost-1/www-phorum-dev/trunk/posting.php on line 483

Notice: Undefined index: CHARSET in /vol-thishost-1/www-phorum-dev/trunk/posting.php on line 483
Notice: Undefined index: CHARSET in /tmp/tpl-default2-header-d8d18c6843affe8c3503f24fa1ccab5a.php-stage2 on line 6
"?>

Notice: Undefined index: Welcome in /tmp/tpl-default2-header-d8d18c6843affe8c3503f24fa1ccab5a.php-stage2 on line 49

[opensourceCMS.com]
[ongetc.com]
Chanh Ong

It looks like you are using the 5.2 development tree Phorum with a language file that isn't completely up to date. "Welcome" and "StartNewTopic" are both new strings in the templates, that weren't in Phorum 5.1. Or did you get this somewhere on my server?

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce

Quote
mmakaay
Or did you get this somewhere on my server?

Yep :)

Also I'm aware that you have noticed that the topic-list would look much cleaner if the images had no borders :)

---
-=[ Panu ]=-

Yes, do not pay too much attention to anything that looks off, weird, ugly and broken. This is the 5.2 development tree which can be wrecked to pieces at any time! ;-) Concentrate on the nifty buttons.

I found the reason for the problems with the user "phorum" on the dev forum. Somebody changed the default language to German, which is not updated for 5.2. I changed the language back to English, so things should be okay again.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce

Hello,

I tried this module. It is wonderful, useful, working, and so on, bravo ! Versy easy to install, it worked at once. I only hed to personalise somme access to the files and pictures as I'm using forum in embedded mode (portable) and the global phorum dir is not transmitted to the module. Perhaps in a later version.

It should be perfect if I didn't have this popup error message "editor_tools.js library reports: no textarea found in this page". This seems to occur after validating a moderator's edited message. Of course in this "redirection" page there is no textarea field. I tried to find where I could tel to the module to not load the texteditor when in this page, but I'm not so familiar with mod writing.

Also, in the colorpicker function, it breaks words in a curious way:

this is my example text

Last remarque: in BBcode function there should be a test to see if the next to word character is a "white space" or not. I think this should be cleaner with a result like

[BBcode]word one[/BBcode]_next word, than currently [BBcode]word two_[/BBcode]next word

Hope this helps to improve much more this very nice addon.

Thanks for the report. I can certainly use it for fixing and improving some things.

I am running the module successfully with embed_phorum, which is basically portable on steroids. So I'm not sure what you had to change here. Is it something that I could help fixing from the module code?

Also, what do you mean with the word breaking of the color picker? What is it that you do there? I can select a piece of text and color it with no problems.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce

I just uploaded version 1.1.4 of the editor tools module. Two of your things are addressed in there Milos. Can you try out this new version?

2006-07-17 v1.1.4

   - Changed vertical aligment for the subject smiley button.

   - Bounding whitespace is now ignored when applying some bbcode
     to a selection. So instead of "this is bold  code"
     it will be "this is bold code". Thanks to Milos for
     the idea.

   - Improved detection for checking if we are running on a page,
     containing an editor. The existing detection had a bug that
     caused a javascript warning about a missing textarea on
     posting confirmation and error pages. Thanks to Milos for
     pointing me at this problem.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce

The color picker is inserting the bbcode right side of the word instead having the word inside of the code when you highlight a word and pick a color.

Here an example

Let say you hightlight a word in your post "red" and pick a color, It should insert the bbcode like this (I replaced [ to { to prevent bbcode on this forum converting it)

{color=#FF0000}red{/color}


instead it's being inserted on the right side of the highlighted word

red{color=#FF0000}{/color}


Also I recommand on the URL link to add a second script box where they would type in the text to href the url address to if they do not highlight a word in thier post like this first box prompt asking for the http url address and when they click "ok" then the second box prompt asking for the text to href to the url address.

Great job on the mod!
Bill



Edited 2 time(s). Last edit at 07/16/2006 10:20PM by CBiLL.

I wrote a fix to make applying a color to a selection work in MSIE correctly. The problem was that MSIE looses the textarea selection completely when focus goes to another object. I now store the active selection and restore it afterwards. The new version 1.1.5 is in the first message of this thread.

I'll have to think about a second popup for the URL tool. I now left it out, to make it work consitently with the other tools. E.g. the color tool or the bold tool do not ask as well for the content to display inside the tags.

---

Maurice Makaay
Phorum Development Team
my blog linkedin profile secret sauce